From owner-freebsd-fs@FreeBSD.ORG Wed Aug 31 22:08:46 2011 Return-Path: Delivered-To: freebsd-fs@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 68D6B106566B; Wed, 31 Aug 2011 22:08:46 +0000 (UTC) (envelope-from rmacklem@uoguelph.ca) Received: from esa-annu.mail.uoguelph.ca (esa-annu.mail.uoguelph.ca [131.104.91.36]) by mx1.freebsd.org (Postfix) with ESMTP id E7E078FC0A; Wed, 31 Aug 2011 22:08:45 +0000 (UTC) X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: Ap8EAOivXk6DaFvO/2dsb2JhbABCFoQ2pHmBQAEBBAEjBFIFFAIOCgICDRkCWQYTh3IEqQOSF4EshBiBEQSTJZEl X-IronPort-AV: E=Sophos;i="4.68,309,1312171200"; d="scan'208";a="132870357" Received: from erie.cs.uoguelph.ca (HELO zcs3.mail.uoguelph.ca) ([131.104.91.206]) by esa-annu-pri.mail.uoguelph.ca with ESMTP; 31 Aug 2011 18:08:44 -0400 Received: from zcs3.mail.uoguelph.ca (localhost.localdomain [127.0.0.1]) by zcs3.mail.uoguelph.ca (Postfix) with ESMTP id C43D5B3F80; Wed, 31 Aug 2011 18:08:44 -0400 (EDT) Date: Wed, 31 Aug 2011 18:08:44 -0400 (EDT) From: Rick Macklem To: George Liaskos Message-ID: <1463532532.632117.1314828524787.JavaMail.root@erie.cs.uoguelph.ca> In-Reply-To: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Originating-IP: [172.17.91.203] X-Mailer: Zimbra 6.0.10_GA_2692 (ZimbraWebClient - FF3.0 (Win)/6.0.10_GA_2692) Cc: freebsd-fs@freebsd.org, Pawel Jakub Dawidek Subject: Re: NFSv4: After upgrade to 9 users can no longer list files. (sounds like a ZFS issue?) X-BeenThere: freebsd-fs@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Filesystems List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 31 Aug 2011 22:08:46 -0000 George Liaskos wrote: > On Wed, Aug 31, 2011 at 3:49 PM, Rick Macklem > wrote: > > Well, I can't imagine why this would matter, but you can try this > > patch, > > which fixes a problem introduced by r224810 where Lookup ".." no > > longer > > works. (It's at http://people.freebsd.org/~rmacklem/dotdot.patch, in > > case > > the white space gets munged.) > > Index: fs/nfsserver/nfs_nfsdport.c > > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D > > --- fs/nfsserver/nfs_nfsdport.c (revision 225270) > > +++ fs/nfsserver/nfs_nfsdport.c (working copy) > > @@ -282,6 +282,7 @@ nfsvno_namei(struct nfsrv_descript *nd, struct > > nam > > > > =C2=A0 =C2=A0 =C2=A0 =C2=A0*retdirp =3D NULL; > > =C2=A0 =C2=A0 =C2=A0 =C2=A0cnp->cn_nameptr =3D cnp->cn_pnbuf; > > + ndp->ni_strictrelative =3D 0; > > =C2=A0 =C2=A0 =C2=A0 =C2=A0/* > > =C2=A0 =C2=A0 =C2=A0 =C2=A0 * Extract and set starting directory. > > =C2=A0 =C2=A0 =C2=A0 =C2=A0 */ > > Index: nfsserver/nfs_serv.c > > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D > > --- nfsserver/nfs_serv.c (revision 225270) > > +++ nfsserver/nfs_serv.c (working copy) > > @@ -157,6 +157,7 @@ ndclear(struct nameidata *nd) > > =C2=A0 =C2=A0 =C2=A0 =C2=A0nd->ni_vp =3D NULL; > > =C2=A0 =C2=A0 =C2=A0 =C2=A0nd->ni_dvp =3D NULL; > > =C2=A0 =C2=A0 =C2=A0 =C2=A0nd->ni_startdir =3D NULL; > > + nd->ni_strictrelative =3D 0; > > =C2=A0} > > > > =C2=A0/* > > > > rick >=20 > This patch works for me. :) >=20 Ah, good. (I can't think of why root vs non-root would have mattered, but if it fixed the problem. Maybe just a side effect, since without being initialized, it would be whatever happened to be on the stack.) Thanks for doing the legwork on this and letting us know. This patch is in the re@ queue, rick. > Regards, > George