From owner-svn-src-all@freebsd.org Sat Jan 6 18:15:51 2018 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 9763DEC5024 for ; Sat, 6 Jan 2018 18:15:51 +0000 (UTC) (envelope-from lists@eitanadler.com) Received: from mail-yw0-x22d.google.com (mail-yw0-x22d.google.com [IPv6:2607:f8b0:4002:c05::22d]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 53584794CF for ; Sat, 6 Jan 2018 18:15:51 +0000 (UTC) (envelope-from lists@eitanadler.com) Received: by mail-yw0-x22d.google.com with SMTP id r205so2935574ywb.3 for ; Sat, 06 Jan 2018 10:15:51 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=eitanadler.com; s=0xdeadbeef; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=U0DAzdxEJdZ6W37+82TunQ99Fg0o8Ujw4+bUN8BcJ/I=; b=GUDQcVcCsz9S/Cjh1lpfvsQIo0RIjHEshuNHZNvxeEJ88w3f/am/3K1Wvy+JsW9XGz ccba3mJ0VR1s7d1vF9T87cRG7WBRXDoOfX0j6jKM2faLO640O9YNPzfAxLR1iM9o9QIm LnGjKTrO272Cf10t1VckpBf1QyXSXliw9U1pQ= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=U0DAzdxEJdZ6W37+82TunQ99Fg0o8Ujw4+bUN8BcJ/I=; b=Xn+wehluiiMmBlK7RwD0JY8k+wdTaZjh8eQ3uon541zLM0jsEuNbXCs7P4SnbqHmo8 AvZzvtXfi3OZ4T9PVImjljQ8NJfuWfD3LgnNe899hx6oe+vQGZoxQbb1mbZJgRQhXcrh rD4s6LkGtTIcYk3Q+2YYtvJr3TJ0BzkwDhx1nRdzdVqlssHGMw/IrWv2M40b0A4znNzP NasIGkzyx4yhcDKEYADFIa+cNfu0mvHDBqiHai3QT8V6HWqxk3lNbm+9ZKRvNUYzCVPx GJEzJwOe4JA/NSWP47Fg8qRyvzn71h4Gf4lvmUhcKyxi7u19djfN0cxohXIbQUVjTgqx +kpg== X-Gm-Message-State: AKGB3mK84NLdfmRlbJetYMlid66UznD98MAzNdq4lsF8txNWTRiCI2cu i0CAL1s2R9Cr7+DTuE4AoqLfyrlT4rP3gqANYyStPw== X-Google-Smtp-Source: ACJfBouZ4map8KnluwkqnUYGl67d53hQzIL5CpoFXok9zgn7RqYbnc5jJlxCo4PR2/DiXVKiZc0e29Tn058r3Bknoqo= X-Received: by 10.13.220.133 with SMTP id f127mr6798622ywe.204.1515262550306; Sat, 06 Jan 2018 10:15:50 -0800 (PST) MIME-Version: 1.0 Received: by 10.37.217.21 with HTTP; Sat, 6 Jan 2018 10:15:19 -0800 (PST) In-Reply-To: References: <201801060948.w069m4Rb058364@repo.freebsd.org> <8CD482D7-1C01-480E-A2DE-5B9E1ACF05D4@FreeBSD.org> From: Eitan Adler Date: Sat, 6 Jan 2018 10:15:19 -0800 Message-ID: Subject: Re: svn commit: r327616 - head/usr.bin/morse To: Dimitry Andric Cc: Li-Wen Hsu , src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Content-Type: text/plain; charset="UTF-8" X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.25 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 06 Jan 2018 18:15:51 -0000 On 6 January 2018 at 09:02, Dimitry Andric wrote: > On 6 Jan 2018, at 17:51, Eitan Adler wrote: >> >> On 6 January 2018 at 08:36, Dimitry Andric wrote: >>> On 6 Jan 2018, at 14:19, Eitan Adler wrote: > ... >>>> Why is testing with "make obj; make" in the morse directory insufficient? > ... >>> usr.bin/morse/morse.c:602:15: error: unused parameter 'stream' [-Werror,-Wunused-parameter] >>> fdecode(FILE *stream) >>> ^ >>> 1 error generated. >>> >>> Maybe you have warnings turned off in your local build environment? >> >> Is there anything that I could set in my environment that would >> override the command line flags? > > It depends. Many people have /etc/make.conf or /etc/src.conf files with > extensive settings and compiler flag modifications, so usually the first > advice is to do: > > export __MAKE_CONF=/dev/null > export SRCCONF=/dev/null > > then attempt to build again. If that works, then slowly go through the > make.conf or src.conf settings, enabling them one by one until you > reproduce the failure (or unexpected success :). Makes sense. I was asking since I copy/pasted the log above which results in success and includes the compiler warnings. My best guess right now is that my timestamps are off resulting a rebuild not actually happening. Either way, thank you to Li-Wen Hsu for fixing and everyone else for dealing with me ;) -- Eitan Adler