From owner-freebsd-current@FreeBSD.ORG Thu Aug 26 00:36:32 2004 Return-Path: Delivered-To: freebsd-current@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id E5FBD16A4CE; Thu, 26 Aug 2004 00:36:32 +0000 (GMT) Received: from harmony.village.org (rover.village.org [168.103.84.182]) by mx1.FreeBSD.org (Postfix) with ESMTP id 8A19743D66; Thu, 26 Aug 2004 00:36:32 +0000 (GMT) (envelope-from imp@bsdimp.com) Received: from localhost (warner@rover2.village.org [10.0.0.1]) by harmony.village.org (8.12.11/8.12.11) with ESMTP id i7Q0a2se006092; Wed, 25 Aug 2004 18:36:02 -0600 (MDT) (envelope-from imp@bsdimp.com) Date: Wed, 25 Aug 2004 18:36:26 -0600 (MDT) Message-Id: <20040825.183626.130239655.imp@bsdimp.com> To: nate@root.org From: "M. Warner Losh" In-Reply-To: <412D2087.4000306@root.org> References: <412D12D4.1000401@root.org> <20040825.163521.103131991.imp@bsdimp.com> <412D2087.4000306@root.org> X-Mailer: Mew version 3.3 on Emacs 21.3 / Mule 5.0 (SAKAKI) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit cc: phk@phk.freebsd.dk cc: current@freebsd.org Subject: Re: No more floppy drive X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 26 Aug 2004 00:36:33 -0000 In message: <412D2087.4000306@root.org> Nate Lawson writes: : M. Warner Losh wrote: : > In message: <412D12D4.1000401@root.org> : > Nate Lawson writes: : > : There are only two ways currently to find fd0 on ISA systems: ACPI _FDE : > : probing and hints. The acpi probe automatically falls back to the hints : > : system if _FDE fails so you should leave the hint.fd.0 lines in but : > : comment out hint.fdc lines (as you've done). : > : > I think this is a bad idea, but may be what we have to do for 5.3. We : > can find out what drives are on the system by asking the rtc() if : > there's no _FDE, which is what the old, pre-acpi code did (which is : > why people are seeing their drives disappear now). : : This is incorrect. The acpi commits did not remove any rtc probe; there : never was one. There were only two commits by me to fdc.c so check them : out to see what I mean. All I did was move the existing hints probe : into its own function, fdc_hints_probe(). The easiest way to see how : fdX gets probed is to look for callers to fdc_add_child(). They are : fdc_acpi_probe_children() and fdc_hints_probe(). The latter is called : by the ISA attachment or the ACPI attachment if the _FDE method is not : present. (BTW, it seems the pccard attachment doesn't probe this way?) The pccard attachment knows there must be a fd. Warner