Date: Sat, 17 Oct 2015 22:20:33 +0100 From: David Malone <dwmalone@maths.tcd.ie> To: Ian Lepore <ian@freebsd.org> Cc: Cy Schubert <cy@FreeBSD.org>, src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r289421 - in head/etc: . mtree ntp Message-ID: <20151017212033.GA43955@walton.maths.tcd.ie> In-Reply-To: <1445106350.71631.36.camel@freebsd.org> References: <201510161404.t9GE4GqM046436@repo.freebsd.org> <1445106350.71631.36.camel@freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Sat, Oct 17, 2015 at 12:25:50PM -0600, Ian Lepore wrote: > If the leapseconds file is present, the leap bits for reference > clocks and downstratum servers are ignored. > > I can't determine from casual code examination (and I don't have time > to experiment now) whether that is true even if the file is expired. The way the code seems to work is: 1) Take a vote from your peers on if there is an upcoming leap second. Refclocks can outvote other peers. (This is in ntp_proto.c:clock_update() - search for leap_vote_ins). 2) If one seems to be pending, try to insert it into an in-memory table for the end of the month. 3) If you find that you loaded a table and the leapsecond you are trying to insert is within the valid range of the table, return an error. (This is in ntp_leapsec.c:leapsec_add()) So, I think the change should be safe, if the comments match the code. David.
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20151017212033.GA43955>