From owner-freebsd-current Tue Nov 12 08:47:30 1996 Return-Path: owner-current Received: (from root@localhost) by freefall.freebsd.org (8.7.5/8.7.3) id IAA04944 for current-outgoing; Tue, 12 Nov 1996 08:47:30 -0800 (PST) Received: from halloran-eldar.lcs.mit.edu (halloran-eldar.lcs.mit.edu [18.26.0.159]) by freefall.freebsd.org (8.7.5/8.7.3) with SMTP id IAA04926 for ; Tue, 12 Nov 1996 08:47:15 -0800 (PST) Received: by halloran-eldar.lcs.mit.edu; (5.65v3.2/1.1.8.2/19Aug95-0530PM) id AA09956; Tue, 12 Nov 1996 11:47:03 -0500 Date: Tue, 12 Nov 1996 11:47:03 -0500 From: Garrett Wollman Message-Id: <9611121647.AA09956@halloran-eldar.lcs.mit.edu> To: Mark Tinguely Cc: freebsd-current@FreeBSD.org Subject: -current mbuf reference function In-Reply-To: <199611121610.KAA13353@plains.nodak.edu> References: <199611121610.KAA13353@plains.nodak.edu> Sender: owner-current@FreeBSD.org X-Loop: FreeBSD.org Precedence: bulk < said: > and even worse the MCLFREE macros in sys/mbuf.h only uses: > --mclrefcnt[mtocl(p)] == 0 > to decrement the reference count and check to see if it time to release. This is correct. It is an error to call MCLFREE if there is a free function (m_ext.ext_free) set. The calling convention could be a lot better (I'd like to have it take a pointer to the mbuf rather than the buffer pointer and size parameters).... > I think either a increment/decrement flag is needed to m_ext.ext_ref, or an > additional decrement function is needed Nope, that function is m_ext.ext_free. -GAWollman -- Garrett A. Wollman | O Siem / We are all family / O Siem / We're all the same wollman@lcs.mit.edu | O Siem / The fires of freedom Opinions not those of| Dance in the burning flame MIT, LCS, ANA, or NSA| - Susan Aglukark and Chad Irschick