From owner-cvs-all Sat Sep 1 23:51:58 2001 Delivered-To: cvs-all@freebsd.org Received: from critter.freebsd.dk (critter.freebsd.dk [212.242.86.163]) by hub.freebsd.org (Postfix) with ESMTP id CED4D37B403; Sat, 1 Sep 2001 23:51:51 -0700 (PDT) Received: from critter (localhost [127.0.0.1]) by critter.freebsd.dk (8.11.4/8.11.4) with ESMTP id f826pHT69329; Sun, 2 Sep 2001 08:51:17 +0200 (CEST) (envelope-from phk@critter.freebsd.dk) To: Matt Dillon Cc: Peter Wemm , cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/kern subr_prof.c kern_ntptime.c kern_xxx.c In-Reply-To: Your message of "Sat, 01 Sep 2001 01:27:32 PDT." <200109010827.f818RW370778@earth.backplane.com> Date: Sun, 02 Sep 2001 08:51:17 +0200 Message-ID: <69327.999413477@critter> From: Poul-Henning Kamp Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG In message <200109010827.f818RW370778@earth.backplane.com>, Matt Dillon writes: > >: static void >: usage() >: { >: /* Insert an empty line if the function has no local variables. */ > > You must be joking. Who came up with that carp? A blank line if > the function has no local variables? In my entire life as a programmer > I have never once seen that style. It looked like a mistake. If I > see any more I won't take out the blank line but... no, I don't want to > know whos idea it was. Well, there must be a lot of the FreeBSD kernel you have never looked at. It's very convenient to know that the first blank line in a function means the end of local variables, it makes simple source-munging scripts much easier. Until such time as you negotiate a change in style(9) on this point, you are just as bound by it as any other committer. -- Poul-Henning Kamp | UNIX since Zilog Zeus 3.20 phk@FreeBSD.ORG | TCP/IP since RFC 956 FreeBSD committer | BSD since 4.3-tahoe Never attribute to malice what can adequately be explained by incompetence. To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message