From owner-freebsd-current@FreeBSD.ORG Mon Jul 16 11:14:44 2012 Return-Path: Delivered-To: freebsd-current@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 964081065672; Mon, 16 Jul 2012 11:14:44 +0000 (UTC) (envelope-from ae@FreeBSD.org) Received: from mail.kirov.so-ups.ru (mail.kirov.so-ups.ru [178.74.170.1]) by mx1.freebsd.org (Postfix) with ESMTP id 392208FC12; Mon, 16 Jul 2012 11:14:44 +0000 (UTC) Received: from kas30pipe.localhost (localhost.kirov.so-ups.ru [127.0.0.1]) by mail.kirov.so-ups.ru (Postfix) with SMTP id 1B247B8027; Mon, 16 Jul 2012 15:14:43 +0400 (MSK) Received: from kirov.so-ups.ru (unknown [172.21.81.1]) by mail.kirov.so-ups.ru (Postfix) with ESMTP id 1444DB8024; Mon, 16 Jul 2012 15:14:43 +0400 (MSK) Received: by ns.kirov.so-ups.ru (Postfix, from userid 1010) id 0FEDEBA081; Mon, 16 Jul 2012 15:14:43 +0400 (MSK) Received: from [127.0.0.1] (unknown [10.118.3.52]) by ns.kirov.so-ups.ru (Postfix) with ESMTP id C9FA9BA07B; Mon, 16 Jul 2012 15:14:42 +0400 (MSK) Message-ID: <5003F79E.1060706@FreeBSD.org> Date: Mon, 16 Jul 2012 15:14:38 +0400 From: "Andrey V. Elsukov" User-Agent: Mozilla Thunderbird 1.5 (FreeBSD/20051231) MIME-Version: 1.0 To: Andriy Gapon References: <4FE9B01C.30306@yandex.ru> <5003EBAB.6030507@FreeBSD.org> <5003F39D.6030808@FreeBSD.org> <5003F589.40603@FreeBSD.org> In-Reply-To: <5003F589.40603@FreeBSD.org> X-Enigmail-Version: 1.4.2 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="------------enig5F36F9C93BB298F6D6BA3735" X-SpamTest-Version: SMTP-Filter Version 3.0.0 [0284], KAS30/Release X-SpamTest-Info: Not protected Cc: freebsd-hackers , Marius Strobl , freebsd-current , Pawel Jakub Dawidek Subject: Re: [CFC/CFT] large changes in the loader(8) code X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 16 Jul 2012 11:14:44 -0000 This is an OpenPGP/MIME signed message (RFC 2440 and 3156) --------------enig5F36F9C93BB298F6D6BA3735 Content-Type: text/plain; charset=KOI8-R Content-Transfer-Encoding: quoted-printable On 16.07.2012 15:05, Andriy Gapon wrote: >>> 2. I am not sure if I like the approach of moving partition tasting c= ode into >>> common ZFS code (zfs.c). On one hand, it now makes sense because the= new >>> partition iteration code is machine-independent. On the other hand, = the reason >>> that I added arch_zfs_probe method was to give platforms full control= over which >>> partitions and in what order are probed. It seems to be important fo= r some of them. >>> So, I like how your new partition interface makes it much easier to Z= FS-probe >>> partitions, but I would prefer to have that code in arch_zfs_probe im= plementations >>> rather than in zfs_probe_dev. >> >> From the other point of view, ZFS is not a just file system and it wor= ks >> directly with disks and partitions. And it seems to me this code will = be common >> for other architectures. >=20 > Well, it seems that you haven't yet touched sparc64_zfs_probe. Yes. It should work as before. But if Marius can suggest how to change ofw_disk.c to get disk size and s= ector size, then i will be able to break something here :) > If you'll find that you don't have to use any ugly hacks there, then go= od. > But my impression is that it would be easier to stick to the previous a= pproach. --=20 WBR, Andrey V. Elsukov --------------enig5F36F9C93BB298F6D6BA3735 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.10 (MingW32) iQEcBAEBAgAGBQJQA/eiAAoJEAHF6gQQyKF6pCkH/3x3pOypbVF48Rfed0jZ/uRI LDUiwWg9ka9NrmX5DjiiNSYKNwQuZsk1EX6Gbv3HwHPHicpeOtes5HI8tlbXx2wo 9/FDJWQuKYo7Xz1AgvD3D026+xbmCXirw0mtYk7j3n9o5j8kuoqgtcsgmEFxjsR+ c8+074sLW1SGHaEjwjGgh9X4wSBpKbmlSEA7sCdc1Q0wX1P38IAjHUymKO7PDjCa XGcGt6KXbmfPWHNVy82Tru12lq0q7fAAxNpTa7nlTmqFmMldhwiw+EbRDOX9OAA6 uNvJ0p4BSUl7uJyjpdjApZeNqXGqqFrJVZsBk0vZEMrglM7knTA5Oy9ZdyecNN4= =Oj40 -----END PGP SIGNATURE----- --------------enig5F36F9C93BB298F6D6BA3735--