From owner-svn-src-all@freebsd.org Fri Dec 8 20:11:32 2017 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id C5EF1E8E132; Fri, 8 Dec 2017 20:11:32 +0000 (UTC) (envelope-from freebsd@pdx.rh.CN85.dnsmgr.net) Received: from pdx.rh.CN85.dnsmgr.net (br1.CN84in.dnsmgr.net [69.59.192.140]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id A87EE2DDE; Fri, 8 Dec 2017 20:11:32 +0000 (UTC) (envelope-from freebsd@pdx.rh.CN85.dnsmgr.net) Received: from pdx.rh.CN85.dnsmgr.net (localhost [127.0.0.1]) by pdx.rh.CN85.dnsmgr.net (8.13.3/8.13.3) with ESMTP id vB8KBUll068553; Fri, 8 Dec 2017 12:11:30 -0800 (PST) (envelope-from freebsd@pdx.rh.CN85.dnsmgr.net) Received: (from freebsd@localhost) by pdx.rh.CN85.dnsmgr.net (8.13.3/8.13.3/Submit) id vB8KBUsA068552; Fri, 8 Dec 2017 12:11:30 -0800 (PST) (envelope-from freebsd) From: "Rodney W. Grimes" Message-Id: <201712082011.vB8KBUsA068552@pdx.rh.CN85.dnsmgr.net> Subject: Re: svn commit: r326614 - in head: etc/mtree usr.bin usr.bin/sponge usr.bin/tee In-Reply-To: To: cem@freebsd.org Date: Fri, 8 Dec 2017 12:11:30 -0800 (PST) CC: "Rodney W. Grimes" , Eitan Adler , src-committers , svn-src-all@freebsd.org, svn-src-head@freebsd.org Reply-To: rgrimes@freebsd.org X-Mailer: ELM [version 2.4ME+ PL121h (25)] MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset=US-ASCII X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.25 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 08 Dec 2017 20:11:32 -0000 [ Charset UTF-8 unsupported, converting... ] > On Tue, Dec 5, 2017 at 7:10 PM, Rodney W. Grimes > wrote: > > [ Charset UTF-8 unsupported, converting... ] > >> Author: eadler > >> Date: Wed Dec 6 02:47:46 2017 > >> New Revision: 326614 > >> URL: https://svnweb.freebsd.org/changeset/base/326614 > >> > >> Log: > >> sponge(1): revert > >> > >> I did a complete buildworld and test... with the program disconnected > >> from the tree. Revert the change for now. > >> > >> (this keeps the change to .arclint which is still correct) > > > > Commited with no log entry that makes any sense about why it was changed, > > please revert .arclint and recommit with a proper log entry for .arclint > > as to why all /tests/ dirs should be ignored. > > I have to agree with Rod. The commit message for the arclint change > is currently "sponge(1): initial commit ?" and doesn't say anything > about the arclint change. Even if the change is correct, the commit > message isn't. Ping, I have not seen this reverted and recommitted with a reasonable explination as to why this change is actually desired. Thanks, -- Rod Grimes rgrimes@freebsd.org