From owner-freebsd-threads@freebsd.org  Wed May  4 12:12:04 2016
Return-Path: <owner-freebsd-threads@freebsd.org>
Delivered-To: freebsd-threads@mailman.ysv.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 by mailman.ysv.freebsd.org (Postfix) with ESMTP id 5FCD8B2A954
 for <freebsd-threads@mailman.ysv.freebsd.org>;
 Wed,  4 May 2016 12:12:04 +0000 (UTC)
 (envelope-from bugzilla-noreply@freebsd.org)
Received: from kenobi.freebsd.org (kenobi.freebsd.org
 [IPv6:2001:1900:2254:206a::16:76])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (Client did not present a certificate)
 by mx1.freebsd.org (Postfix) with ESMTPS id 50B261A20
 for <freebsd-threads@FreeBSD.org>; Wed,  4 May 2016 12:12:04 +0000 (UTC)
 (envelope-from bugzilla-noreply@freebsd.org)
Received: from bugs.freebsd.org ([127.0.1.118])
 by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id u44CC3bP069572
 for <freebsd-threads@FreeBSD.org>; Wed, 4 May 2016 12:12:04 GMT
 (envelope-from bugzilla-noreply@freebsd.org)
From: bugzilla-noreply@freebsd.org
To: freebsd-threads@FreeBSD.org
Subject: [Bug 209233] [patch] pthread_suspend_all_np races with check_suspend
Date: Wed, 04 May 2016 12:12:04 +0000
X-Bugzilla-Reason: AssignedTo
X-Bugzilla-Type: changed
X-Bugzilla-Watch-Reason: None
X-Bugzilla-Product: Base System
X-Bugzilla-Component: threads
X-Bugzilla-Version: 11.0-CURRENT
X-Bugzilla-Keywords: patch
X-Bugzilla-Severity: Affects Some People
X-Bugzilla-Who: le277@cam.ac.uk
X-Bugzilla-Status: New
X-Bugzilla-Resolution: 
X-Bugzilla-Priority: ---
X-Bugzilla-Assigned-To: freebsd-threads@FreeBSD.org
X-Bugzilla-Flags: 
X-Bugzilla-Changed-Fields: 
Message-ID: <bug-209233-16-1hGCyd2Ykt@https.bugs.freebsd.org/bugzilla/>
In-Reply-To: <bug-209233-16@https.bugs.freebsd.org/bugzilla/>
References: <bug-209233-16@https.bugs.freebsd.org/bugzilla/>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/
Auto-Submitted: auto-generated
MIME-Version: 1.0
X-BeenThere: freebsd-threads@freebsd.org
X-Mailman-Version: 2.1.22
Precedence: list
List-Id: Threading on FreeBSD <freebsd-threads.freebsd.org>
List-Unsubscribe: <https://lists.freebsd.org/mailman/options/freebsd-threads>, 
 <mailto:freebsd-threads-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-threads/>
List-Post: <mailto:freebsd-threads@freebsd.org>
List-Help: <mailto:freebsd-threads-request@freebsd.org?subject=help>
List-Subscribe: <https://lists.freebsd.org/mailman/listinfo/freebsd-threads>, 
 <mailto:freebsd-threads-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Wed, 04 May 2016 12:12:04 -0000

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D209233

--- Comment #2 from Lawrence Esswood <le277@cam.ac.uk> ---
(In reply to Konstantin Belousov from comment #1)

This would end up doing the same thing in the suspend logic as always setti=
ng
the NEED_SUSPEND flag, as the !(thread->flags & THR_FLAGS_SUSPENDED) check
would always be true if THR_FLAGS_NEED_SUSPEND was clear and if we insisted
that !THR_FLAGS_NEED_SUSPEND =3D> !THR_FLAGS_SUSPENDED after a resume. The =
only
(observable) difference would be extra blocking in resume which we probabab=
ly
want to avoid.

--=20
You are receiving this mail because:
You are the assignee for the bug.=