From owner-svn-src-head@freebsd.org Fri Jun 3 14:05:25 2016 Return-Path: Delivered-To: svn-src-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 141D7B68E6C; Fri, 3 Jun 2016 14:05:25 +0000 (UTC) (envelope-from onwahe@gmail.com) Received: from mail-io0-f175.google.com (mail-io0-f175.google.com [209.85.223.175]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id DE9E316C6; Fri, 3 Jun 2016 14:05:24 +0000 (UTC) (envelope-from onwahe@gmail.com) Received: by mail-io0-f175.google.com with SMTP id p194so75792338iod.1; Fri, 03 Jun 2016 07:05:24 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=seqEaikiqXv+TsfYzFM7E+SJUdu7bfqU3URYrqLbjnE=; b=L33dY9vONJU1YW2KVeryEOo/Wq9ERxJZ2lW/W3bIlR3x1MJgDfE+IgNvmV1tCuP5WJ mtGpX37Xj0P16oktTXraA00MmxhUYEmi2PDWaixc5U3Q4k8Nk3aukkbnWQSprwnQ9lbB mOZtQkj/ZADStY8Ao/GVdHNmhdxDpoG3RmQM5pDq/kjfsy9tBSdkMrHUqtPUrkQoPxCP +mcwmrB2yuv92JUyOfu/nVnOlf/P6Q6cxLce0mCQjN3o5JFNN2Fush7Tzavxra9VCYq+ c+w8zqGKTRwasOCzA1aSVIT26HlisuaJ+bJycaSmIAb/fXrqYPJCrJr/+VJ2Tq0uY4mm lyGw== X-Gm-Message-State: ALyK8tJ/NqmQir4AQWSMb9EddUUonhhjhYMAvPhZTNEa02wD1LgVZYRJmAnZRnU8YT0VmA== X-Received: by 10.107.140.132 with SMTP id o126mr5375599iod.70.1464962347193; Fri, 03 Jun 2016 06:59:07 -0700 (PDT) Received: from mail-it0-f51.google.com (mail-it0-f51.google.com. [209.85.214.51]) by smtp.gmail.com with ESMTPSA id h125sm2842388ioa.20.2016.06.03.06.59.06 (version=TLSv1/SSLv3 cipher=OTHER); Fri, 03 Jun 2016 06:59:07 -0700 (PDT) Received: by mail-it0-f51.google.com with SMTP id f67so9491700ith.1; Fri, 03 Jun 2016 06:59:06 -0700 (PDT) X-Received: by 10.36.61.199 with SMTP id n190mr5556890itn.64.1464962346586; Fri, 03 Jun 2016 06:59:06 -0700 (PDT) MIME-Version: 1.0 Received: by 10.64.60.67 with HTTP; Fri, 3 Jun 2016 06:59:06 -0700 (PDT) In-Reply-To: <20160603134031.7a038244@zapp> References: <201606031105.u53B5tVi073576@repo.freebsd.org> <20160603134031.7a038244@zapp> From: Svatopluk Kraus Date: Fri, 3 Jun 2016 15:59:06 +0200 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: svn commit: r301266 - head/sys/arm/freescale/imx To: Andrew Turner Cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Content-Type: text/plain; charset=UTF-8 X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 03 Jun 2016 14:05:25 -0000 On Fri, Jun 3, 2016 at 2:40 PM, Andrew Turner wrote: > On Fri, 3 Jun 2016 11:05:55 +0000 (UTC) > Svatopluk Kraus wrote: > >> Author: skra >> Date: Fri Jun 3 11:05:55 2016 >> New Revision: 301266 >> URL: https://svnweb.freebsd.org/changeset/base/301266 >> >> Log: >> Postpone allocation of IRQ resource to the time when interrupt >> controller devices are attached. This has already been done for >> bus_setup_intr(). >> >> There was no doubt that if someone wants to setup an interrupt, >> corresponding interrupt controller device must already be attached. >> However, the same must be valid for allocation of an interrupt >> resource unless the allocation is done blindly, without any >> information that such interrupt even exists. While it was done this >> blind way before, it won't be possible after next INTRNG change. >> >> Modified: >> head/sys/arm/freescale/imx/imx6_anatop.c >> >> Modified: head/sys/arm/freescale/imx/imx6_anatop.c >> ============================================================================== >> --- head/sys/arm/freescale/imx/imx6_anatop.c Fri Jun 3 >> 10:28:06 2016 (r301265) +++ >> head/sys/arm/freescale/imx/imx6_anatop.c Fri Jun 3 11:05:55 >> 2016 (r301266) @@ -78,7 +78,6 @@ __FBSDID("$FreeBSD$"); >> static struct resource_spec imx6_anatop_spec[] = { >> { SYS_RES_MEMORY, 0, RF_ACTIVE }, >> - { SYS_RES_IRQ, 0, RF_ACTIVE }, > > Why not mark it as optional? The interrupt resource must be allocated in any case. So, I do not see any reason why to make it RF_OPTIONAL. > > Andrew