From owner-p4-projects@FreeBSD.ORG  Mon May 31 06:01:25 2010
Return-Path: <owner-p4-projects@FreeBSD.ORG>
Delivered-To: p4-projects@freebsd.org
Received: by hub.freebsd.org (Postfix, from userid 32767)
	id 0CB701065688; Mon, 31 May 2010 06:01:25 +0000 (UTC)
Delivered-To: perforce@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id C468E1065676;
	Mon, 31 May 2010 06:01:24 +0000 (UTC) (envelope-from imp@bsdimp.com)
Received: from harmony.bsdimp.com (bsdimp.com [199.45.160.85])
	by mx1.freebsd.org (Postfix) with ESMTP id DBC908FC16;
	Mon, 31 May 2010 06:01:23 +0000 (UTC)
Received: from localhost (localhost [127.0.0.1])
	by harmony.bsdimp.com (8.14.3/8.14.1) with ESMTP id o4V60m4c003720;
	Mon, 31 May 2010 00:00:49 -0600 (MDT) (envelope-from imp@bsdimp.com)
Date: Mon, 31 May 2010 00:00:55 -0600 (MDT)
Message-Id: <20100531.000055.923725949146439083.imp@bsdimp.com>
To: hselasky@c2i.net
From: "M. Warner Losh" <imp@bsdimp.com>
In-Reply-To: <201005302101.02794.hselasky@c2i.net>
References: <201005301444.o4UEidHb057496@repoman.freebsd.org>
	<AANLkTilpZTmKr3tTrfafgt5CtskJB3LMEM_XoOsJdKq2@mail.gmail.com>
	<201005302101.02794.hselasky@c2i.net>
X-Mailer: Mew version 6.3 on Emacs 22.3 / Mule 5.0 (SAKAKI)
Mime-Version: 1.0
Content-Type: Text/Plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
Cc: perforce@freebsd.org, zec@freebsd.org, gcooper@freebsd.org
Subject: Re: PERFORCE change 178978 for review
X-BeenThere: p4-projects@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: p4 projects tree changes <p4-projects.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/p4-projects>,
	<mailto:p4-projects-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/p4-projects>
List-Post: <mailto:p4-projects@freebsd.org>
List-Help: <mailto:p4-projects-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/p4-projects>,
	<mailto:p4-projects-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Mon, 31 May 2010 06:01:25 -0000

In message: <201005302101.02794.hselasky@c2i.net>
            Hans Petter Selasky <hselasky@c2i.net> writes:
: On Sunday 30 May 2010 20:59:33 Garrett Cooper wrote:
: > >     if (version != 1)
: > > -       return (ENOPROTOOPT);
: > > +       return ENOPROTOOPT;
: > 
: > That's actually a style regression (along with any other return calls
: > without parentheses).
: > 
: 
: FYI:
: 
: Linux style mandatates return values without parentheses. And FreeBSD style 
: mandates that opposite!

NetBSD style mandates their absence too...

Warner