From nobody Sat Apr 25 13:46:17 2026 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4g2rhs3Pppz6bX9l for ; Sat, 25 Apr 2026 13:46:37 +0000 (UTC) (envelope-from jrtc27@jrtc27.com) Received: from mail-wm1-f49.google.com (mail-wm1-f49.google.com [209.85.128.49]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "WR4" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4g2rhs1T27z4PBQ for ; Sat, 25 Apr 2026 13:46:32 +0000 (UTC) (envelope-from jrtc27@jrtc27.com) Authentication-Results: mx1.freebsd.org; none Received: by mail-wm1-f49.google.com with SMTP id 5b1f17b1804b1-488b0e1b870so144551065e9.2 for ; Sat, 25 Apr 2026 06:46:32 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1777124790; x=1777729590; h=to:references:message-id:content-transfer-encoding:cc:date :in-reply-to:from:subject:mime-version:x-gm-gg:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=wOSshdp090DIjqEGWpbZTTdBu/S8Ygx7TXmGHm91GjQ=; b=AtBU9sLJPqOC0ZfaXdHZQkZH3iYUUkBCfDHgVF38xn1qFd4BtJp0K82E6xLRkYDG+3 6A9Jge5JrKrNRrO1D/CFEjhdHfTSNQX6QEevU6EEyeIYUmSH9PONmSur5Py7PGvGKGmq l8eQDxVJJdCHiGVukTWgQqQk8M1FK7imACmzZUgOfUw9u0AdaKdSU1y96HLY9C9RbPW9 EOvmrq6ljKt+s0Rmce0k2TomDMF6kDGw4x2lqCsDX4u0gi148yGU+Z4gchmkMfEyjJuB 4K/pVudA9in4O1rGppuiBA50s9E4JRr99hLIpNthlG+IWPxRQRsrK6ibrMyzWWE2FVYk HCiA== X-Forwarded-Encrypted: i=1; AFNElJ8ezSxmvf08UBK9GX8WQoCcN0ko01REMKQnYzRbYClNRISo0IfPj/FizBI8bWWJic0pzIZC/l3yYyC7cOpUIjkDHXMorg==@freebsd.org X-Gm-Message-State: AOJu0YznD7pt0hjEOm3RJxkN9gIqD3kTs6dpkb24j8Qec13JVFh8TQ/H XUhhheZtRwuqC2cUSngGqCQprNkI5166V0ujJ3GSWEpF2UA3QXebNanE3v7un/7ik0BGpyWYppu XJlcQWiE= X-Gm-Gg: AeBDieubZ1/XfV2e2ibkq5lpurd3HysjWGgZhx4/gQndYDGdf2h2otUFU3VXrMYp40E 6riRIYn/hvn1TDloVjH1Lk7lL5cuWtKYAb/U502aQBtQuxtiyDg8lIql7Mz0/ahUyEzL90jy4l9 b2o8obpEQG4ogEvYkJr2IEc5+HzbNXWKH7exbzaKkZfve+AQDczbagAuCyQCFrN0fEVkrWLl9Kk oUkWMc/j0rPxtQYUYrAdQ7cdizMutWGJr2Xsw9pad8BnRec+uZHMK+uOhz+voWecYkrAoHpmvrr Z7PLdhxsaARVIuBhZOwGHoFNgL8plRPFuXRoEpGCkn684gZpO+fxGgAYmP/ychwanjNjmsuHARM W3jwbnXqSOndPsYQU4EHbNFSUjpWbu6M2tGCromKxERjDoQu6zvWRffNNr2oL8pa2zaIxXU5Gkm SxelKbBi70dP/34cRKwHetiE3uppHEqk00rfVeGXzUYWk5FslPbrfDyiTurJnYbHhN13FZRepAA T3J+g== X-Received: by 2002:a05:600c:37c6:b0:48a:65a5:750f with SMTP id 5b1f17b1804b1-48a65a57563mr95736675e9.21.1777124789502; Sat, 25 Apr 2026 06:46:29 -0700 (PDT) Received: from smtpclient.apple (nat-184-78.net.cam.ac.uk. [131.111.184.78]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-488fb7bf696sm204045265e9.32.2026.04.25.06.46.27 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Sat, 25 Apr 2026 06:46:28 -0700 (PDT) Content-Type: text/plain; charset=utf-8 List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-main@freebsd.org Sender: owner-dev-commits-src-main@FreeBSD.org Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3864.400.21\)) Subject: Re: git: 753a166bdeb3 - main - imgact_elf: Fix uninitialized variable use in note_procstat_auxv From: Jessica Clarke In-Reply-To: <69ecc4df.33991.53b0871@gitrepo.freebsd.org> Date: Sat, 25 Apr 2026 14:46:17 +0100 Cc: "src-committers@freebsd.org" , "dev-commits-src-all@freebsd.org" , "dev-commits-src-main@freebsd.org" , Alex Richardson Content-Transfer-Encoding: quoted-printable Message-Id: <7DD33B7A-A4B7-4AF7-9EA6-CF65BF388500@freebsd.org> References: <69ecc4df.33991.53b0871@gitrepo.freebsd.org> To: Dimitry Andric X-Mailer: Apple Mail (2.3864.400.21) X-Rspamd-Pre-Result: action=no action; module=replies; Message is reply to one we originated X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[]; ASN(0.00)[asn:15169, ipnet:209.85.128.0/17, country:US] X-Rspamd-Queue-Id: 4g2rhs1T27z4PBQ X-Spamd-Bar: ---- On 25 Apr 2026, at 14:42, Dimitry Andric wrote: > The branch main has been updated by dim: >=20 > URL: = https://cgit.FreeBSD.org/src/commit/?id=3D753a166bdeb3aeba02fd9678e7360f09= 29007368 >=20 > commit 753a166bdeb3aeba02fd9678e7360f0929007368 > Author: Alex Richardson > AuthorDate: 2025-09-15 06:27:12 +0000 > Commit: Dimitry Andric > CommitDate: 2026-04-25 13:42:16 +0000 >=20 > imgact_elf: Fix uninitialized variable use in note_procstat_auxv >=20 > Found building with latest clang >=20 > MFC after: 3 days > --- > sys/kern/imgact_elf.c | 9 ++++++--- > 1 file changed, 6 insertions(+), 3 deletions(-) >=20 > diff --git a/sys/kern/imgact_elf.c b/sys/kern/imgact_elf.c > index af0841c75549..3c5fbe4df342 100644 > --- a/sys/kern/imgact_elf.c > +++ b/sys/kern/imgact_elf.c > @@ -2712,13 +2712,16 @@ __elfN(note_procstat_auxv)(void *arg, struct = sbuf *sb, size_t *sizep) > struct proc *p; > size_t size; > int structsize; > - > +#if defined(COMPAT_FREEBSD32) && __ELF_WORD_SIZE =3D=3D 32 > + structsize =3D sizeof(Elf32_Auxinfo); Elf_Auxinfo *is* Elf32_Auxinfo for __ELF_WORD_SIZE =3D=3D 32? > +#else > + structsize =3D sizeof(Elf_Auxinfo); > +#endif > p =3D arg; > structsize =3D sizeof(Elf_Auxinfo); But it=E2=80=99s initialised right here? So that assignment is dead? > if (sb =3D=3D NULL) { > size =3D 0; > - sb =3D sbuf_new(NULL, NULL, AT_COUNT * sizeof(Elf_Auxinfo), > - SBUF_FIXEDLEN); > + sb =3D sbuf_new(NULL, NULL, AT_COUNT * structsize, SBUF_FIXEDLEN); These are equivalent? Though this one at least I see an argument for. > sbuf_set_drain(sb, sbuf_count_drain, &size); > sbuf_bcat(sb, &structsize, sizeof(structsize)); > PHOLD(p); >=20 I really don=E2=80=99t understand this change at all. I think all but = the final part should be reverted. Jessica