Skip site navigation (1)Skip section navigation (2)
Date:      Fri, 11 Mar 2016 13:58:41 +0000 (UTC)
From:      Mathieu Arnold <mat@FreeBSD.org>
To:        doc-committers@freebsd.org, svn-doc-all@freebsd.org, svn-doc-head@freebsd.org
Subject:   svn commit: r48372 - in head/en_US.ISO8859-1/books/porters-handbook: makefiles plist special
Message-ID:  <201603111358.u2BDwf5N030329@repo.freebsd.org>

next in thread | raw e-mail | index | archive | help
Author: mat
Date: Fri Mar 11 13:58:41 2016
New Revision: 48372
URL: https://svnweb.freebsd.org/changeset/doc/48372

Log:
  Always echo commands during the install phase.
  
  Sponsored by:	Absolight
  Differential Revision:	https://reviews.freebsd.org/D5581

Modified:
  head/en_US.ISO8859-1/books/porters-handbook/makefiles/chapter.xml
  head/en_US.ISO8859-1/books/porters-handbook/plist/chapter.xml
  head/en_US.ISO8859-1/books/porters-handbook/special/chapter.xml

Modified: head/en_US.ISO8859-1/books/porters-handbook/makefiles/chapter.xml
==============================================================================
--- head/en_US.ISO8859-1/books/porters-handbook/makefiles/chapter.xml	Fri Mar 11 09:50:30 2016	(r48371)
+++ head/en_US.ISO8859-1/books/porters-handbook/makefiles/chapter.xml	Fri Mar 11 13:58:41 2016	(r48372)
@@ -5111,6 +5111,16 @@ PORTVERSION=	1.0</programlisting>
   <sect1 xml:id="install">
     <title>Installing Files</title>
 
+    <important>
+      <para>The <buildtarget>install</buildtarget> phase is the most
+	important from the end-user's point of view as it is the one
+	adding files to his system.  All the additional commands run
+	in the port's <filename>Makefile</filename> in all the
+	<buildtarget>*-install</buildtarget> targets should be
+	echo'ed.  <emphasis>Do not</emphasis> silence them with
+	<literal>@</literal> or <literal>.SILENT</literal>.</para>
+    </important>
+
     <sect2 xml:id="install-macros">
       <title><varname>INSTALL_<replaceable>*</replaceable></varname>
 	Macros</title>
@@ -5303,6 +5313,12 @@ PORTVERSION=	1.0</programlisting>
 	${MKDIR} ${STAGEDIR}${DOCSDIR}
 	${INSTALL_MAN} ${WRKSRC}/docs/xvdocs.ps ${STAGEDIR}${DOCSDIR}</programlisting>
 
+      <para>On the other hand, if there is a DOCS option in the port,
+	install the documentation in a
+	<buildtarget>post-install-DOCS-on</buildtarget> target.  These
+	targets are described in <xref
+	  linkend="options-targets"/>.</para>
+
       <para>Here are some handy variables and how they are expanded by
 	default when used in the <filename>Makefile</filename>:</para>
 

Modified: head/en_US.ISO8859-1/books/porters-handbook/plist/chapter.xml
==============================================================================
--- head/en_US.ISO8859-1/books/porters-handbook/plist/chapter.xml	Fri Mar 11 09:50:30 2016	(r48371)
+++ head/en_US.ISO8859-1/books/porters-handbook/plist/chapter.xml	Fri Mar 11 13:58:41 2016	(r48372)
@@ -162,7 +162,7 @@ PLIST_SUB+=	X11I386="@comment "
 	them in the <filename>Makefile</filename>:</para>
 
       <programlisting>post-stage:
-	@${MKDIR} ${STAGEDIR}${PREFIX}/some/directory</programlisting>
+	${MKDIR} ${STAGEDIR}${PREFIX}/some/directory</programlisting>
 
       <para>Add the directory to <filename>pkg-plist</filename>
 	like any other.  For example:</para>

Modified: head/en_US.ISO8859-1/books/porters-handbook/special/chapter.xml
==============================================================================
--- head/en_US.ISO8859-1/books/porters-handbook/special/chapter.xml	Fri Mar 11 09:50:30 2016	(r48371)
+++ head/en_US.ISO8859-1/books/porters-handbook/special/chapter.xml	Fri Mar 11 13:58:41 2016	(r48372)
@@ -3216,7 +3216,7 @@ post-extract:
 do-install:
 	cd ${WRKDIR} &amp;&amp; \
 	${INSTALL} -d -o ${WWWOWN} -g ${WWWGRP} ${TOMCATDIR}/webapps/${PORTDIRNAME}
-	@cd ${WRKDIR}/${PORTDIRNAME} &amp;&amp; ${COPYTREE_SHARE} \* ${WEBAPPDIR}/${PORTDIRNAME}</programlisting>
+	cd ${WRKDIR}/${PORTDIRNAME} &amp;&amp; ${COPYTREE_SHARE} \* ${WEBAPPDIR}/${PORTDIRNAME}</programlisting>
 
       <para>Regardless of the type of port (library or
 	application), the additional documentation is installed in the



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201603111358.u2BDwf5N030329>