From owner-svn-src-all@freebsd.org Sat Nov 30 19:02:13 2019 Return-Path: Delivered-To: svn-src-all@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 5F9411B3C6A for ; Sat, 30 Nov 2019 19:02:13 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Received: from mail-qk1-x741.google.com (mail-qk1-x741.google.com [IPv6:2607:f8b0:4864:20::741]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1O1" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 47QLN43vl8z4LnF for ; Sat, 30 Nov 2019 19:02:12 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Received: by mail-qk1-x741.google.com with SMTP id v23so20827013qkg.2 for ; Sat, 30 Nov 2019 11:02:12 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bsdimp-com.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=xkN9OrfTI8XkZDp5ZQaAHNPgXehH4kbR12vejV7Dk1I=; b=N/I+YfJh9rWckgY8gub0RH6RyOxnbDjso/HYUVaEEAtf8nWRjiHjJWFmZGt8gAJUYF Gta9yWhF3PRMEc8zSw52+ZEL0WO447KJRVaToBBPRaCpOAIZOkiZmySQQrYNIyNtM1A8 BNGAkdqgfH7rttRTDJ6MREJbd+UI27cpCTxvF8RHcJ+JluKp9z7akyUJUSdt/p0FBGxH cWJ+bnr68xFi9ieKyv1UTF2FM5Rsnfsp22powsoIa8Jup6N4C6zIo9rqk2sBMevNPMtE uDeSXYrtMfUhMJsYTq9CfCLKogK5dNdFwLQNJuKUvlkwhdeUaDIVi4uuba4bdtzfew54 zQ3A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=xkN9OrfTI8XkZDp5ZQaAHNPgXehH4kbR12vejV7Dk1I=; b=ZvR8/guAHtO32p4N8SioWORvZV+Nf59Of/JpMyGWJQGWAfYOEkvZduUSWfPTFSeQEx 3GNJRSHVBfHGXVD3VfsUyFRnlXvcZd53siTe3J6yq+jNPaGnX3AeekohaMBaBPNYwW0M H/ENRKkwsywnD7lsKIt+AuUFmCBKnR4cAPKLteuwjiV+u363/7BPSKhJwD8IYQ6qvfNm YBr9iSP22Uy8ITdrD0swLvEn+Ij8lzXzkkwsKxhCDuT5SWwjVEgRuFfGVo+HkttpidIf CV9czw/hDPEhaMXbZc4fHTlsxTAuAovo0NNRwsTrvmxD2RcbTRTWaau3S4GeZvQOuAzt pMHg== X-Gm-Message-State: APjAAAXwlVIl5E451yfhWc72fu530+ZGleMQXWzL/G+GVuyPBLqUl+1p p9qEyVjIFpmzyhJiHY0m8ltivVE0rB6hgolYPr0ZXQ== X-Google-Smtp-Source: APXvYqwB+8q8mnJmcBsVlwt7kkvqCaODmNb8vDjhxGhrSGnHw86DUrI4GUvbXVrZs37u2hJ0vziJ1zri2jzTU4GTxAM= X-Received: by 2002:a37:b0c5:: with SMTP id z188mr24245793qke.215.1575140528073; Sat, 30 Nov 2019 11:02:08 -0800 (PST) MIME-Version: 1.0 References: <201911280232.xAS2WHtb029602@repo.freebsd.org> <41D40355-A16E-48E1-9C11-0C9E42C83A42@gmail.com> In-Reply-To: From: Warner Losh Date: Sat, 30 Nov 2019 12:01:57 -0700 Message-ID: Subject: Re: svn commit: r355164 - in head: . share/man/man4 sys/amd64/conf sys/conf sys/dev/trm sys/i386/conf sys/modules sys/modules/trm To: Enji Cooper Cc: Scott Long , src-committers , svn-src-all , svn-src-head X-Rspamd-Queue-Id: 47QLN43vl8z4LnF X-Spamd-Bar: -- Authentication-Results: mx1.freebsd.org; dkim=pass header.d=bsdimp-com.20150623.gappssmtp.com header.s=20150623 header.b=N/I+YfJh; dmarc=none; spf=none (mx1.freebsd.org: domain of wlosh@bsdimp.com has no SPF policy when checking 2607:f8b0:4864:20::741) smtp.mailfrom=wlosh@bsdimp.com X-Spamd-Result: default: False [-2.37 / 15.00]; ARC_NA(0.00)[]; NEURAL_HAM_MEDIUM(-1.00)[-0.997,0]; R_DKIM_ALLOW(-0.20)[bsdimp-com.20150623.gappssmtp.com:s=20150623]; FROM_HAS_DN(0.00)[]; NEURAL_HAM_LONG(-1.00)[-1.000,0]; MIME_GOOD(-0.10)[multipart/alternative,text/plain]; PREVIOUSLY_DELIVERED(0.00)[svn-src-all@freebsd.org]; DMARC_NA(0.00)[bsdimp.com]; RCPT_COUNT_FIVE(0.00)[5]; TO_MATCH_ENVRCPT_SOME(0.00)[]; TO_DN_ALL(0.00)[]; DKIM_TRACE(0.00)[bsdimp-com.20150623.gappssmtp.com:+]; RCVD_IN_DNSWL_NONE(0.00)[1.4.7.0.0.0.0.0.0.0.0.0.0.0.0.0.0.2.0.0.4.6.8.4.0.b.8.f.7.0.6.2.list.dnswl.org : 127.0.5.0]; R_SPF_NA(0.00)[]; FORGED_SENDER(0.30)[imp@bsdimp.com,wlosh@bsdimp.com]; FREEMAIL_TO(0.00)[gmail.com]; MIME_TRACE(0.00)[0:+,1:+,2:~]; IP_SCORE(-0.37)[ip: (2.38), ipnet: 2607:f8b0::/32(-2.25), asn: 15169(-1.94), country: US(-0.05)]; ASN(0.00)[asn:15169, ipnet:2607:f8b0::/32, country:US]; FROM_NEQ_ENVFROM(0.00)[imp@bsdimp.com,wlosh@bsdimp.com]; RCVD_TLS_ALL(0.00)[]; RCVD_COUNT_TWO(0.00)[2] Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Content-Filtered-By: Mailman/MimeDel 2.1.29 X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 30 Nov 2019 19:02:13 -0000 On Sat, Nov 30, 2019 at 11:58 AM Enji Cooper wrote: > > On Nov 30, 2019, at 10:03 AM, Warner Losh wrote: > > > > On Sat, Nov 30, 2019 at 10:47 AM Enji Cooper > wrote: > >> >> > On Nov 27, 2019, at 6:32 PM, Scott Long wrote: >> > >> > Author: scottl >> > Date: Thu Nov 28 02:32:17 2019 >> > New Revision: 355164 >> > URL: https://svnweb.freebsd.org/changeset/base/355164 >> > >> > Log: >> > Remove the trm(4) driver >> > >> > Differential Revision: https://reviews.freebsd.org/D22575 >> >> Hi Scott, >> I believe this driver was removed because it was impacts the CAM >> GIANT lock removal effort =E2=80=94 is that true (I=E2=80=99m asking bec= ause the =E2=80=9Cwhy=E2=80=9D >> behind the removal is unclear)? >> > > Hi Enji, > > We're trying hard to get rid of all Giant-locked drivers in the tree, > either by updating or removal. Since sym(4) provides a super-set of trm(4= ) > and we have recent-ish reports of sym(4) working, it makes sense to trim > this driver from the tree. The specific cards it supports aren't all that > popular, the couple-extra features that trm(4) gave over sym(4) aren't > really that relevant today, and it's been years since trm has had good > testing and maintenance. > > > Warner, > Thanks so very much for the info :). Glad to see this effort taking place= , > since it=E2=80=99s very needed to modernize FreeBSD and improve concurren= cy in the > kernel, as well as reduce the overall maintenance burden. > Giant isn't contending, but it's getting in the way of a cleanup of the console / kbd system, as well as there being newbus issues in highly dynamic systems. With TB and USB4 support on the horizon, we need to finally clean that mess up.. I'll post a longer summary of what's left. I have a 'doodle' tree that I'm separating out the Giant usage to 'driver lock', kbd/console/ddb, newbus, sysctl, and WTF is that protecting... I'm tempted to create wtf_lock() and wtf_unlock(), but I'm not sure how well that would go over :) Warner