From nobody Wed Apr 19 23:43:13 2023 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4Q1y5v14VVz45Pvc; Wed, 19 Apr 2023 23:43:15 +0000 (UTC) (envelope-from brooks@spindle.one-eyed-alien.net) Received: from spindle.one-eyed-alien.net (spindle.one-eyed-alien.net [199.48.129.229]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 4Q1y5t6K0wz4N7v; Wed, 19 Apr 2023 23:43:14 +0000 (UTC) (envelope-from brooks@spindle.one-eyed-alien.net) Authentication-Results: mx1.freebsd.org; none Received: by spindle.one-eyed-alien.net (Postfix, from userid 3001) id D6CF43C0199; Wed, 19 Apr 2023 23:43:13 +0000 (UTC) Date: Wed, 19 Apr 2023 23:43:13 +0000 From: Brooks Davis To: Hans Petter Selasky Cc: Brooks Davis , src-committers@freebsd.org, dev-commits-src-all@freebsd.org, dev-commits-src-main@freebsd.org Subject: Re: git: a7469c9c0a50 - main - libc: bsort_s() requires both __BSD_VISIBLE and __EXT1_VISIBLE Message-ID: References: <202304192013.33JKDIrM070521@gitrepo.freebsd.org> List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-all@freebsd.org X-BeenThere: dev-commits-src-all@freebsd.org MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Rspamd-Queue-Id: 4Q1y5t6K0wz4N7v X-Spamd-Bar: ---- X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[]; ASN(0.00)[asn:36236, ipnet:199.48.128.0/22, country:US] X-Rspamd-Pre-Result: action=no action; module=replies; Message is reply to one we originated X-ThisMailContainsUnwantedMimeParts: N On Wed, Apr 19, 2023 at 11:35:56PM +0200, Hans Petter Selasky wrote: > On 4/19/23 22:29, Brooks Davis wrote: > > This is a formal request to revert all commits related to bsort. It > > should not have been committed without much broader discussion and IMO > > does not belong in the tree. It certainly should not be in the tree > > under such a generic name. > > > > -- Brooks > > Hi Brooks, > > I don't have an issue reverting my bsort() patch series, but please > clarify your statement first. Who are "we" this time, representing this > formal request for revert? This is my request. I see some review and the thread below, but adding non-standard symbols that are likely to collide with other software[0] to libc should be subject to a higher bar than a few people helping you improve your patch of saying "that's neat". New things added to libc should be in a standard or aligned with one (e.g., strlcpy, etc) and anything not from a standard should have immediate uses where it improves things in the rest of the system. Critically I don't see plans or prototype conversions and I don't see benchmarks of real systems (which could easily be done with LD_PRELOAD. > Regarding "broader discussion" - what do you mean? > > The initial discussion was started last September: > > https://lists.freebsd.org/archives/freebsd-arch/2022-September/000225.html More pushback here probably would be been good, sorry. A heads up before the actual commit might have been a good idea. I personally find your answer to the question, "why not improve qsort instead?" unsatisfactory. It might be that importing your implementation makes sense, but I don't think making is a public symbol we're stuck with forever if we ship it in 14 is a good way to go. > And several people have been asked for review and comments. Please > elaborate what "broader discussion" means? Do you mean like getting > something into ANSI first? I don't get it. I'd like more "I'd use it for X" and less "that's neat". -- Brooks [0] Debian code search finds fewer collisions than I'd feared, but not zero: https://codesearch.debian.net/search?q=%5B%5Ea-z%5Dbsort%5C%28&literal=0