From owner-freebsd-current Mon Feb 23 14:58:58 1998 Return-Path: Received: (from majordom@localhost) by hub.freebsd.org (8.8.8/8.8.8) id OAA04672 for freebsd-current-outgoing; Mon, 23 Feb 1998 14:58:58 -0800 (PST) (envelope-from owner-freebsd-current@FreeBSD.ORG) Received: from rah.star-gate.com ([209.133.7.234]) by hub.freebsd.org (8.8.8/8.8.8) with ESMTP id OAA04652 for ; Mon, 23 Feb 1998 14:58:54 -0800 (PST) (envelope-from hasty@rah.star-gate.com) Received: from rah (localhost.star-gate.com [127.0.0.1]) by rah.star-gate.com (8.8.8/8.8.8) with ESMTP id OAA00599; Mon, 23 Feb 1998 14:08:49 -0800 (PST) (envelope-from hasty@rah.star-gate.com) Message-Id: <199802232208.OAA00599@rah.star-gate.com> X-Mailer: exmh version 2.0gamma 1/27/96 To: Mike Smith cc: The Hermit Hacker , freebsd-current@FreeBSD.ORG Subject: Re: ATAPI related patch .. In-reply-to: Your message of "Mon, 23 Feb 1998 14:03:40 PST." <199802232203.OAA12585@dingo.cdrom.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Date: Mon, 23 Feb 1998 14:08:49 -0800 From: Amancio Hasty Sender: owner-freebsd-current@FreeBSD.ORG Precedence: bulk X-Loop: FreeBSD.ORG I thought that the low level scsi i/o routines did just that io with ioctls... Amancio > > > > I recently grabbed a patch that Luigi (freebsd-multimedia) has > > that is required in order to read audio tracks (using something like > > tosha) from a CD...with minor modifications, I've got it in my -current > > kernel and haven't noticed any problems. > > Thanks for the review! > > > I would like to commit the patch to the -current source tree, so > > am asking here if there are any objections to doing this. If I hear > > nothing by Wednesday (long enough?), I'll assume that it is okay and > > commit it... > > Erk. This is thoroughly grostic. You shouldn't be doing I/O using an > ioctl; this behaviour should belong on a new minor number and the raw > device read handler. > > I would vote against the inclusion of this code, unless there is an > overwhelming precedent for the technique. > > -- > \\ Sometimes you're ahead, \\ Mike Smith > \\ sometimes you're behind. \\ mike@smith.net.au > \\ The race is long, and in the \\ msmith@freebsd.org > \\ end it's only with yourself. \\ msmith@cdrom.com > > > > To Unsubscribe: send mail to majordomo@FreeBSD.org > with "unsubscribe freebsd-current" in the body of the message To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-current" in the body of the message