From owner-svn-src-all@freebsd.org Thu Dec 22 23:02:32 2016 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 49CD2C8D914; Thu, 22 Dec 2016 23:02:32 +0000 (UTC) (envelope-from cse.cem@gmail.com) Received: from mail-wj0-f175.google.com (mail-wj0-f175.google.com [209.85.210.175]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id D93F5178; Thu, 22 Dec 2016 23:02:31 +0000 (UTC) (envelope-from cse.cem@gmail.com) Received: by mail-wj0-f175.google.com with SMTP id sd9so54616403wjb.1; Thu, 22 Dec 2016 15:02:31 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:reply-to:in-reply-to:references :from:date:message-id:subject:to:cc; bh=dVnlVaTtPTPl6WwAKMmAqg+Ia5+kpbcwLAyF549M6/I=; b=ICQayQKVFkXvNHpxsOsZ7+2gW6Nimc5hoGEJCoHZp0moex31s1m9zUlhy+PFURoPph rxqiKcOttUR5ym0xWdnfD1IYZkAvIc2YTsi9pY4IIa5vXO4PpgJsf4w91FIuqor3YZH0 BSzk1YJAbKQh3kbXFlBNepBmA4m//EvbItxMKYILezf4zvM15AURA+e6mbHicwjD6aZr 7OVdmgaXKcOhsdocu7xWLPnO/avlZOU3D/yjb3DS8HK82xc2Ljges6XQtX5hP1eVWpbB 5IceE6MEzWlaVw/7rzvZT2/X0bKXelGYP0PhM3Awoj8+W0iHEmHpz9uPKG5y1JLdyGvf bzAw== X-Gm-Message-State: AIkVDXJKF7jb5jAUF4pHgUpx4TN0hUIrcW3KXT7f/Ps1h9UGEAPyEQh4umHcBSUGw2A2Hw== X-Received: by 10.194.148.134 with SMTP id ts6mr10929930wjb.220.1482446350537; Thu, 22 Dec 2016 14:39:10 -0800 (PST) Received: from mail-wj0-f173.google.com (mail-wj0-f173.google.com. [209.85.210.173]) by smtp.gmail.com with ESMTPSA id gj6sm37722117wjb.29.2016.12.22.14.39.10 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 22 Dec 2016 14:39:10 -0800 (PST) Received: by mail-wj0-f173.google.com with SMTP id c11so34304919wjx.3; Thu, 22 Dec 2016 14:39:10 -0800 (PST) X-Received: by 10.194.222.202 with SMTP id qo10mr10899228wjc.115.1482446350283; Thu, 22 Dec 2016 14:39:10 -0800 (PST) MIME-Version: 1.0 Reply-To: cem@freebsd.org Received: by 10.194.29.72 with HTTP; Thu, 22 Dec 2016 14:39:09 -0800 (PST) In-Reply-To: <201612222230.uBMMUge9075128@repo.freebsd.org> References: <201612222230.uBMMUge9075128@repo.freebsd.org> From: Conrad Meyer Date: Thu, 22 Dec 2016 14:39:09 -0800 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: svn commit: r310433 - head/lib/libc/stdio To: Ngie Cooper Cc: src-committers , svn-src-all@freebsd.org, svn-src-head@freebsd.org Content-Type: text/plain; charset=UTF-8 X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 22 Dec 2016 23:02:32 -0000 This was unjustified and inappropriate. On Thu, Dec 22, 2016 at 2:30 PM, Ngie Cooper wrote: > Author: ngie > Date: Thu Dec 22 22:30:42 2016 > New Revision: 310433 > URL: https://svnweb.freebsd.org/changeset/base/310433 > > Log: > Revert r310138 > > Adding %b support to vfprintf for parity with kernel space requires > more discussion/review. > > In particular, many parties were concerned over introducing a > non-standard format qualifier to *printf(3) which didn't already > exist in other OSes, e.g. Linux, thus making code which used %b > harder to port to other operating systems. > > Requested by: many > > Modified: > head/lib/libc/stdio/vfprintf.c > > Modified: head/lib/libc/stdio/vfprintf.c > ============================================================================== > --- head/lib/libc/stdio/vfprintf.c Thu Dec 22 21:56:41 2016 (r310432) > +++ head/lib/libc/stdio/vfprintf.c Thu Dec 22 22:30:42 2016 (r310433) > @@ -611,37 +611,6 @@ reswitch: switch (ch) { > case 'z': > flags |= SIZET; > goto rflag; > - case 'b': > - { > - const char *q; > - int anybitset, bit; > - > - ulval = (u_int)GETARG(int); > - cp = GETARG(char *); > - > - q = __ultoa(ulval, buf + BUF, *cp++, 0, xdigs_lower); > - PRINT(q, buf + BUF - q); > - > - if (ulval == 0) > - break; > - > - for (anybitset = 0; *cp;) { > - bit = *cp++; > - if (ulval & (1 << (bit - 1))) { > - PRINT(anybitset ? "," : "<", 1); > - q = cp; > - for (; (bit = *cp) > ' '; ++cp) > - continue; > - PRINT(q, cp - q); > - anybitset = 1; > - } else > - for (; *cp > ' '; ++cp) > - continue; > - } > - if (anybitset) > - PRINT(">", 1); > - } > - continue; > case 'C': > flags |= LONGINT; > /*FALLTHROUGH*/ >