From owner-svn-ports-all@FreeBSD.ORG Fri Feb 1 17:42:51 2013 Return-Path: Delivered-To: svn-ports-all@freebsd.org Received: from mx1.freebsd.org (mx1.FreeBSD.org [8.8.178.115]) by hub.freebsd.org (Postfix) with ESMTP id C60876A7; Fri, 1 Feb 2013 17:42:51 +0000 (UTC) (envelope-from utisoft@gmail.com) Received: from mail-ia0-x232.google.com (mail-ia0-x232.google.com [IPv6:2607:f8b0:4001:c02::232]) by mx1.freebsd.org (Postfix) with ESMTP id 4F852383; Fri, 1 Feb 2013 17:42:51 +0000 (UTC) Received: by mail-ia0-f178.google.com with SMTP id y26so5784315iab.9 for ; Fri, 01 Feb 2013 09:42:51 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=x-received:mime-version:in-reply-to:references:from:date:message-id :subject:to:cc:content-type; bh=qNTP+12dok1+j2lleETsLDnF2rtCwAmeieEFTVWEhb0=; b=mQZ8/r+wPxNuhIN9zyNJagrX386zJOoDxhTjLndmX1ANcde9MA9y8b6NTquytCkJWN 2uqBD+ziIlpZAYFLo152Qv5rtR9E49+/wzQliTG9epWcOwX+DLSP+sayLngf//vpPahn mtw+tNht1ZJq2cFBi98H/1fHQo+fHbbt2dg5zOz06mF1UFggtLhoW0uzHqMQ/OxoJO/R D+fACNPK1TfxfOGUVUf3yhMSLcLU2Gr6YWa4wH9PWE4bjd+ERi377WKHSztxubqG6Noc /4OGxznA/p1DycOedYgB645DE/YQ29AvyhHhJC8W1qRsTW2PvWIxNifzkZWCLW9hKxMx SDCg== X-Received: by 10.50.13.175 with SMTP id i15mr1813374igc.75.1359740570951; Fri, 01 Feb 2013 09:42:50 -0800 (PST) MIME-Version: 1.0 Received: by 10.64.16.73 with HTTP; Fri, 1 Feb 2013 09:42:19 -0800 (PST) In-Reply-To: References: <201209032233.q83MXSa2053725@svn.freebsd.org> <50453146.2080707@smeets.im> <504537D2.5050608@FreeBSD.org> <50454279.4020309@smeets.im> <50457770.4060402@FreeBSD.org> <20120904041502.GA70861@ravenloft.kiev.ua> <20120904161424.GA28248@ravenloft.kiev.ua> <50462CCA.5060306@smeets.im> <20120904164958.GB79147@charon.picobyte.net> From: Chris Rees Date: Fri, 1 Feb 2013 17:42:19 +0000 Message-ID: Subject: Re: svn commit: r303626 - head/www/xpi-firebug To: Shaun Amott Content-Type: text/plain; charset=ISO-8859-1 Cc: svn-ports-head@freebsd.org, svn-ports-all@freebsd.org, bugmeister@freebsd.org, "ports-committers@freebsd.org" X-BeenThere: svn-ports-all@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: SVN commit messages for the ports tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 01 Feb 2013 17:42:51 -0000 Hi Shaun, I've pinged a few times since you rejected my patch, and I'll paste below my email from 16/Jan that shows how patches aren't affected by an extra newline (neither are shars). I'll give you a few days to consider a response, but I have had others ask me if this is fixed yet, so it needs fixing. Chris Hi Shaun, Have you considered my response? I've just been bitten by this again... As an exercise, have a look at the response here: [crees@pegasus]~/public_html/scratch/patch-games% wrote: > On 4 September 2012 17:49, Shaun Amott wrote: >> On Tue, Sep 04, 2012 at 05:41:17PM +0100, Chris Rees wrote: >>> The bug is with query-pr.cgi it appears.... We'll never get that >>> fixed, given that gnats3 has been removed from the ports tree. I'll >>> put a patch together if clusteradm/bugmeisters were prepared to have a >>> go-- I could revive the old port skel for it. >>> >>> Any takers? Or shall this just remain unfixed? >> >> The various web scripts are not part of the GNATS distribution. Any bugs >> in query-pr.cgi are down to me. :-) > > Sorry, Florian has just pointed that out to me. > > I thought it may have been a rogue chomp; somewhere, but apparently not. > > In the meantime this will work perfectly. > > http://www.bayofrum.net/~crees/patches/query-pr-getpr.diff > > Thoughts? > > Chris