From owner-p4-projects@FreeBSD.ORG  Sun Jan 20 08:24:41 2008
Return-Path: <owner-p4-projects@FreeBSD.ORG>
Delivered-To: p4-projects@freebsd.org
Received: by hub.freebsd.org (Postfix, from userid 32767)
	id 5996C16A419; Sun, 20 Jan 2008 08:24:41 +0000 (UTC)
Delivered-To: perforce@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 06D0916A417
	for <perforce@freebsd.org>; Sun, 20 Jan 2008 08:24:41 +0000 (UTC)
	(envelope-from jb@freebsd.org)
Received: from repoman.freebsd.org (repoman.freebsd.org
	[IPv6:2001:4f8:fff6::29])
	by mx1.freebsd.org (Postfix) with ESMTP id DA74413C43E
	for <perforce@freebsd.org>; Sun, 20 Jan 2008 08:24:40 +0000 (UTC)
	(envelope-from jb@freebsd.org)
Received: from repoman.freebsd.org (localhost [127.0.0.1])
	by repoman.freebsd.org (8.14.1/8.14.1) with ESMTP id m0K8Oerl080483
	for <perforce@freebsd.org>; Sun, 20 Jan 2008 08:24:40 GMT
	(envelope-from jb@freebsd.org)
Received: (from perforce@localhost)
	by repoman.freebsd.org (8.14.1/8.14.1/Submit) id m0K8Oe9W080480
	for perforce@freebsd.org; Sun, 20 Jan 2008 08:24:40 GMT
	(envelope-from jb@freebsd.org)
Date: Sun, 20 Jan 2008 08:24:40 GMT
Message-Id: <200801200824.m0K8Oe9W080480@repoman.freebsd.org>
X-Authentication-Warning: repoman.freebsd.org: perforce set sender to
	jb@freebsd.org using -f
From: John Birrell <jb@FreeBSD.org>
To: Perforce Change Reviews <perforce@freebsd.org>
Cc: 
Subject: PERFORCE change 133719 for review
X-BeenThere: p4-projects@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: p4 projects tree changes <p4-projects.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/p4-projects>,
	<mailto:p4-projects-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/p4-projects>
List-Post: <mailto:p4-projects@freebsd.org>
List-Help: <mailto:p4-projects-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/p4-projects>,
	<mailto:p4-projects-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sun, 20 Jan 2008 08:24:41 -0000

http://perforce.freebsd.org/chv.cgi?CH=133719

Change 133719 by jb@jb_freebsd1 on 2008/01/20 08:24:18

	Add a SDT (static) probe for process creation (named: proc:kernel::create)
	to match the Solaris functionality and modify the test to account for
	the difference between FreeBSD's struct proc and Solaris.
	
	Note: This is an example of a static probe providing typed arguments.
	The argument type allows the first argument to be dereferenced in a D
	script as args[0]->p_pptr->p_pid.

Affected files ...

.. //depot/projects/dtrace/src/contrib/opensolaris/cmd/dtrace/test/tst/common/proc/tst.create.ksh#5 edit
.. //depot/projects/dtrace/src/sys/kern/kern_fork.c#25 edit

Differences ...

==== //depot/projects/dtrace/src/contrib/opensolaris/cmd/dtrace/test/tst/common/proc/tst.create.ksh#5 (text+ko) ====

@@ -36,7 +36,7 @@
 {
 	$dtrace -s /dev/stdin <<EOF
 	proc:::create
-	/args[0]->pr_ppid == $child && pid == $child/
+	/args[0]->p_pptr->p_pid == $child && pid == $child/
 	{
 		exit(0);
 	}
@@ -46,7 +46,7 @@
 sleeper()
 {
 	while true; do
-		/usr/bin/sleep 1
+		/bin/sleep 1
 	done
 }
 

==== //depot/projects/dtrace/src/sys/kern/kern_fork.c#25 (text+ko) ====

@@ -37,6 +37,7 @@
 #include <sys/cdefs.h>
 __FBSDID("$FreeBSD: src/sys/kern/kern_fork.c,v 1.289 2007/11/15 02:13:44 julian Exp $");
 
+#include "opt_kdtrace.h"
 #include "opt_ktrace.h"
 #include "opt_mac.h"
 
@@ -63,6 +64,7 @@
 #include <sys/ktr.h>
 #include <sys/ktrace.h>
 #include <sys/unistd.h>	
+#include <sys/sdt.h>
 #include <sys/sx.h>
 #include <sys/signalvar.h>
 
@@ -75,6 +77,7 @@
 #include <vm/vm_extern.h>
 #include <vm/uma.h>
 
+SDT_PROVIDER_DECLARE(proc);
 
 #ifndef _SYS_SYSPROTO_H_
 struct fork_args {
@@ -716,6 +719,11 @@
 
 	PROC_UNLOCK(p1);
 
+	SDT_PROBE(proc, kernel, , create, p2, p1, flags, 0, 0);
+	SDT_PROBE_ARGTYPE(proc, kernel, , create, 0, "struct proc *");
+	SDT_PROBE_ARGTYPE(proc, kernel, , create, 1, "struct proc *");
+	SDT_PROBE_ARGTYPE(proc, kernel, , create, 2, "int");
+
 	/*
 	 * Preserve synchronization semantics of vfork.  If waiting for
 	 * child to exec or exit, set P_PPWAIT on child, and sleep on our