From owner-freebsd-bugs  Tue Apr 15 08:30:13 1997
Return-Path: <owner-bugs>
Received: (from root@localhost)
          by freefall.freebsd.org (8.8.5/8.8.5) id IAA16094
          for bugs-outgoing; Tue, 15 Apr 1997 08:30:13 -0700 (PDT)
Received: from godzilla.zeta.org.au (godzilla.zeta.org.au [203.2.228.19])
          by freefall.freebsd.org (8.8.5/8.8.5) with ESMTP id IAA16089
          for <freebsd-bugs@freefall.freebsd.org>; Tue, 15 Apr 1997 08:30:09 -0700 (PDT)
Received: (from bde@localhost) by godzilla.zeta.org.au (8.8.5/8.6.9) id BAA02623; Wed, 16 Apr 1997 01:29:12 +1000
Date: Wed, 16 Apr 1997 01:29:12 +1000
From: Bruce Evans <bde@zeta.org.au>
Message-Id: <199704151529.BAA02623@godzilla.zeta.org.au>
To: freebsd-bugs@freefall.freebsd.org, tejblum@arc.hq.cti.ru
Subject: Re: misc/3291: md2.h, md4.h, and md5.h headers useless for c++ programms
Sender: owner-bugs@FreeBSD.ORG
X-Loop: FreeBSD.org
Precedence: bulk

> Other improvements:
> 
> 1. __P added to function prototypes (to keep consistency in FreeBSD
> includes)

We've almost decided to stop supporting K&R, but headers should be the
last place to stop supporting it.

> 2. filename parameter of MDXFile should be const char*, not char*.
> (Changes to sources and man page also included, of course).
> 
> libmd still pass test after this patch :).

My man page synopsis checker test won't pass :-).  BTW, there are bugs
in the synopsis for MD5.9.  The synopsis checker generates the following
file from the synopsis:

---
#define KERNEL 1
#include <sys/types.h>
#include <sys/md5.h>
#undef MD5Init
void
MD5Init(MD5_CTX *buf) ;
#undef MD5Transform
void
MD5Transform(u_int32_t buf[4], const unsigned char block[64]);
int pedantic_pacificer;
---

Compiling this with `cc -Wredundant-decls' shows that MD5Transform()
is not declared in <sys/md5.h>.  In fact it is not part of the public
interface, and most of the public interface is not documented.

Bruce