From owner-svn-ports-all@freebsd.org Wed Aug 8 22:18:53 2018 Return-Path: Delivered-To: svn-ports-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id A9593106D612 for ; Wed, 8 Aug 2018 22:18:53 +0000 (UTC) (envelope-from adamw@adamw.org) Received: from mail-yw1-xc44.google.com (mail-yw1-xc44.google.com [IPv6:2607:f8b0:4864:20::c44]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4476F97489 for ; Wed, 8 Aug 2018 22:18:53 +0000 (UTC) (envelope-from adamw@adamw.org) Received: by mail-yw1-xc44.google.com with SMTP id s68-v6so2796279ywg.2 for ; Wed, 08 Aug 2018 15:18:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=adamw-org.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=t8Q8UHb/46ou2pwwatdChe0BuoDSfhdYOs7izQJ+LQM=; b=0WNJ8tHV0ISfPQrksM0TY2HKJCmSKFydCzQmcl0NIFWft0AUYm2zIcY575piuNkFOd F9jgg01cvAOC8qWKh/dh32oFeRAjS49J/2Ha1TIHQzPBpxmuEeRivvV2vBPfoTfLP8/a crjMkfRP3M4zCwOwKRLWhytO9NCNx7k2qXoub56eWHBU1bAl6O9AqhSTbd+tJtI0AZYc 6EtCkkE8FxIzc1RBr9pb3O/ms3OInjfG/mAk49nyEPM1Lp3rR5UxLsuLfO8igHmt4gku 9ttSUXuZpnZrOCXNggEK0vJhkgCNtUdC9Zgz1vuBFivfuKfghzjJA6f5GNH522F9n5um 2ljQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=t8Q8UHb/46ou2pwwatdChe0BuoDSfhdYOs7izQJ+LQM=; b=pSGtSi5nkHZmP+FwVuxnHZPllpUFpetVV2JIJ8HzyXn0AFRoCKKPkaDRr4f1pUKNcl fUGYePQvNKRPLTi794c/iYZqncdaNswxNJZRCJolHaHp16ifEw6eFvGi3jgxbU4N1LWA +tvVXw8PkBQ5tDwu5n9TimfvftLvKITomUvbeDWZe3AaxBozhI3/lhjo9cLqo97Tqv8q z9QCETW/inMhAjwwtD+vZqerb88fSHa1Par9iesNKwb9+j45crLI96miKYTpaCNru4g0 68yFeKW9ZMCgEjsIAwJKUSJuRs+Ujo2XpedLhNfRY+QAXQxr3l9mbJCD8VkngE7+6EQx 09MQ== X-Gm-Message-State: AOUpUlGd1gxAnKVTW1nzfXmieNYwlCD4KVA/bHiOPhmYSAX+3Y5F3UNN Vww2/z0dKFUI/T0uX8pdKS6iF3QDDLMLfzgVB8Uw5Q== X-Google-Smtp-Source: AA+uWPxg4zKW1zEJmxyL8dXE7TOozknEkh3MZIVUpEPevtoYK38rU6BWS15OXLj+A2dX4wKtmBSaSFiBB+ccKbQq0kg= X-Received: by 2002:a0d:fd87:: with SMTP id n129-v6mr2440633ywf.439.1533766732514; Wed, 08 Aug 2018 15:18:52 -0700 (PDT) MIME-Version: 1.0 References: <201808081953.w78Jr68X078029@repo.freebsd.org> <20180808202929.GA63276@exodus.zi0r.com> <20180808213446.gktmjqcyrfhjkrlk@atuin.in.mat.cc> <20180808215702.GB52659@exodus.zi0r.com> In-Reply-To: <20180808215702.GB52659@exodus.zi0r.com> From: Adam Weinberger Date: Wed, 8 Aug 2018 16:18:36 -0600 Message-ID: Subject: Re: svn commit: r476670 - in head/devel: . rubygem-solve To: zi@freebsd.org Cc: mat@freebsd.org, ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org Content-Type: text/plain; charset="UTF-8" X-BeenThere: svn-ports-all@freebsd.org X-Mailman-Version: 2.1.27 Precedence: list List-Id: SVN commit messages for the ports tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 08 Aug 2018 22:18:53 -0000 On Wed, Aug 8, 2018 at 3:57 PM Ryan Steinmetz wrote: > > > On (08/08/18 23:34), Mathieu Arnold wrote: > >> > Ryan, > >> > > >> > You've just added a number of ports with uninformative pkg-descrs, and > >> > unhelpful COMMENT strings. These aren't merely formalities. Users > >> > should be able to read the pkg-descr and understand if it's the right > >> > package for them, and COMMENT is the first target for searches. > >> > Please, go back over them and, at the very least, expand the pkg-descr > >> > files with more information. As a general rule, pkg-descr should NEVER > >> > be the same text as the COMMENT. > >> > >> Adam, > >> > >> These are the description strings from authors of the code. They came from > >> either rubygems.org and/or the gem source repository. For example, in the > >> case of rubygem-solve: > >> > >> https://rubygems.org/gems/solve > >> > >> https://github.com/berkshelf/solve > >> > >> If you have any specific things you would like to see added to any of the > >> individual ports, please let me know. > > > >pkg-descr must contain sentences, something that can be read. It must at > >least be two lines long, so that it is descriptive enough. The fact > >that upstream is crappy does not mean you can put he same crap in the > >ports tree. It is your job as committer to make sure that ports conform > >to our policies and requirements. If upstream does not provide a better > >decription, create one, basd on your knowledge of the software. > > > https://svnweb.freebsd.org/ports/head/devel/p5-Data-Serializer-Sereal/pkg-descr?revision=401986&view=markup > > https://svnweb.freebsd.org/ports/head/net/rubygem-epp-client-afnic/pkg-descr?revision=380380&view=markup > > https://svnweb.freebsd.org/ports/head/net/rubygem-epp-client-smallregistry/pkg-descr?view=markup > > https://svnweb.freebsd.org/ports/head/net/rubygem-epp-client-secdns/pkg-descr?revision=380380&view=markup Ryan, what exactly is it that you're arguing in favour of here? All I requested was for you to please add some helpful information in the descrs where possible. So far you've argued that uninformative descrs are okay as long as you copied it from someone else, and that uninformative descrs are okay because you're not the only one who does it. I'm trying to get people on board with fixing what's been an ongoing problem in our ports. You've agreed with the problem, but not the solution. If you have another solution to terse descrs that's different from putting more information in descrs, I'm eager to hear it. # Adam -- Adam Weinberger adamw@adamw.org https://www.adamw.org