From nobody Thu Apr 16 16:15:45 2026 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4fxNR53SMqz6Zvg3 for ; Thu, 16 Apr 2026 16:15:45 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R12" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 4fxNR50pQmz3R2F for ; Thu, 16 Apr 2026 16:15:45 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1776356145; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=js8jROihnoHRbaMATUySoIcFTD3x3SKbNHglyk2LqkM=; b=Mt39ykefke5OMYUOSI3SFm6BQSs9WivrlvZgiuqRyhqwWfZMGyk9hGiISruv63AZxqKvb+ hnIsi8AQf7nMly25Snc+WmS80Aoeftu68EQp5BY8HJ8Jip9wxqQCponof8wRrwN3c1mfgJ JiHgwzmi64m/sD+YeNb9RCq4cTyLH+crTg91+oxJNj2hLu3LbJqcfWWJcOUfUPpgUTOdVQ D8a09N7LzsS6Dn0c3mM313zHm43XR4dtYYlFauijlH0KXXU0WMVGSCzJTHvuVF8OVytgmO OLyeRycm2at/aULfuTWBWBUI9+xk/WFWdjlefP/OQ98l27oyJacpP42Fjj7i8w== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1776356145; a=rsa-sha256; cv=none; b=IewTGKZ4j5sS/O0rdeWjw1Sf/etMwx4od91kBsjHs3wM1tmfUST2P4xMAXzYQmDulGu3gt 7kkMRcyfW6zxm/lMf5VvvUetAzrbs74aSXuphw3Yor3x3nLzrYGl876gTOaNC8wX4MlmxD UeIFJoIZHIj+YyGWDWbWwEBx6EuB5MmsEtRbuB851FwhJWvp9yAv80CThnUp0G65G1ukRj Miwq8C+StZeIIr/WyVN1k5hB0PDFrkpaHNasMuY0ZOU9kFyOJKm9nh8CGGa1UxDXyBlSpo sBXTQq5GgNt2YMUr20HJy8w3gHGZj7anaHMosqrTbsqmP15PQsgFXvBcigG5Zw== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1776356145; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=js8jROihnoHRbaMATUySoIcFTD3x3SKbNHglyk2LqkM=; b=Hl/bHBY+NEOBJYWUawZMnyK6hMbrjLZ9rGNv3OoVnUzoZdgs178XeCfKhA3lDTGOggfc8B 8JcGsR1CCqVycrj84aM1xB2biLxIyAbUveabyEYvUfCqP1SKbvB9g3ewNJd0Qin7GWqiF7 3K/Z+6BWP1t3ApiMf73ENQX59EyZZzVtI7BVA6esQjJ0uUDtd9YxGaD/Bkxu7rH5RadEhq 0UiRY3mx3dr2wLNRMyj9R7z+8t3P+iPz89/jz/1TsLrmL1N9gNCa2nI7Fe3Db0d4heuhjp Qpho0aQYf0JpCKch+nS3jsmDYt4MO4rTEL7i/WezJMfI13jj8K8DiPIUsjrlEw== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) by mxrelay.nyi.freebsd.org (Postfix) with ESMTP id 4fxNR506x1zYr for ; Thu, 16 Apr 2026 16:15:45 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from git (uid 1279) (envelope-from git@FreeBSD.org) id 258e2 by gitrepo.freebsd.org (DragonFly Mail Agent v0.13+ on gitrepo.freebsd.org); Thu, 16 Apr 2026 16:15:45 +0000 To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Mitchell Horne Subject: git: ce6b4973ba8c - main - raspberry_virtgpio: fix OF_hasprop() usage List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: mhorne X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: ce6b4973ba8c6503d3b6dc12d9e6b42ce274d912 Auto-Submitted: auto-generated Date: Thu, 16 Apr 2026 16:15:45 +0000 Message-Id: <69e10b31.258e2.7c6936b6@gitrepo.freebsd.org> The branch main has been updated by mhorne: URL: https://cgit.FreeBSD.org/src/commit/?id=ce6b4973ba8c6503d3b6dc12d9e6b42ce274d912 commit ce6b4973ba8c6503d3b6dc12d9e6b42ce274d912 Author: Mitchell Horne AuthorDate: 2026-04-16 16:05:25 +0000 Commit: Mitchell Horne CommitDate: 2026-04-16 16:15:41 +0000 raspberry_virtgpio: fix OF_hasprop() usage The function returns a bool. This driver was merged recently (by me) and I missed this instance. While here, adjust the ofw_bus_status_okay() call similarly. This function still returns an int, but this usage is more widely used in our drivers. No functional change intended. MFC after: 3 days Sponsored by: The FreeBSD Foundation Fixes: b60cd486a652 ("ofw: bool-ify OF_hasprop()") --- sys/arm/broadcom/bcm2835/raspberrypi_virtgpio.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/sys/arm/broadcom/bcm2835/raspberrypi_virtgpio.c b/sys/arm/broadcom/bcm2835/raspberrypi_virtgpio.c index 64ce6fda6306..797896a7f22b 100644 --- a/sys/arm/broadcom/bcm2835/raspberrypi_virtgpio.c +++ b/sys/arm/broadcom/bcm2835/raspberrypi_virtgpio.c @@ -206,14 +206,14 @@ rpi_virt_gpio_probe(device_t dev) union msg_gpiovirtbuf cfg; int rv; - if (ofw_bus_status_okay(dev) == 0) + if (!ofw_bus_status_okay(dev)) return (ENXIO); if (ofw_bus_search_compatible(dev, compat_data)->ocd_data == 0) return (ENXIO); gpio = ofw_bus_get_node(dev); - if (OF_hasprop(gpio, "gpio-controller") == 0) + if (!OF_hasprop(gpio, "gpio-controller")) return (ENXIO); /* Check whether the firmware is ready. */