Date: Mon, 12 Jan 2004 02:27:12 +0100 From: Pawel Jakub Dawidek <nick@garage.freebsd.pl> To: Robert Watson <rwatson@freebsd.org> Cc: phk@freebsd.org Subject: Re: MD(4) cleanups and unload lesson. Message-ID: <20040112012711.GC74246@garage.freebsd.pl> In-Reply-To: <Pine.NEB.3.96L.1040111124747.91469c-100000@fledge.watson.org> References: <20040111155842.GB74246@garage.freebsd.pl> <Pine.NEB.3.96L.1040111124747.91469c-100000@fledge.watson.org>
next in thread | previous in thread | raw e-mail | index | archive | help
[-- Attachment #1 --] On Sun, Jan 11, 2004 at 12:48:56PM -0500, Robert Watson wrote: +> On Sun, 11 Jan 2004, Pawel Jakub Dawidek wrote: +> > With attached patch unloading md(4) module is possible. It also cleans +> > up big part of code according to style(9). +> +> Could you separate this into a functional diff and a style diff? There's +> a general preference to not combine them, as it means cvs diff between +> revisions isn't useful for identifying functional changes (i.e., reviewing +> for bugs when back-tracking, etc). Sure functional-only change is now here: http://garage.freebsd.pl/patches/md.c.patch and old patch is here: http://garage.freebsd.pl/patches/md.c.2.patch I haven't prepare style patch, because I wasn't sure against which version of md.c it should be (original or with functional change). -- Pawel Jakub Dawidek pawel@dawidek.net UNIX Systems Programmer/Administrator http://garage.freebsd.pl Am I Evil? Yes, I Am! http://cerber.sourceforge.net [-- Attachment #2 --] -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.0.7 (FreeBSD) iQCVAwUBQAH37z/PhmMH/Mf1AQG/wwQAoLoPtIBY/nD7qWc7HJq3lX2jEK9HsOrK TbjoRQHuNVoDiSUmgQKi0rtrXsUczFax47+A5/yb02cnSHvghRA6TLw6dQ9a200W hat4bvU9GFRIDAO2h1YRxW6sITZR6q8cW0tcKCAYEQXVc+OxXnHct0jpn1DwsBjx OKVlXKLnR3c= =t0wy -----END PGP SIGNATURE-----
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20040112012711.GC74246>