From owner-freebsd-hackers@FreeBSD.ORG  Sun Jan 11 17:26:44 2004
Return-Path: <owner-freebsd-hackers@FreeBSD.ORG>
Delivered-To: freebsd-hackers@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP
	id ADF0516A4CE; Sun, 11 Jan 2004 17:26:44 -0800 (PST)
Received: from milla.ask33.net (milla.ask33.net [217.197.166.60])
	by mx1.FreeBSD.org (Postfix) with ESMTP
	id C566F43D55; Sun, 11 Jan 2004 17:26:41 -0800 (PST)
	(envelope-from nick@milla.ask33.net)
Received: by milla.ask33.net (Postfix, from userid 1001)
	id 31C4C3ABB51; Mon, 12 Jan 2004 02:27:12 +0100 (CET)
Date: Mon, 12 Jan 2004 02:27:12 +0100
From: Pawel Jakub Dawidek <nick@garage.freebsd.pl>
To: Robert Watson <rwatson@freebsd.org>
Message-ID: <20040112012711.GC74246@garage.freebsd.pl>
References: <20040111155842.GB74246@garage.freebsd.pl>
	<Pine.NEB.3.96L.1040111124747.91469c-100000@fledge.watson.org>
Mime-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-md5;
	protocol="application/pgp-signature"; boundary="+JUInw4efm7IfTNU"
Content-Disposition: inline
In-Reply-To: <Pine.NEB.3.96L.1040111124747.91469c-100000@fledge.watson.org>
X-PGP-Key-URL: http://garage.freebsd.pl/jules.asc
X-OS: FreeBSD 4.8-RELEASE-p13 i386
X-URL: http://garage.freebsd.pl
User-Agent: Mutt/1.5.1i
cc: freebsd-hackers@freebsd.org
cc: phk@freebsd.org
Subject: Re: MD(4) cleanups and unload lesson.
X-BeenThere: freebsd-hackers@freebsd.org
X-Mailman-Version: 2.1.1
Precedence: list
List-Id: Technical Discussions relating to FreeBSD
	<freebsd-hackers.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-hackers>,
	<mailto:freebsd-hackers-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-hackers>
List-Post: <mailto:freebsd-hackers@freebsd.org>
List-Help: <mailto:freebsd-hackers-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-hackers>,
	<mailto:freebsd-hackers-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Mon, 12 Jan 2004 01:26:44 -0000


--+JUInw4efm7IfTNU
Content-Type: text/plain; charset=iso-8859-2
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Sun, Jan 11, 2004 at 12:48:56PM -0500, Robert Watson wrote:
+> On Sun, 11 Jan 2004, Pawel Jakub Dawidek wrote:
+> > With attached patch unloading md(4) module is possible.  It also cleans
+> > up big part of code according to style(9).=20
+>=20
+> Could you separate this into a functional diff and a style diff?  There's
+> a general preference to not combine them, as it means cvs diff between
+> revisions isn't useful for identifying functional changes (i.e., reviewi=
ng
+> for bugs when back-tracking, etc).=20

Sure functional-only change is now here:

	http://garage.freebsd.pl/patches/md.c.patch

and old patch is here:

	http://garage.freebsd.pl/patches/md.c.2.patch

I haven't prepare style patch, because I wasn't sure against which version
of md.c it should be (original or with functional change).

--=20
Pawel Jakub Dawidek                       pawel@dawidek.net
UNIX Systems Programmer/Administrator     http://garage.freebsd.pl
Am I Evil? Yes, I Am!                     http://cerber.sourceforge.net

--+JUInw4efm7IfTNU
Content-Type: application/pgp-signature
Content-Disposition: inline

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.0.7 (FreeBSD)

iQCVAwUBQAH37z/PhmMH/Mf1AQG/wwQAoLoPtIBY/nD7qWc7HJq3lX2jEK9HsOrK
TbjoRQHuNVoDiSUmgQKi0rtrXsUczFax47+A5/yb02cnSHvghRA6TLw6dQ9a200W
hat4bvU9GFRIDAO2h1YRxW6sITZR6q8cW0tcKCAYEQXVc+OxXnHct0jpn1DwsBjx
OKVlXKLnR3c=
=t0wy
-----END PGP SIGNATURE-----

--+JUInw4efm7IfTNU--