From owner-cvs-all@FreeBSD.ORG Thu Nov 20 15:42:02 2003 Return-Path: Delivered-To: cvs-all@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 0E77C16A4CE for ; Thu, 20 Nov 2003 15:42:02 -0800 (PST) Received: from rootlabs.com (root.org [67.118.192.226]) by mx1.FreeBSD.org (Postfix) with SMTP id 5CB3743FDD for ; Thu, 20 Nov 2003 15:41:03 -0800 (PST) (envelope-from nate@rootlabs.com) Received: (qmail 72789 invoked by uid 1000); 20 Nov 2003 23:40:58 -0000 Date: Thu, 20 Nov 2003 15:40:58 -0800 (PST) From: Nate Lawson To: John Baldwin In-Reply-To: Message-ID: <20031120153849.H72721@root.org> References: MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII cc: cvs-src@FreeBSD.org cc: src-committers@FreeBSD.org cc: cvs-all@FreeBSD.org Subject: RE: cvs commit: src/sys/dev/acpica acpi.c acpi_cpu.c X-BeenThere: cvs-all@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the entire tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 20 Nov 2003 23:42:03 -0000 On Thu, 20 Nov 2003, John Baldwin wrote: > On 20-Nov-2003 Nate Lawson wrote: > > On Wed, 19 Nov 2003, John Baldwin wrote: > >> One minor suggestion btw. Could you fix the hw.acpi.cpu.cpu_cx_lowest > >> to use the "C1", "C2", and "C3" strings for its user-visible interface > >> instead of the direct integer? Setting the value to C2 is a bit more > >> intuitive than setting it to 1 to get C2. > > > > I considered this before, however Cx is really a type, not a given state. > > There can be more than 3 sleep states. For instance, the IBM R40 has C1, > > C2, C3, and C3 (4 states). An index was the only unique way I could > > specify the states. The transition latency is also unique but setting a > > state to 182 to get the last C3 state is even worse from a user > > perspective. > > Ah. Maybe rename the sysctl/tunable to indicate that it is an index? No good ideas over here. Took me a while to even come up with hw.acpi.cpu.cx_lowest. You want to indicate higher states will be also used as determined by the scheduling algorithm and that states with higher indices provide more power savings but also more latency. cx_lowest_idx seems kinda lame. Suggestions? -Nate