From owner-svn-src-all@freebsd.org Wed Mar 14 23:06:12 2018 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id F1732F5081F; Wed, 14 Mar 2018 23:06:11 +0000 (UTC) (envelope-from asomers@gmail.com) Received: from mail-lf0-x22e.google.com (mail-lf0-x22e.google.com [IPv6:2a00:1450:4010:c07::22e]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 2EB3F7C1C9; Wed, 14 Mar 2018 23:06:11 +0000 (UTC) (envelope-from asomers@gmail.com) Received: by mail-lf0-x22e.google.com with SMTP id e5-v6so3265231lfb.7; Wed, 14 Mar 2018 16:06:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:sender:in-reply-to:references:from:date:message-id :subject:to:cc; bh=/O+oTxbLJSd6GeRVzUN2D+eWPQ42ca6YHX/RIKzqKNE=; b=HggjDVi0+HpavgRURRvTicVx4QQw0RIRXfd6nchag2Z81FJKaQDwxK84AWdwCemqK+ CZfzzKm7f38kl+sTugHS/dzgQBeqF5bssgeKERPeCIhyP0CeYLKu8kDFfoweTexspBOF EoTKHkfINVrIT5YEUHjIac13hjPGyj7eBpNz1s9n7wFRNQWVRzJW/wq6asSdp9dBbTOu DcHncVRPgpZQZyABhC/5ocQEKX71L37ghNdFniUcwSkt7QgWFiDagCh/MTYkw86sb6Zw GAs+P4WSuMkOFjhfgqZB0Rclyrvn/FubnLKXa6Fg7UxWsWgER5lgJ/Jg6hUoU9sudGVe ReuA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:sender:in-reply-to:references:from :date:message-id:subject:to:cc; bh=/O+oTxbLJSd6GeRVzUN2D+eWPQ42ca6YHX/RIKzqKNE=; b=SNx33tuzLc//SldClF4t5SxDj53dLF3JCmj2NdzZB5GkmrJV9H9oqVA5SJmXfiJ8a4 4AMN5Gr+0joib263CeEuEd9HuGVQH5SMOHunyKpKNiIBco4a3tr7sn+vg6de/LqzVL62 HYv1Z7ZQ8pGSv/bwn6cE3cQTVzhgL8OpFaJgctEn2yZcsSphRs304cs7Ggb1ejv5BUZK P/ZJQDDvWudDDJhj+1JDLUSm4FUK0Zk5XQSyXgC++pmuSi9bQIBiCIRwXMiYoIFDGLJX KEaIN8r8TDymVP735TFBZtUwXdTuPtJ4CngnW+acwPU/AQs7iFuNugVkF755YriY4LPg s22Q== X-Gm-Message-State: AElRT7GxsaNKixht7cqU39VGc1Hcg1EchHrAFrif2GTFigbJ4GDZNo3T /YKn091WZx5BZdjlbDIIjQP6w/vquI9DDsrPzcE= X-Google-Smtp-Source: AG47ELt6CAWWIyGyOvz9lk1/9ODj0faDuWpRngjt98dZ9TOrgSisii9velI0M2pTN17CYI6ThEgK73LwbGRVBllnnYs= X-Received: by 10.46.157.135 with SMTP id c7mr2838949ljj.46.1521068769714; Wed, 14 Mar 2018 16:06:09 -0700 (PDT) MIME-Version: 1.0 Sender: asomers@gmail.com Received: by 10.179.2.195 with HTTP; Wed, 14 Mar 2018 16:06:09 -0700 (PDT) In-Reply-To: <20180314225623.zp6ufw5h7bua4etf@mutt-hbsd> References: <201802251429.w1PEThjY035303@repo.freebsd.org> <20180314225009.gu3awgryggsxqmff@mutt-hbsd> <20180314225623.zp6ufw5h7bua4etf@mutt-hbsd> From: Alan Somers Date: Wed, 14 Mar 2018 17:06:09 -0600 X-Google-Sender-Auth: mtzKjN0uTjC4Hg8b-LMUpzx65so Message-ID: Subject: Re: svn commit: r329984 - in head: cddl/contrib/opensolaris/lib/libzpool/common sys/cddl/compat/opensolaris/sys To: Shawn Webb Cc: src-committers , svn-src-all@freebsd.org, svn-src-head@freebsd.org Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.25 X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.25 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 14 Mar 2018 23:06:12 -0000 On Wed, Mar 14, 2018 at 4:56 PM, Shawn Webb wrote: > On Wed, Mar 14, 2018 at 04:51:27PM -0600, Alan Somers wrote: > > On Wed, Mar 14, 2018 at 4:50 PM, Shawn Webb > > wrote: > > > > > On Sun, Feb 25, 2018 at 02:29:43PM +0000, Alan Somers wrote: > > > > Author: asomers > > > > Date: Sun Feb 25 14:29:43 2018 > > > > New Revision: 329984 > > > > URL: https://svnweb.freebsd.org/changeset/base/329984 > > > > > > > > Log: > > > > Don't declare __assfail as static > > > > > > > > It gets called by dmu_buf_init_user, which is inline but not > static. > > > So it > > > > needs global linkage itself. > > > > > > > > Reported by: GCC-6 > > > > MFC after: 17 days > > > > X-MFC-With: 329722 > > > > > > > > > > Hey Alan, > > > > > > This commit breaks compiling world with ASAN. > > > > > > Some applications, like zfs, will fail with this error: > > > > > > /lib/libuutil.so.2: Undefined symbol "__assfail" > > > > > > Thanks, > > > > > > > How does one build world with ASAN ? > > HardenedBSD has a feature branch in its playground repo for ASAN-ified > world. > > We introduced two new MK_* toggles: MK_ASAN and MK_ASAN_RECOVER. > MK_ASAN is self-explanitory. MK_ASAN_RECOVER tells the sanitizer > framework to let the application continue running instead of abort > execution. > > Here's where the magic gets set: > > https://github.com/HardenedBSD/hardenedBSD-playground/blob/hardened/ > current/asan/share/mk/bsd.prog.mk#L125-L134 > > Thanks, > I don't use HardenedBSD. Can you provide an invocation that will demonstrate the breakage on FreeBSD head? I tried a few things, and they all either worked, or failed with errors other than the one you showed.