Skip site navigation (1)Skip section navigation (2)
Date:      Fri, 26 Oct 2012 21:16:08 -0700
From:      Rui Paulo <rpaulo@felyko.com>
To:        Adrian Chadd <adrian@freebsd.org>
Cc:        svn-src-head@freebsd.org, svn-src-all@freebsd.org, Gleb Smirnoff <glebius@freebsd.org>, src-committers@freebsd.org
Subject:   Re: svn commit: r241610 - in head: . sys/dev/usb sys/net sys/net80211 sys/netpfil/ipfw sys/netpfil/pf sys/sys
Message-ID:  <A83B91C3-5A7C-4B6A-A0D8-A8EE9E6ADA64@felyko.com>
In-Reply-To: <CAJ-Vmon8BxdbTUsOXF7kCOqO3=GuKXaHFqOqGHoGgmGV2=%2B6aw@mail.gmail.com>
References:  <201210161337.q9GDbtr8049924@svn.freebsd.org> <CAJ-Vmon8BxdbTUsOXF7kCOqO3=GuKXaHFqOqGHoGgmGV2=%2B6aw@mail.gmail.com>

next in thread | previous in thread | raw e-mail | index | archive | help
I second Adrian's comments and I would like to add that you must NOT =
commit something like this, breaking the ABI, when you discussed this =
*ONE YEAR* ago with only two people (one of them is not very active in =
the networking stack). This is against all reasonable software =
development practices.

On 26 Oct 2012, at 10:00, Adrian Chadd <adrian@freebsd.org> wrote:

> So with this change, you've broken building -HEAD net80211 on -9.
>=20
> Can we please sit down and make this work on both freebsd-9 and
> freebsd-head? I do a lot of wifi development on -9 with -HEAD wireless
> and this change broke everything for me.
>=20
> You could've at least asked the maintainers first before you did this.
>=20
> Thanks,
>=20
>=20
> Adrian
>=20
> On 16 October 2012 06:37, Gleb Smirnoff <glebius@freebsd.org> wrote:
>> Author: glebius
>> Date: Tue Oct 16 13:37:54 2012
>> New Revision: 241610
>> URL: http://svn.freebsd.org/changeset/base/241610
>>=20
>> Log:
>>  Make the "struct if_clone" opaque to users of the cloning API. Users
>>  now use function calls:
>>=20
>>    if_clone_simple()
>>    if_clone_advanced()
>>=20
>>  to initialize a cloner, instead of macros that initialize if_clone
>>  structure.
>>=20
>>  Discussed with:               brooks, bz, 1 year ago



Regards,
--
Rui Paulo




Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?A83B91C3-5A7C-4B6A-A0D8-A8EE9E6ADA64>