From owner-svn-src-head@FreeBSD.ORG Sat Oct 27 04:16:20 2012 Return-Path: Delivered-To: svn-src-head@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 150FA14C; Sat, 27 Oct 2012 04:16:20 +0000 (UTC) (envelope-from rpaulo@felyko.com) Received: from felyko.com (unknown [IPv6:2607:f2f8:a528::3:1337:ca7]) by mx1.freebsd.org (Postfix) with ESMTP id D0CC78FC1A; Sat, 27 Oct 2012 04:16:19 +0000 (UTC) Received: from [IPv6:2601:9:4d00:85:1117:1a26:2e86:b9a5] (unknown [IPv6:2601:9:4d00:85:1117:1a26:2e86:b9a5]) (using TLSv1 with cipher AES128-SHA (128/128 bits)) (No client certificate requested) by felyko.com (Postfix) with ESMTPSA id C15E63981E; Fri, 26 Oct 2012 21:16:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=felyko.com; s=mail; t=1351311373; bh=5Mfdqybi+aPMTiymY72dsob0frWIhz3/Z6UI8IENNSA=; h=Subject:From:In-Reply-To:Date:Cc:References:To; b=BdvPiYHBn8uJqDB0xI6YqAz+icHGhNfBVVJXJx9+A+A1GVUGkpTdmbvcZ4m/i/9mM 9aL1eBncwb/ZGuuA+mosCw+QNnNPrqoM7FwmBpt1g7+Gt85gRfUnHJ0LZ+PIRI/G6c mNDsXBTHZOSEXQl38Q4PojByhamfR/9sqSgkEcek= Content-Type: text/plain; charset=iso-8859-1 Mime-Version: 1.0 (Mac OS X Mail 6.2 \(1499\)) Subject: Re: svn commit: r241610 - in head: . sys/dev/usb sys/net sys/net80211 sys/netpfil/ipfw sys/netpfil/pf sys/sys From: Rui Paulo In-Reply-To: Date: Fri, 26 Oct 2012 21:16:08 -0700 Content-Transfer-Encoding: quoted-printable Message-Id: References: <201210161337.q9GDbtr8049924@svn.freebsd.org> To: Adrian Chadd X-Mailer: Apple Mail (2.1499) Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, Gleb Smirnoff , src-committers@freebsd.org X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 27 Oct 2012 04:16:20 -0000 I second Adrian's comments and I would like to add that you must NOT = commit something like this, breaking the ABI, when you discussed this = *ONE YEAR* ago with only two people (one of them is not very active in = the networking stack). This is against all reasonable software = development practices. On 26 Oct 2012, at 10:00, Adrian Chadd wrote: > So with this change, you've broken building -HEAD net80211 on -9. >=20 > Can we please sit down and make this work on both freebsd-9 and > freebsd-head? I do a lot of wifi development on -9 with -HEAD wireless > and this change broke everything for me. >=20 > You could've at least asked the maintainers first before you did this. >=20 > Thanks, >=20 >=20 > Adrian >=20 > On 16 October 2012 06:37, Gleb Smirnoff wrote: >> Author: glebius >> Date: Tue Oct 16 13:37:54 2012 >> New Revision: 241610 >> URL: http://svn.freebsd.org/changeset/base/241610 >>=20 >> Log: >> Make the "struct if_clone" opaque to users of the cloning API. Users >> now use function calls: >>=20 >> if_clone_simple() >> if_clone_advanced() >>=20 >> to initialize a cloner, instead of macros that initialize if_clone >> structure. >>=20 >> Discussed with: brooks, bz, 1 year ago Regards, -- Rui Paulo