From owner-cvs-all Sun Jul 16 15:48:57 2000 Delivered-To: cvs-all@freebsd.org Received: from earth.backplane.com (backplane-inc.SanFranciscosfd.cw.net [206.24.214.242]) by hub.freebsd.org (Postfix) with ESMTP id 04A4A37B6E3; Sun, 16 Jul 2000 15:48:55 -0700 (PDT) (envelope-from dillon@earth.backplane.com) Received: (from dillon@localhost) by earth.backplane.com (8.9.3/8.9.3) id PAA09181; Sun, 16 Jul 2000 15:48:53 -0700 (PDT) (envelope-from dillon) Date: Sun, 16 Jul 2000 15:48:53 -0700 (PDT) From: Matt Dillon Message-Id: <200007162248.PAA09181@earth.backplane.com> To: "Jordan K. Hubbard" Cc: Peter Wemm , cvs-committers@FreeBSD.ORG, cvs-all@FreeBSD.ORG Subject: Re: cvs commit: src/usr.sbin/usbd usbd.c References: <2076.963534850@localhost> Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk X-Loop: FreeBSD.ORG :> Correct an additional off-by-one bug and buffer overflow. A malloc() :> was being made one byte too short, and the string assembled in it was not :> null terminated. The string was passed to regcomp() so it never matched :> anything in /etc/usbd.conf. This is the cause of usbd not working for the :> last few days.. The new malloc.conf default of AJ triggered this. : :Oh god, did you have to say that? Now phk will be INSUFFERABLE for :weeks. :-) : :- Jordan AJ ? Guys, 'J' as a default to malloc.conf is a disaster for performance. There are many programs which allocate large buffers and only use small portions of them. We *CANNOT* ship with 'J' as a default for malloc. 'A', ok. 'AH' is even better. 'AJ'? no way. -Matt To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message