From owner-svn-src-all@freebsd.org Fri Mar 15 16:22:18 2019 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id C8B2B15256E6; Fri, 15 Mar 2019 16:22:17 +0000 (UTC) (envelope-from araujobsdport@gmail.com) Received: from mail-lj1-x22e.google.com (mail-lj1-x22e.google.com [IPv6:2a00:1450:4864:20::22e]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "GTS CA 1O1" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 316066F2D4; Fri, 15 Mar 2019 16:22:17 +0000 (UTC) (envelope-from araujobsdport@gmail.com) Received: by mail-lj1-x22e.google.com with SMTP id t13so8475286lji.2; Fri, 15 Mar 2019 09:22:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:reply-to:from:date:message-id :subject:to:cc; bh=XcBp6JSc8/2lU4nydGaGcJMgBUSBtKKLN0b1y0ndYIA=; b=jCZE3mBV6V90HAGpVdRwe8GOsHCe+MLgXpgra1psovbqMcC0BV0wAwvLI1IujdHW5P sjj7ZPtbIyPhg964tj0fICRvl1+jIc/j32kST0mihoLFqqcdh1byd/nhfmdypu2P4a8Y lVjwr8hWfS0zPKsVK/Aqvl0iY0dLCei4+8JzjpvBQNLPBRvfvmDuljm4gZwv7QwbV/yu PYHgK05ZKvzKdpytYb4GY+UFhQFErxxTtFHTHLr3Mv1k80C4DIbyIfC9WUx8Lgl8Z2yy nI8wflhyny7i9FGX4Fo5y9mvl/0oM9Th099LpznDjguFoD3H8nZW7g9+gkWx68FCsXCL 0zWg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:reply-to :from:date:message-id:subject:to:cc; bh=XcBp6JSc8/2lU4nydGaGcJMgBUSBtKKLN0b1y0ndYIA=; b=RCvUDdLG3617D4/f8U+GUcTJCnMctuvuZtluygtmqvjwKOWbfG9xqLjLB1i0eHngDu 28NJJ4SOchrgsYStKCKCvlVweHNIlW58C82w7EZEqRHpJQmxWTjMOEPctGVgodKsVBCX S6A6xpxyB/GGspYY0cxXD4e/on+EmA2dJzlF/ZGIJULQTARKe7MavtUvFMMiZqr69/+/ J4w4gUSyXYXYAMw/29fWitMKkfDcHsEbB6E2qG6IjpzyXh+CYZOAQY05rX6dJ2ZTgXfR lxHRl4hDttRaMbTa+zsYcxOdV0MxqGvxkjUHm4g5hydIiVKgZNkmDM2RSzQ6hG3RuFac nrbw== X-Gm-Message-State: APjAAAXee+syMnrqRn3x1YCjIjSlQjE6nRDxg0yCRCR990+LjBxA4uxq Szz9M9+yhh/ow/I3iYln335YQwXTxXzogUU7faeslUne X-Google-Smtp-Source: APXvYqxFpvukWHP81xLNpUpzZvUST4R5E0kA66cTJpNZujCtNPJ58+1iv2+TH0yOuU9XNlFXYRclpr08MOOyEBSU1oM= X-Received: by 2002:a2e:2c0d:: with SMTP id s13mr2843670ljs.96.1552666935322; Fri, 15 Mar 2019 09:22:15 -0700 (PDT) MIME-Version: 1.0 References: <201903151603.x2FG3pIp030819@gndrsh.dnsmgr.net> In-Reply-To: <201903151603.x2FG3pIp030819@gndrsh.dnsmgr.net> Reply-To: araujo@freebsd.org From: Marcelo Araujo Date: Sat, 16 Mar 2019 00:22:01 +0800 Message-ID: Subject: Re: svn commit: r345171 - head/usr.sbin/bhyve To: "Rodney W. Grimes" Cc: Marcelo Araujo , Ian Lepore , Chuck Tuffli , src-committers , svn-src-all , svn-src-head X-Rspamd-Queue-Id: 316066F2D4 X-Spamd-Bar: ------ Authentication-Results: mx1.freebsd.org X-Spamd-Result: default: False [-6.88 / 15.00]; NEURAL_HAM_MEDIUM(-1.00)[-0.999,0]; NEURAL_HAM_SHORT(-0.88)[-0.879,0]; REPLY(-4.00)[]; NEURAL_HAM_LONG(-1.00)[-1.000,0] Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Content-Filtered-By: Mailman/MimeDel 2.1.29 X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 15 Mar 2019 16:22:18 -0000 Em s=C3=A1b, 16 de mar de 2019 =C3=A0s 00:03, Rodney W. Grimes < freebsd@gndrsh.dnsmgr.net> escreveu: > > Em sex, 15 de mar de 2019 ?s 22:12, Ian Lepore > escreveu: > > > > > On Thu, 2019-03-14 at 19:31 -0700, Rodney W. Grimes wrote: > > > > > Author: chuck > > > > > Date: Fri Mar 15 02:11:28 2019 > > > > > New Revision: 345171 > > > > > URL: https://svnweb.freebsd.org/changeset/base/345171 > > > > > > > > > > Log: > > > > > Fix bhyve PCIe capability emulation > > > > > > > > > > PCIe devices starting with version 1.1 must set the Role-Based > > > > > Error > > > > > Reporting bit. > > > > > > > > > > And while we're in the neighborhood, generalize the code > > > > > assigning the > > > > > device type. > > > > > > > > > > Reviewed by: imp, araujo, rgrimes > > > > > Approved by: imp (mentor) > > > > > MFC after: 1 week > > > > > Differential Revision: https://reviews.freebsd.org/D19580 > > > > > > > > This code requires maintainer approval before a commit, > > > > though this was well reviewed that doesnt exclude it > > > > from the MAINTAINERS entry. > > > > > > > > > > Where exactly does it say that in MAINTAINERS? As another victim of > > > this sort of drive-by lynching after making a trivial bhyve change I > > > pretty seriously object to a vague and meaningless entry in MAINTAINE= RS > > > being used to pounce on anyone who dares to touch the precious bhyve > > > code. > > > > > > > There is a new entry on MAINTAINERS: > > https://svnweb.freebsd.org/base?view=3Drevision&revision=3D344631 > > > > > > > > > > There is no mention of bhyve in MAINTAINERS, for usr.sbin or elsewher= e. > > > There is an entry for vmm(4), which to me does not say anything about > > > bhyve, yet somehow everybody is supposed to know what it means and > > > what-all territory it covers? > > > > > > IMO, this sort of hyper-proprietary pouncing on everyone who dares > > > change a single line of code is not productive. It is HIGHLY de- > > > motivating. Large sweeping design changes are one thing, but pouncin= g > > > on every tiny minor commit is just not helpful. > > > > > > > +1 > > > > I got so frustrated with it recently that I have decided to don't > > contribute with bhyve anymore, perhaps even with FreeBSD. > > I still have some people under mentorship that I intend to finish and > then > > probably I will phase out. > > Your failure to get reviews, and infact even abandon one that had > negative advice as to the validity of your suggested change and > committing it anyway is more likely the cause here. > > You also committed code with no review at all that had to be reverted > after the bugs it caused were found by an external down stream consumers > of the bhyve code. > > You had code reverted by core due to a external attribution request, > which had you been attending the bi monthly bhyve calls you would of > known was an issue. > > I would suggest these are the reasons your feeling angry, and that > I infact tried to reach out to jhb to discuss some of these earlier > but that reach out was never returned. I under stand your frustration, > you are just wanting to do with best thing you can for the project > and bhyve, can we try to find a better resolution to this situation > than your exit? > > > > > -- Ian > > > > > > > Leave it for now, I am sure jhb or thyco are fine with it, > > > > this is just a heads up FYI for future commits. > > > > > > > > Bhyve code has been and still is under a fairly tight > > > > MAINTAINER status. > > > > > > > > > Modified: > > > > > head/usr.sbin/bhyve/pci_emul.c > > > > > > > > > > Modified: head/usr.sbin/bhyve/pci_emul.c > > > > > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D > > > > > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D > > > > > --- head/usr.sbin/bhyve/pci_emul.c Fri Mar 15 02:11:27 2019 > (r3 > > > > > 45170) > > > > > +++ head/usr.sbin/bhyve/pci_emul.c Fri Mar 15 02:11:28 2019 > (r3 > > > > > 45171) > > > > > @@ -953,7 +953,10 @@ pci_emul_add_pciecap(struct pci_devinst *pi, > > > > > int type) > > > > > bzero(&pciecap, sizeof(pciecap)); > > > > > > > > > > pciecap.capid =3D PCIY_EXPRESS; > > > > > - pciecap.pcie_capabilities =3D PCIECAP_VERSION | > > > > > PCIEM_TYPE_ROOT_PORT; > > > > > + pciecap.pcie_capabilities =3D PCIECAP_VERSION | type; > > > > > + /* Devices starting with version 1.1 must set the RBER bit */ > > > > > + if (PCIECAP_VERSION >=3D 1) > > > > > + pciecap.dev_capabilities =3D PCIEM_CAP_ROLE_ERR_RPT; > > > > > pciecap.link_capabilities =3D 0x411; /* gen1, x1 */ > > > > > pciecap.link_status =3D 0x11; /* gen1, x1 */ > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > -- > > > > -- > > Marcelo Araujo (__)araujo@FreeBSD.org > > \\\'',)http://www.FreeBSD.org \/ \ ^ > > Power To Server. .\. /_) > > -- > Rod Grimes > rgrimes@freebsd.org > Sorry Rod, I don't want to be rude, but even though I'm not a native English speaker, it hurts my eyes seeing the misspellings in your emails. And I have spent enough time in public and private trying to talk with you, I don't have this time anymore. So, I truly believe you should get the maintainership of bhyve as it seems you are the most capable person to do so. Wait, your previous mentor... well, I won't repeat his words! Good lucky with bhyve, as a suggestion, one feature that at least myself need is the capability to parse a configuration file and boot a guest vm. That would be amazing! Another feature that I want and I think the most important is: let people get involved and evolve bhyve code. Best, --=20 --=20 Marcelo Araujo (__)araujo@FreeBSD.org \\\'',)http://www.FreeBSD.org \/ \ ^ Power To Server. .\. /_)