From owner-freebsd-geom@FreeBSD.ORG  Fri Mar 26 03:40:52 2004
Return-Path: <owner-freebsd-geom@FreeBSD.ORG>
Delivered-To: freebsd-geom@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP
	id 5191116A4CE; Fri, 26 Mar 2004 03:40:52 -0800 (PST)
Received: from critter.freebsd.dk (critter.freebsd.dk [212.242.86.163])
	by mx1.FreeBSD.org (Postfix) with ESMTP
	id 9919943D2F; Fri, 26 Mar 2004 03:40:51 -0800 (PST)
	(envelope-from phk@phk.freebsd.dk)
Received: from critter.freebsd.dk (localhost [127.0.0.1])
	by critter.freebsd.dk (8.12.11/8.12.11) with ESMTP id i2QBeoDa002094;
	Fri, 26 Mar 2004 12:40:50 +0100 (CET)
	(envelope-from phk@phk.freebsd.dk)
To: Pawel Jakub Dawidek <pjd@FreeBSD.org>
From: "Poul-Henning Kamp" <phk@phk.freebsd.dk>
In-Reply-To: Your message of "Fri, 26 Mar 2004 12:35:27 +0100."
             <20040326113527.GF8930@darkness.comp.waw.pl> 
Date: Fri, 26 Mar 2004 12:40:50 +0100
Message-ID: <2093.1080301250@critter.freebsd.dk>
cc: geom@FreeBSD.org
cc: Lukas Ertl <le@FreeBSD.org>
Subject: Re: Problem with g_unload_class() 
X-BeenThere: freebsd-geom@freebsd.org
X-Mailman-Version: 2.1.1
Precedence: list
List-Id: GEOM-specific discussions and implementations
	<freebsd-geom.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-geom>,
	<mailto:freebsd-geom-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-geom>
List-Post: <mailto:freebsd-geom@freebsd.org>
List-Help: <mailto:freebsd-geom-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-geom>,
	<mailto:freebsd-geom-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Fri, 26 Mar 2004 11:40:52 -0000

In message <20040326113527.GF8930@darkness.comp.waw.pl>, Pawel Jakub Dawidek wr
ites:

>BTW. Why can't we nuke config and taste here:
>
>	if (error =3D=3D 0) {
>		mp->taste =3D NULL;
>		mp->config =3D NULL;
>		if (mp->fini !=3D NULL)
>			mp->fini(mp);
>		LIST_REMOVE(mp, class);
>	}
>
>Those events are called from the event queue, aren't they?
>So this should be safe.

That would force config to be only called from the event queue,
that is a hefty price to pay.

But a two pass is still necessary so we don't destroy half
of the geoms and not the other half.


-- 
Poul-Henning Kamp       | UNIX since Zilog Zeus 3.20
phk@FreeBSD.ORG         | TCP/IP since RFC 956
FreeBSD committer       | BSD since 4.3-tahoe    
Never attribute to malice what can adequately be explained by incompetence.