From owner-svn-src-head@freebsd.org  Thu May 24 05:25:23 2018
Return-Path: <owner-svn-src-head@freebsd.org>
Delivered-To: svn-src-head@mailman.ysv.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1])
 by mailman.ysv.freebsd.org (Postfix) with ESMTP id 458F3EFE99F;
 Thu, 24 May 2018 05:25:23 +0000 (UTC)
 (envelope-from glebius@FreeBSD.org)
Received: from cell.glebi.us (glebi.us [96.95.210.25])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (Client CN "cell.glebi.us", Issuer "cell.glebi.us" (not verified))
 by mx1.freebsd.org (Postfix) with ESMTPS id ADF2774D39;
 Thu, 24 May 2018 05:25:22 +0000 (UTC)
 (envelope-from glebius@FreeBSD.org)
Received: from cell.glebi.us (localhost [127.0.0.1])
 by cell.glebi.us (8.15.2/8.15.2) with ESMTPS id w4O5PKxN087117
 (version=TLSv1.2 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=NO);
 Wed, 23 May 2018 22:25:20 -0700 (PDT)
 (envelope-from glebius@FreeBSD.org)
Received: (from glebius@localhost)
 by cell.glebi.us (8.15.2/8.15.2/Submit) id w4O5PKXi087116;
 Wed, 23 May 2018 22:25:20 -0700 (PDT)
 (envelope-from glebius@FreeBSD.org)
X-Authentication-Warning: cell.glebi.us: glebius set sender to
 glebius@FreeBSD.org using -f
Date: Wed, 23 May 2018 22:25:20 -0700
From: Gleb Smirnoff <glebius@FreeBSD.org>
To: Matthew Macy <mmacy@freebsd.org>
Cc: src-committers <src-committers@freebsd.org>, svn-src-all@freebsd.org,
 svn-src-head@freebsd.org
Subject: Re: svn commit: r333860 - head/sys/kern
Message-ID: <20180524052520.GZ71675@FreeBSD.org>
References: <201805190510.w4J5AqfS054367@repo.freebsd.org>
 <20180523222743.GU71675@FreeBSD.org>
 <CAPrugNpKxEVx+g0D6qUwq=yw_W-QeuntupwAjteK1yALkJktag@mail.gmail.com>
 <20180523225729.GV71675@FreeBSD.org>
 <CAPrugNpsiYQ1MKkgGbkwPEeTcsTCdD_u5GAvYpMJKHzeSbCL=w@mail.gmail.com>
 <20180524044252.GW71675@FreeBSD.org>
 <CAPrugNoVPCbB0qTY=Z1dwCZ+bCbVbA1d5b0-tw5qaPxWRK0q8g@mail.gmail.com>
 <20180524050717.GY71675@FreeBSD.org>
 <CAPrugNri9xu6DeNR5pXWv6UjFEDuKuZD5LGbyvQAFKM-5F87mg@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <CAPrugNri9xu6DeNR5pXWv6UjFEDuKuZD5LGbyvQAFKM-5F87mg@mail.gmail.com>
User-Agent: Mutt/1.9.5 (2018-04-13)
X-BeenThere: svn-src-head@freebsd.org
X-Mailman-Version: 2.1.26
Precedence: list
List-Id: SVN commit messages for the src tree for head/-current
 <svn-src-head.freebsd.org>
List-Unsubscribe: <https://lists.freebsd.org/mailman/options/svn-src-head>,
 <mailto:svn-src-head-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-head/>
List-Post: <mailto:svn-src-head@freebsd.org>
List-Help: <mailto:svn-src-head-request@freebsd.org?subject=help>
List-Subscribe: <https://lists.freebsd.org/mailman/listinfo/svn-src-head>,
 <mailto:svn-src-head-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Thu, 24 May 2018 05:25:23 -0000

On Wed, May 23, 2018 at 10:13:25PM -0700, Matthew Macy wrote:
M> On Wed, May 23, 2018 at 10:07 PM, Gleb Smirnoff <glebius@freebsd.org> wrote:
M> > Can you please explain the bug supposed to be fixed by r333860 QUESTION MARK
M> 
M> Did I say it fixed a bug? Or are you saying we should just turn off
M> compiler warnings because Gleb Smirnoff knows better?

You just did say "Warnings find bugs PERIOD." This implicitly claimed
that shutting this one fixed a bug.

Indeed, I am saying that in this particular case Gleb Smirnoff knows
better than gcc8 does. However, I'm not saying to turn off compiler warnings.
Never said that. I am saying (several times already) not to insert redundant
code to shut up a warning that is false.

-- 
Gleb Smirnoff