From owner-cvs-all Sat Jan 11 12:59:45 2003 Delivered-To: cvs-all@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 6563637B401; Sat, 11 Jan 2003 12:59:44 -0800 (PST) Received: from critter.freebsd.dk (critter.freebsd.dk [212.242.86.163]) by mx1.FreeBSD.org (Postfix) with ESMTP id 251D643F96; Sat, 11 Jan 2003 12:59:40 -0800 (PST) (envelope-from phk@freebsd.org) Received: from critter.freebsd.dk (localhost [127.0.0.1]) by critter.freebsd.dk (8.12.6/8.12.6) with ESMTP id h0BKxDFt008552; Sat, 11 Jan 2003 21:59:14 +0100 (CET) (envelope-from phk@freebsd.org) To: Matthew Dillon Cc: Bruce Evans , Maxime Henrion , cvs-committers@freebsd.org, cvs-all@freebsd.org Subject: Re: cvs commit: src/sbin/sysctl sysctl.c src/sys/vm vm_meter.c vm_param.h src/usr.bin/systat vmstat.c src/usr.bin/vmstat vmstat.c From: phk@freebsd.org In-Reply-To: Your message of "Sat, 11 Jan 2003 11:42:06 PST." <200301111942.h0BJg6ED041424@apollo.backplane.com> Date: Sat, 11 Jan 2003 21:59:13 +0100 Message-ID: <8551.1042318753@critter.freebsd.dk> Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG In message <200301111942.h0BJg6ED041424@apollo.backplane.com>, Matthew Dillon w rites: > >:I had not noticed this, but noticed many others (loss of compatibility >:by renaming old interfaces, printf format errors in sysctl.c including >:truncating all the int32_t fields mod 64K, and some bugs in the source >:and output formatting in sysctl.c). >: >:The following patch fixes most of the problems in sysctl.c (however, I >:would prefer to back out the changes there, since everything is or should >:be better thandled in vmstat or systat). > > sysctl.c has a mechanism to print out normally opaque sysctl structures. > Either we support it or we don't. We should not support it. -- Poul-Henning Kamp | UNIX since Zilog Zeus 3.20 phk@FreeBSD.ORG | TCP/IP since RFC 956 FreeBSD committer | BSD since 4.3-tahoe Never attribute to malice what can adequately be explained by incompetence. To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message