From owner-freebsd-rc@FreeBSD.ORG  Fri Oct 28 23:40:12 2011
Return-Path: <owner-freebsd-rc@FreeBSD.ORG>
Delivered-To: freebsd-rc@hub.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id A9B17106567B
	for <freebsd-rc@hub.freebsd.org>; Fri, 28 Oct 2011 23:40:12 +0000 (UTC)
	(envelope-from gnats@FreeBSD.org)
Received: from freefall.freebsd.org (freefall.freebsd.org
	[IPv6:2001:4f8:fff6::28])
	by mx1.freebsd.org (Postfix) with ESMTP id 996478FC18
	for <freebsd-rc@hub.freebsd.org>; Fri, 28 Oct 2011 23:40:12 +0000 (UTC)
Received: from freefall.freebsd.org (localhost [127.0.0.1])
	by freefall.freebsd.org (8.14.4/8.14.4) with ESMTP id p9SNeCX5023978
	for <freebsd-rc@freefall.freebsd.org>; Fri, 28 Oct 2011 23:40:12 GMT
	(envelope-from gnats@freefall.freebsd.org)
Received: (from gnats@localhost)
	by freefall.freebsd.org (8.14.4/8.14.4/Submit) id p9SNeCZS023977;
	Fri, 28 Oct 2011 23:40:12 GMT (envelope-from gnats)
Date: Fri, 28 Oct 2011 23:40:12 GMT
Message-Id: <201110282340.p9SNeCZS023977@freefall.freebsd.org>
To: freebsd-rc@FreeBSD.org
From: Dimitry Andric <dim@FreeBSD.org>
Cc: 
Subject: Re: conf/161710: SSHD starts on boot even if  sshd_enable=&quot;
 NO&quot; in 8.2
X-BeenThere: freebsd-rc@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
Reply-To: Dimitry Andric <dim@FreeBSD.org>
List-Id: "Discussion related to /etc/rc.d design and implementation."
	<freebsd-rc.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-rc>,
	<mailto:freebsd-rc-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-rc>
List-Post: <mailto:freebsd-rc@freebsd.org>
List-Help: <mailto:freebsd-rc-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-rc>,
	<mailto:freebsd-rc-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Fri, 28 Oct 2011 23:40:12 -0000

The following reply was made to PR conf/161710; it has been noted by GNATS.

From: Dimitry Andric <dim@FreeBSD.org>
To: bug-followup@FreeBSD.org, freebsd.org@logicalsolutns.com
Cc:  
Subject: Re: conf/161710: SSHD starts on boot even if  sshd_enable=&quot;NO&quot;
 in 8.2
Date: Sat, 29 Oct 2011 01:30:45 +0200

 This is a multi-part message in MIME format.
 --------------050401080107000606050906
 Content-Type: text/plain; charset=ISO-8859-1; format=flowed
 Content-Transfer-Encoding: 7bit
 
 Aha, now I see the cause of the problem.  A similar case to yours was
 actually reported in conf/156427:
 
    http://www.freebsd.org/cgi/query-pr.cgi?pr=156427
 
 There is an issue in /etc/rc.subr, which was introduced accidentally in
 r206686, fixed in head in r220760, and later merged to stable/8 in
 r220958:
 
    http://svnweb.freebsd.org/base?view=revision&revision=220958
 
 but this was after 8.2 released, unfortunately.
 
 You should be able to fix it by applying just the diff to rc.subr, which
 I have attached for your convenience.
 
 --------------050401080107000606050906
 Content-Type: text/x-diff;
  name="pr156427.diff"
 Content-Transfer-Encoding: 7bit
 Content-Disposition: attachment;
  filename="pr156427.diff"
 
 --- etc/rc.subr	2011/04/22 23:42:23	220957
 +++ etc/rc.subr	2011/04/22 23:44:25	220958
 @@ -651,7 +651,8 @@
  					#	checkyesno ${rcvar}
  					# and return if that failed
  					#
 -		if [ -n "${rcvar}" -a "$rc_arg" != "rcvar" -a -z "${rc_pid}" ]; then
 +		if [ -n "${rcvar}" -a "$rc_arg" != "rcvar" -a "$rc_arg" != "stop" ] ||
 +		    [ -n "${rcvar}" -a "$rc_arg" = "stop" -a -z "${rc_pid}" ]; then
  			if ! checkyesno ${rcvar}; then
  				if [ -n "${rc_quiet}" ]; then
  					return 0
 
 --------------050401080107000606050906--