Skip site navigation (1)Skip section navigation (2)
Date:      Thu, 29 Oct 2015 10:13:55 +0000 (UTC)
From:      Kubilay Kocak <koobs@FreeBSD.org>
To:        ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org
Subject:   svn commit: r400452 - head/www/py-django-contrib-comments
Message-ID:  <201510291013.t9TADtVq049595@repo.freebsd.org>

next in thread | raw e-mail | index | archive | help
Author: koobs
Date: Thu Oct 29 10:13:55 2015
New Revision: 400452
URL: https://svnweb.freebsd.org/changeset/ports/400452

Log:
  www/py-django-contrib-comments: Fix *_DEPENDS
  
  Update RUN_DEPENDS from file based back to PKGNAME based matching. Use
  a glob pattern to match multiple version suffixed versions of the
  Django ports, as `pkg info -g` is used to match them, excellent! [1]
  
  This doesn't completely solve the problem for Django ports and their
  dependencies, as there is still the issue of 'which' Django port to use
  if:
  
   * The dependency is not yet satisfied (fresh installs), AND
   * The port that depends on Django supports multiple versions, like this
     one.
  
  While I'm here:
  
  - Mark architecture independent (NO_ARCH)
  - Remove TEST_DEPENDS (no longer necessary)
  - Rename test target since the framework supports all the things now.
  - Update test target to include a default timezone, otherwise the
    test suite borks.
  
  [1] Thanks antoine!

Modified:
  head/www/py-django-contrib-comments/Makefile

Modified: head/www/py-django-contrib-comments/Makefile
==============================================================================
--- head/www/py-django-contrib-comments/Makefile	Thu Oct 29 09:45:34 2015	(r400451)
+++ head/www/py-django-contrib-comments/Makefile	Thu Oct 29 10:13:55 2015	(r400452)
@@ -13,13 +13,14 @@ COMMENT=	Code formerly known as django.c
 LICENSE=	BSD3CLAUSE
 LICENSE_FILE=	${WRKSRC}/LICENSE.txt
 
-RUN_DEPENDS=	${PYTHON_SITELIBDIR}/django/bin/django-admin.py:${PORTSDIR}/www/py-django # >= 1.5
-TEST_DEPENDS:=	${RUN_DEPENDS}
+RUN_DEPENDS=	${PYTHON_PKGNAMEPREFIX}django*>=1.5:${PORTSDIR}/www/py-django
 
 USES=		python
 USE_PYTHON=	autoplist distutils
 
-regression-test: build
-	@cd ${WRKSRC} && ${PYTHON_CMD} ${PYDISTUTILS_SETUP} test
+NO_ARCH=	yes
+
+do-test:
+	@cd ${WRKSRC} && ${SETENV} TZ=UTC ${PYTHON_CMD} ${PYDISTUTILS_SETUP} test
 
 .include <bsd.port.mk>



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201510291013.t9TADtVq049595>