From owner-svn-src-head@freebsd.org  Sun Mar  5 23:41:16 2017
Return-Path: <owner-svn-src-head@freebsd.org>
Delivered-To: svn-src-head@mailman.ysv.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 by mailman.ysv.freebsd.org (Postfix) with ESMTP id CF5BDCFBF04
 for <svn-src-head@mailman.ysv.freebsd.org>;
 Sun,  5 Mar 2017 23:41:16 +0000 (UTC)
 (envelope-from wlosh@bsdimp.com)
Received: from mail-io0-x22c.google.com (mail-io0-x22c.google.com
 [IPv6:2607:f8b0:4001:c06::22c])
 (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits))
 (Client CN "smtp.gmail.com",
 Issuer "Google Internet Authority G2" (verified OK))
 by mx1.freebsd.org (Postfix) with ESMTPS id A1DAB1212
 for <svn-src-head@freebsd.org>; Sun,  5 Mar 2017 23:41:16 +0000 (UTC)
 (envelope-from wlosh@bsdimp.com)
Received: by mail-io0-x22c.google.com with SMTP id l7so103290886ioe.3
 for <svn-src-head@freebsd.org>; Sun, 05 Mar 2017 15:41:16 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=bsdimp-com.20150623.gappssmtp.com; s=20150623;
 h=mime-version:sender:in-reply-to:references:from:date:message-id
 :subject:to:cc;
 bh=CQ8NCCHn25kPCaLoKgJscPLbYPWoy7hZjSczm+15FHg=;
 b=lMM3HBcSqNuZXXH5kqDPl6gpglSgBOw2BSkzFJfl5ylEawPHQ9x10cX8PJbI89Wn0V
 UNQ/EzDiQTpcEbUZWQD2MOxe7ceL0mEewutli4dSfiypTV+xFhHqJae6xpQeWVcJGeHV
 LaYCQ1fZ6II2bWIS9lYLuf7zk9/yIEy7HfUqhHP9SqhSTUNRXDafvoOtcSkK9+NqjUHa
 /9Dutpce7sI40p4C8FzWa1zoD05IdrOho3lFHEPzhGPN+E1jlXSxsXRVO7rYqC7aGz/W
 5rUSSr92sK96u2gn7ytdkMidl8c0dWFk75F1YAFEIJdk5eaXv82TsLWl6b6uY/B4Nc89
 bAbQ==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20161025;
 h=x-gm-message-state:mime-version:sender:in-reply-to:references:from
 :date:message-id:subject:to:cc;
 bh=CQ8NCCHn25kPCaLoKgJscPLbYPWoy7hZjSczm+15FHg=;
 b=JGqx5SlZwJbwNZ62Cg1gdveJZfTsYd9nuv6N3WQ/Bw+2L21CWIDqk1vh9cixcDuIqC
 cKRxyQCUQbJPKSAqbhskzs2VxYG2XhTzRoS6VUEU3McWZLJ51lAuD/4lFrZmeryDK9Ym
 HAV240WIIUsROy0zm6w/M6T3qtce3ls5Pw5TsdkTSHnZS/3z6jVdp+7rk8xITcM+kNAD
 w0CdApDP8J7x704nimISOpHRON7Mb6ISsnhbIzYxef/zGgJyYvqCGLj+MXu6sE331vCA
 1568D/AhJbUYk267elpjbfzIjio2dH2foGyCKEdx14j6DNSDTYUOjIiya3GlvugVud8G
 jlHQ==
X-Gm-Message-State: AMke39k+KumsjH6CKbqC7JLyz/kC/WLdiBE+bkUNyBm6W/NJY18TO8O6e3jx5eGIOzIwZ+/wP+GL6g2eA2ZQwA==
X-Received: by 10.107.198.193 with SMTP id w184mr12234519iof.19.1488757275537; 
 Sun, 05 Mar 2017 15:41:15 -0800 (PST)
MIME-Version: 1.0
Sender: wlosh@bsdimp.com
Received: by 10.79.134.129 with HTTP; Sun, 5 Mar 2017 15:41:15 -0800 (PST)
X-Originating-IP: [69.53.245.200]
In-Reply-To: <201703052116.v25LGoEv072414@repo.freebsd.org>
References: <201703052116.v25LGoEv072414@repo.freebsd.org>
From: Warner Losh <imp@bsdimp.com>
Date: Sun, 5 Mar 2017 16:41:15 -0700
X-Google-Sender-Auth: euayF483Kmv_iemNG73Mcv623Wc
Message-ID: <CANCZdfpPaMzuP_6UMFUF8xjU=8Ne4CrmcBWyXe9-e-R5fVeRYA@mail.gmail.com>
Subject: Re: svn commit: r314709 - head
To: Bryan Drewery <bdrewery@freebsd.org>
Cc: src-committers <src-committers@freebsd.org>, 
 "svn-src-all@freebsd.org" <svn-src-all@freebsd.org>, 
 "svn-src-head@freebsd.org" <svn-src-head@freebsd.org>
Content-Type: text/plain; charset=UTF-8
X-BeenThere: svn-src-head@freebsd.org
X-Mailman-Version: 2.1.23
Precedence: list
List-Id: SVN commit messages for the src tree for head/-current
 <svn-src-head.freebsd.org>
List-Unsubscribe: <https://lists.freebsd.org/mailman/options/svn-src-head>,
 <mailto:svn-src-head-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-head/>
List-Post: <mailto:svn-src-head@freebsd.org>
List-Help: <mailto:svn-src-head-request@freebsd.org?subject=help>
List-Subscribe: <https://lists.freebsd.org/mailman/listinfo/svn-src-head>,
 <mailto:svn-src-head-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sun, 05 Mar 2017 23:41:16 -0000

On Sun, Mar 5, 2017 at 2:16 PM, Bryan Drewery <bdrewery@freebsd.org> wrote:
> Author: bdrewery
> Date: Sun Mar  5 21:16:50 2017
> New Revision: 314709
> URL: https://svnweb.freebsd.org/changeset/base/314709
>
> Log:
>   Fix bootstrapping mtree after r313404 for older systems.
>
>   r313404 made libnetbsd require sha384.h from libmd.  Libmd added it in
>   r292782.  Update BOOTSTRAPPING to account for this.
>
>   Reported by:  bde
>   Reviewed by:  ngie
>
> Modified:
>   head/Makefile.inc1
>
> Modified: head/Makefile.inc1
> ==============================================================================
> --- head/Makefile.inc1  Sun Mar  5 19:56:20 2017        (r314708)
> +++ head/Makefile.inc1  Sun Mar  5 21:16:50 2017        (r314709)
> @@ -1618,10 +1618,12 @@ ${_bt}-usr.bin/m4: ${_bt}-lib/libopenbsd
>  ${_bt}-usr.bin/lex: ${_bt}-usr.bin/m4
>  .endif
>
> -.if ${BOOTSTRAPPING} < 1000026
> -_nmtree=       lib/libnetbsd \

I've been trying to document the bootstrapping stuff inline like

# r313404 made libnetbsd require libmd

so we know why things are the way they are. Sure, I can chase down a
dozen things in the svn logs, but a quick shortcut like that saves a
lot of time.

Any chance you could do that as well?

Warner

> +.if ${BOOTSTRAPPING} < 1100093
> +_nmtree=       lib/libmd \
> +               lib/libnetbsd \
>                 usr.sbin/nmtree
>
> +${_bt}-lib/libnetbsd: ${_bt}-lib/libmd
>  ${_bt}-usr.sbin/nmtree: ${_bt}-lib/libnetbsd
>  .endif
>
>