From owner-svn-ports-all@freebsd.org Tue Mar 16 22:19:16 2021 Return-Path: Delivered-To: svn-ports-all@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 17C4557015B; Tue, 16 Mar 2021 22:19:16 +0000 (UTC) (envelope-from mat@freebsd.org) Received: from smtp.freebsd.org (smtp.freebsd.org [96.47.72.83]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4F0SPc07GNz3mrb; Tue, 16 Mar 2021 22:19:16 +0000 (UTC) (envelope-from mat@freebsd.org) Received: from mail.j.mat.cc (owncloud.cube.mat.cc [IPv6:2a01:678:4:1::228]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "mail.mat.cc", Issuer "R3" (verified OK)) (Authenticated sender: mat/mail) by smtp.freebsd.org (Postfix) with ESMTPSA id BB0649FFB; Tue, 16 Mar 2021 22:19:15 +0000 (UTC) (envelope-from mat@freebsd.org) Received: from aching.in.mat.cc (unknown [IPv6:2a01:678:42:0:2414:199b:8ec2:8376]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: mat@mat.cc) by mail.j.mat.cc (Postfix) with ESMTPSA id ACC7A942D80; Tue, 16 Mar 2021 22:19:13 +0000 (UTC) Date: Tue, 16 Mar 2021 23:19:12 +0100 From: Mathieu Arnold To: Juraj Lutter Cc: ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org Subject: Re: svn commit: r568508 - head/devel/node-gyp Message-ID: <20210316221912.smaeylfqtx7yfm6i@aching.in.mat.cc> References: <202103152102.12FL2tRP068067@repo.freebsd.org> <20210316211715.pa4w3lrffzxr3ftx@aching.in.mat.cc> <2239997E-E3B6-403F-B36D-4326CDF16EFE@FreeBSD.org> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="m24qsdxsnuqurlda" Content-Disposition: inline In-Reply-To: <2239997E-E3B6-403F-B36D-4326CDF16EFE@FreeBSD.org> X-BeenThere: svn-ports-all@freebsd.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: SVN commit messages for the ports tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 16 Mar 2021 22:19:16 -0000 --m24qsdxsnuqurlda Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Tue, Mar 16, 2021 at 11:10:16PM +0100, Juraj Lutter wrote: >=20 > > On 16 Mar 2021, at 22:17, Mathieu Arnold wrote: > >=20 > > On Mon, Mar 15, 2021 at 09:02:55PM +0000, Juraj Lutter wrote: > >> Author: otis > >> Date: Mon Mar 15 21:02:55 2021 > >> New Revision: 568508 > >> URL: https://svnweb.freebsd.org/changeset/ports/568508 > >>=20 > >> Log: > >> Add port: devel/node-gyp: a build frmework for building Node.js appli= cations. > >=20 > > A few problems with this, and the next 2 ports added, so putting my > > portmgr's hat on. > >=20 > > We do not add node modules to the ports tree. > > We really do not add node modules to the ports tree. > >=20 > > If an application needs nodes modules to work, then the port for that > > application needs to handle the modules installing, and put those in a > > private place. > >=20 > > lib/node_modules is a really aweful place to put this. As a side note, > > if we were to add node modules to the ports tree, which we are not, it > > would probably be libdata/node_modules or share/node_modules. > >=20 > > Please remove those ports. >=20 >=20 > The rationale behind this is: > - Upcoming textproc/kibana7 has =E2=80=9Cre2=E2=80=9D node module bundled= , which also contains > a re2.node binary module, that (from distribution tarball) can be for Lin= ux or Darwin. >=20 > - In order to build re2.node binary component for FreeBSD in poudriere wi= thout need for > network access that would otherwise be needed, separate port seemed the m= ost ellegant way. >=20 > I value your comment and any hints/advises are welcome. The rationale being that given X ports that depend on a node module, you will probably need more than X versions of that module because they will all depend on incompatible versions of said module. A port that requires node modules must provide its own. It can absolutely be by having an extra step for the maintainer to generate a tarball with all the required modules that can simply be extracted as needed. I have not checked, but there are probably ports already doing this. --=20 Mathieu Arnold --m24qsdxsnuqurlda Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQKTBAABCgB9FiEEVhwchfRfuV0unqO5KesJApEdfgIFAmBRLttfFIAAAAAALgAo aXNzdWVyLWZwckBub3RhdGlvbnMub3BlbnBncC5maWZ0aGhvcnNlbWFuLm5ldDU2 MUMxQzg1RjQ1RkI5NUQyRTlFQTNCOTI5RUIwOTAyOTExRDdFMDIACgkQKesJApEd fgI8uQ/9EP4GeVzCv3wWp9eRRgNIGcPxzYdGPbnF/mE+8gWBV+C81WnV0jdlEORk FRKY+JOEVi5MzPTfIu3B93maxQft4tLOlXA0S76Tn4fznEIPvPVFZhl/8uisLAL0 pKGj7PQnVp+yy56BfVygPWJKb6Ws82TX2YxqOyj0W0I2i7QizaMuhHQ1ftVpkp85 bOSDA/gH42Kkn+zMYu3FtYP79I9N+kTd29PKUeuAq/6M7LbFt+w0TL8lko5ah+d/ CCXNQKVU4MrQfmRz2wUQlBOEJk5S0TbwcxV5T8kJwNjMO7HUeAfdX+HgIVatB9E/ dwxleFo+ppDQLWNVH1MB/+kSBYUwP9Qs9mW659VwSkEbyTGQWFQBpNOq/T1Ye2Kt RG6KFK1vFI9/jW6XSFUsYLohw+X0nnZx7IuqZSwMGf9wItD2yXR1JKqhk/dKHhEg w+TBTJvAMKiNCQ6MN+KwzYDmVKjtaAzocrjEUocOOUKDHjBkyDuEHTET7jz2uz6Q COwXvIP9OqB9ljAawLsiOFSsvOHlSk4rZhoj8uwXfIH/5kb/GDqn7AwKIM+knNw2 K2zak0F1FBcBrKRP8Kg6ueJqS588GVWC3RH3DlTAdnQD7YOV6Kh0KfctR0DNic/e aPtZS6UctJPUWnoSthELAuNNBS/+wXy8vgamuoV/H7Nwtf1mBbM= =3ada -----END PGP SIGNATURE----- --m24qsdxsnuqurlda--