From owner-freebsd-ports@FreeBSD.ORG  Mon Jan  9 21:06:43 2012
Return-Path: <owner-freebsd-ports@FreeBSD.ORG>
Delivered-To: ports@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id DA188106566C
	for <ports@freebsd.org>; Mon,  9 Jan 2012 21:06:43 +0000 (UTC)
	(envelope-from cvs-src@yandex.ru)
Received: from forward1.mail.yandex.net (forward1.mail.yandex.net
	[IPv6:2a02:6b8:0:602::1])
	by mx1.freebsd.org (Postfix) with ESMTP id 52A178FC08
	for <ports@freebsd.org>; Mon,  9 Jan 2012 21:06:43 +0000 (UTC)
Received: from smtp1.mail.yandex.net (smtp1.mail.yandex.net [77.88.46.101])
	by forward1.mail.yandex.net (Yandex) with ESMTP id 73C6C1240D28;
	Tue, 10 Jan 2012 01:06:42 +0400 (MSK)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yandex.ru; s=mail;
	t=1326143202; bh=nl0brS1asxLIRNZkJiYyFeL+XDhSdcJN2329IwtO7aY=;
	h=Message-ID:Date:From:MIME-Version:To:CC:Subject:References:
	In-Reply-To:Content-Type:Content-Transfer-Encoding;
	b=ds0i5CShq6hvogwOi/43g11s7YFa8yBnnO5AM98X8SkWkrngEl+CnAH3R7PmQiKg5
	YMx6x2cFHBvKJqwe9RXAswDjdlU81SG38jvqd2Tg1ZoZY2bqMYnJUkWAI1JASDk7D7
	oI2ccReb3Lp8TADjKU7YU/36EHtGb24OXmrRRMwY=
Received: from smtp1.mail.yandex.net (localhost [127.0.0.1])
	by smtp1.mail.yandex.net (Yandex) with ESMTP id 4E200AA0307;
	Tue, 10 Jan 2012 01:06:42 +0400 (MSK)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yandex.ru; s=mail;
	t=1326143202; bh=nl0brS1asxLIRNZkJiYyFeL+XDhSdcJN2329IwtO7aY=;
	h=Message-ID:Date:From:MIME-Version:To:CC:Subject:References:
	In-Reply-To:Content-Type:Content-Transfer-Encoding;
	b=ds0i5CShq6hvogwOi/43g11s7YFa8yBnnO5AM98X8SkWkrngEl+CnAH3R7PmQiKg5
	YMx6x2cFHBvKJqwe9RXAswDjdlU81SG38jvqd2Tg1ZoZY2bqMYnJUkWAI1JASDk7D7
	oI2ccReb3Lp8TADjKU7YU/36EHtGb24OXmrRRMwY=
Received: from unknown (unknown [178.76.224.133])
	by smtp1.mail.yandex.net (nwsmtp/Yandex) with ESMTP id
	6fumtkwd-6fua3sIf; Tue, 10 Jan 2012 01:06:42 +0400
X-Yandex-Spam: 1
Message-ID: <4F0B56BC.6080601@yandex.ru>
Date: Tue, 10 Jan 2012 01:06:04 +0400
From: Ruslan Mahmatkhanov <cvs-src@yandex.ru>
User-Agent: Mozilla/5.0 (X11; FreeBSD i386;
	rv:9.0) Gecko/20111229 Thunderbird/9.0
MIME-Version: 1.0
To: Michael Scheidell <michael.scheidell@secnap.com>
References: <4F0B4E5F.8040802@secnap.com>
In-Reply-To: <4F0B4E5F.8040802@secnap.com>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Cc: ports@freebsd.org
Subject: Re: archivers/zip in 9.x:
X-BeenThere: freebsd-ports@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: Porting software to FreeBSD <freebsd-ports.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-ports>,
	<mailto:freebsd-ports-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-ports>
List-Post: <mailto:freebsd-ports@freebsd.org>
List-Help: <mailto:freebsd-ports-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-ports>,
	<mailto:freebsd-ports-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Mon, 09 Jan 2012 21:06:43 -0000

Michael Scheidell wrote on 10.01.2012 00:30:
> I think I saw something in the list that FreeBSD 9.x has zip already
> built in? so, ports that need 'zip' won't need zip?
>
> for maintainers, they should use something like:
>
> USE_ZIP= yes
>
> to:
>
> if ${OSVERSION} <= 900000
> USE_ZIP= yes
> .endif
>
> and/or BUILD_DEPENDS+= zip:${PORTSDIR}/archivers/zip
>
> (at what OSVERSION was zip included in the base?)
>
>

unzip, not zip. I believe it should be handled in bsd.port.mk like it 
done for USE_XZ. Something like:

.if defined(USE_ZIP) && ${OSVERSION} < 900000
EXTRACT_DEPENDS+=       ${LOCALBASE}/bin/unzip:${PORTSDIR}/archivers/unzip
.endif

Correct OSVERSION should be used instead of 900000. There is also should 
be some logic for UNZIP_CMD.

-- 
Regards,
Ruslan

Tinderboxing kills... the drives.