From owner-freebsd-net@freebsd.org Sun Jan 24 09:07:52 2016 Return-Path: Delivered-To: freebsd-net@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 34252A8FD2D for ; Sun, 24 Jan 2016 09:07:52 +0000 (UTC) (envelope-from gljennjohn@gmail.com) Received: from mailman.ysv.freebsd.org (mailman.ysv.freebsd.org [IPv6:2001:1900:2254:206a::50:5]) by mx1.freebsd.org (Postfix) with ESMTP id 0FC651ED1 for ; Sun, 24 Jan 2016 09:07:52 +0000 (UTC) (envelope-from gljennjohn@gmail.com) Received: by mailman.ysv.freebsd.org (Postfix) id 0D924A8FD2B; Sun, 24 Jan 2016 09:07:52 +0000 (UTC) Delivered-To: net@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id E64E5A8FD2A; Sun, 24 Jan 2016 09:07:51 +0000 (UTC) (envelope-from gljennjohn@gmail.com) Received: from mail-wm0-x230.google.com (mail-wm0-x230.google.com [IPv6:2a00:1450:400c:c09::230]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 764581ED0; Sun, 24 Jan 2016 09:07:51 +0000 (UTC) (envelope-from gljennjohn@gmail.com) Received: by mail-wm0-x230.google.com with SMTP id n5so38515813wmn.0; Sun, 24 Jan 2016 01:07:51 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=date:from:to:cc:subject:message-id:in-reply-to:references:reply-to :mime-version:content-type:content-transfer-encoding; bh=ftgCuFcYSMnB6fuySuMbNckj06Pk0AgBG2W8kZzZtk4=; b=s4ewxpHOPi6DxQxbR2j4sivSOc6LL9Mwck1jDtHcQs3Qs/9M43VegwjGe0deQ1O6IP dI2KLTLilkNLV8oxBDuI1spQhuMqKR6ZMsjy5uh7OPP+pFSusCCWpPBw5JacIykRn0i/ RkHmUgn1MqGeRBVzQ8PxuCFSBP0uFf7M9TguR8w4HrQFRIjR4gt65BJDS0HGqRYMGKPA yo+Qjs/lkTYg0B6BQtLz/h/DoCr7ay5iPj716U3yLPO5BIf3t0NLanfvSrqHcxPKcQpe FMRKhF/YNrRtOBjuVYbin0+AlR/8aF+Fjvj6uHGEZAGkYYbT7GitC3b2lyBoRGbb7xe7 wxAw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:reply-to:mime-version:content-type :content-transfer-encoding; bh=ftgCuFcYSMnB6fuySuMbNckj06Pk0AgBG2W8kZzZtk4=; b=MQ0e4F4dumpKOvRACidgGt81X7BrwXjHBoW/4Mu/wCKxJssYAtRM+rdThlA0BKiGYO 2HMqDpdFFqcw6vYJuFHAIAOwBDttQHkUi1NHNuC5afs1nA078lJLHGb03QobKKtB7GFT PJ4/UgA5ocy//oV/SsqL+DxSekynlYcLzozXp5MWfCXjamwqQafQQD4AWhZ9eXo0/+pB CWBNcB1n5KXxzlvCri40GI1RAK0lJmpb6V+anHQLQ+mEuAeIIO4WKdDBDy+hlQNnppfv FE+hcM0D+immi62wviqoWIeJEgkbtmf/izls14/LZdpE2YL2lRCVKVQDrcOUpGGwaJAo /CxA== X-Gm-Message-State: AG10YORKQ9nr4JSO4oEWQ2U9nIuRnWO6iKuxLP5kEjCoYbQ+CHSt+u+9cphanKZUNQWgeA== X-Received: by 10.28.215.136 with SMTP id o130mr11996775wmg.33.1453626469665; Sun, 24 Jan 2016 01:07:49 -0800 (PST) Received: from ernst.home (p4FCA7FB6.dip0.t-ipconnect.de. [79.202.127.182]) by smtp.gmail.com with ESMTPSA id b127sm10631818wmh.9.2016.01.24.01.07.48 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sun, 24 Jan 2016 01:07:49 -0800 (PST) Date: Sun, 24 Jan 2016 10:07:47 +0100 From: Gary Jennejohn To: Konstantin Belousov Cc: Boris Astardzhiev , threads@freebsd.org, Bruce Evans , net@freebsd.org Subject: Re: Does FreeBSD have sendmmsg or recvmmsg system calls? Message-ID: <20160124100747.551f8e3f@ernst.home> In-Reply-To: <20160124050634.GS3942@kib.kiev.ua> References: <20160117211853.GA37847@stack.nl> <20160118044826.GS3942@kib.kiev.ua> <20160118140811.GW3942@kib.kiev.ua> <20160120073154.GB3942@kib.kiev.ua> <20160121093509.GK3942@kib.kiev.ua> <20160121233040.E1864@besplex.bde.org> <20160124050634.GS3942@kib.kiev.ua> Reply-To: gljennjohn@gmail.com X-Mailer: Claws Mail 3.13.1 (GTK+ 2.24.29; amd64-portbld-freebsd11.0) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 24 Jan 2016 09:07:52 -0000 On Sun, 24 Jan 2016 07:06:34 +0200 Konstantin Belousov wrote: [delete irrelevant parts of the patch] > > + rcvd = 1; > > + for (i = rcvd; i < vlen; i++) { > i = rcvd = 1; ... i++, rcvd++ ? > > > + ret = __sys_recvmsg(s, &msgvec[i].msg_hdr, flags); > > + if (ret == -1) { > > + if (rcvd != 0) { > > + /* We've received messages. Let caller know. */ > > + return (rcvd); > > + } > > + return (ret); > > + } > > + This seems wrong. rcvd is initialized to 1 so that the check for rcvd != 0 can never be false. We already successfully called __sys_recvmsg() just above the loop, so why not simplify the code by doing if (ret == -1) return (rcvd); -- Gary Jennejohn (gj@)