Date: Wed, 30 Jan 2019 12:09:45 +0100 From: Jan Beich <jbeich@FreeBSD.org> To: Stefan Esser <se@FreeBSD.org> Cc: ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org Subject: Re: svn commit: r491618 - in head/net: . timed Message-ID: <va26-2yh2-wny@FreeBSD.org> In-Reply-To: <201901301046.x0UAkO4M047694@repo.freebsd.org> (Stefan Esser's message of "Wed, 30 Jan 2019 10:46:24 %2B0000 (UTC)") References: <201901301046.x0UAkO4M047694@repo.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
Stefan Esser <se@FreeBSD.org> writes:
> + ${INSTALL_DATA} ${WRKSRC}/rc.d/timed \
> + ${STAGEDIR}${PREFIX}/etc/rc.d/
${INSTALL_DATA} unlike ${INSTALL_SCRIPT} strips executable bit. Are you sure?
$ make install
$ service timed onestart
timed does not exist in /etc/rc.d or the local startup
directories (/usr/local/etc/rc.d), or is not executable
> +@mode 4555
> +sbin/timedc
Looks unsafe as something may append ${TMPPLIST}, inheriting setuid bit.
Consider adding @mode at the end or converting to @(,,4555) sbin/timedc
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?va26-2yh2-wny>