From owner-cvs-all@FreeBSD.ORG  Thu Dec 23 10:57:18 2004
Return-Path: <owner-cvs-all@FreeBSD.ORG>
Delivered-To: cvs-all@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP
	id 2C64116A4CE; Thu, 23 Dec 2004 10:57:18 +0000 (GMT)
Received: from tigra.ip.net.ua (tigra.ip.net.ua [82.193.96.10])
	by mx1.FreeBSD.org (Postfix) with ESMTP
	id 26BFD43D53; Thu, 23 Dec 2004 10:57:17 +0000 (GMT)
	(envelope-from ru@ip.net.ua)
Received: from localhost (rocky.ip.net.ua [82.193.96.2])
	by tigra.ip.net.ua (8.12.11/8.12.11) with ESMTP id iBNAvGP7027360;
	Thu, 23 Dec 2004 12:57:16 +0200 (EET)
	(envelope-from ru@ip.net.ua)
Received: from tigra.ip.net.ua ([82.193.96.10])
 by localhost (rocky.ipnet [82.193.96.2]) (amavisd-new, port 10024) with LMTP
 id 48559-11; Thu, 23 Dec 2004 12:57:15 +0200 (EET)
Received: from heffalump.ip.net.ua (heffalump.ip.net.ua [82.193.96.213])
	by tigra.ip.net.ua (8.12.11/8.12.11) with ESMTP id iBNAvE7q027354
	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO);
	Thu, 23 Dec 2004 12:57:15 +0200 (EET)
	(envelope-from ru@ip.net.ua)
Received: (from ru@localhost)
	by heffalump.ip.net.ua (8.13.1/8.13.1) id iBNAvMw3083493;
	Thu, 23 Dec 2004 12:57:22 +0200 (EET)
	(envelope-from ru)
Date: Thu, 23 Dec 2004 12:57:21 +0200
From: Ruslan Ermilov <ru@FreeBSD.org>
To: Gleb Smirnoff <glebius@FreeBSD.org>
Message-ID: <20041223105721.GB83309@ip.net.ua>
References: <200412231048.iBNAmAM7042653@repoman.freebsd.org>
Mime-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha1;
	protocol="application/pgp-signature"; boundary="eJnRUKwClWJh1Khz"
Content-Disposition: inline
In-Reply-To: <200412231048.iBNAmAM7042653@repoman.freebsd.org>
User-Agent: Mutt/1.5.6i
X-Virus-Scanned: by amavisd-new at ip.net.ua
cc: cvs-src@FreeBSD.org
cc: src-committers@FreeBSD.org
cc: cvs-all@FreeBSD.org
Subject: Re: cvs commit: src/sys/netgraph ng_base.c
X-BeenThere: cvs-all@freebsd.org
X-Mailman-Version: 2.1.1
Precedence: list
List-Id: CVS commit messages for the entire tree <cvs-all.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-all>,
	<mailto:cvs-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/cvs-all>
List-Post: <mailto:cvs-all@freebsd.org>
List-Help: <mailto:cvs-all-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-all>,
	<mailto:cvs-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Thu, 23 Dec 2004 10:57:18 -0000


--eJnRUKwClWJh1Khz
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Thu, Dec 23, 2004 at 10:48:10AM +0000, Gleb Smirnoff wrote:
> glebius     2004-12-23 10:48:10 UTC
>=20
>   FreeBSD src repository
>=20
>   Modified files:
>     sys/netgraph         ng_base.c=20
>   Log:
>   - sort includes
>   - remove duplicate include sys/sysctl.h
>  =20
>   Revision  Changes    Path
>   1.89      +4 -5      src/sys/netgraph/ng_base.c
>=20
>  #include <sys/param.h>
> -#include <sys/systm.h>
> +#include <sys/ctype.h>
>  #include <sys/errno.h>
>  #include <sys/kdb.h>
>  #include <sys/kernel.h>
>  #include <sys/limits.h>
>  #include <sys/malloc.h>
> -#include <sys/syslog.h>
> -#include <sys/sysctl.h>
> -#include <sys/queue.h>
>  #include <sys/mbuf.h>
> -#include <sys/ctype.h>
> +#include <sys/queue.h>
>  #include <sys/sysctl.h>
> +#include <sys/syslog.h>
> +#include <sys/systm.h>
>=20
Wrong.  <sys/systm.h> is special, it's a prerequisite for
<sys/mbuf.h>, according to mbuf(9) manpage.  It only works
now because <sys/mbuf.h> includes it for the _KERNEL case.


Cheers,
--=20
Ruslan Ermilov
ru@FreeBSD.org
FreeBSD committer

--eJnRUKwClWJh1Khz
Content-Type: application/pgp-signature
Content-Disposition: inline

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.6 (FreeBSD)

iD8DBQFByqSRqRfpzJluFF4RAtplAJ9o3yGPCj59O1oV4vzWZMfBXi07ywCgjUpJ
LaECkhDGedtf9H+eyd8JSfM=
=WXZC
-----END PGP SIGNATURE-----

--eJnRUKwClWJh1Khz--