From owner-svn-src-head@freebsd.org  Thu Apr 21 17:08:46 2016
Return-Path: <owner-svn-src-head@freebsd.org>
Delivered-To: svn-src-head@mailman.ysv.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 by mailman.ysv.freebsd.org (Postfix) with ESMTP id D952CB17168;
 Thu, 21 Apr 2016 17:08:46 +0000 (UTC)
 (envelope-from yaneurabeya@gmail.com)
Received: from mail-lb0-x22f.google.com (mail-lb0-x22f.google.com
 [IPv6:2a00:1450:4010:c04::22f])
 (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits))
 (Client CN "smtp.gmail.com",
 Issuer "Google Internet Authority G2" (verified OK))
 by mx1.freebsd.org (Postfix) with ESMTPS id 62C1516BB;
 Thu, 21 Apr 2016 17:08:46 +0000 (UTC)
 (envelope-from yaneurabeya@gmail.com)
Received: by mail-lb0-x22f.google.com with SMTP id os9so30611544lbb.2;
 Thu, 21 Apr 2016 10:08:46 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113;
 h=mime-version:in-reply-to:references:date:message-id:subject:from:to
 :cc; bh=5R98OdF+WezAVKIxIwGzVSlaXF0eR/+YRvzlLVRF9CY=;
 b=z9YxiliOVhN0pPdvIDXnNOXChBEzNaywPA3KJqNNJuNgyFe03pSLGiLRdm5EBwAjNS
 4Jl7JPGDIHs3BdaHPYY2T00w2Urvyrqjxtt7s9iX55kL5MelJ0eRLXEhl9A7PQ4I8PIa
 aaNConQVOAm4uNCgcdJWyofKEqRa8TiaCUxLNeDXZDKXEZfVA/fC9Pevawy2lJ18lUp8
 qJeEkBKy41dqZHnFGb2GVndDO0ICj6ieDYLeA0q5fIh9P8KldVbS4m6oK3m1EYzWd2av
 6Vv45rIrLP5b+fKne2l7jXs1yDbjaMv70JoD62BlaNWEWxgHMb5OC8alZFeF3d5qIeM1
 2hmw==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20130820;
 h=x-gm-message-state:mime-version:in-reply-to:references:date
 :message-id:subject:from:to:cc;
 bh=5R98OdF+WezAVKIxIwGzVSlaXF0eR/+YRvzlLVRF9CY=;
 b=TnDGfUsv4DvH+zm/njMambHG14zV2ifcOgoXT8Pind0Qk4O9hMaS3Hiybh2/Rn7EXj
 klJratI3bhfxyviyhKb7qP4ifNqgUhlrsecdz9mXH5V/URqv7OkpjTuBPn0YBgWy9gsV
 K8dTdgRotGKAkyrhp4JOkJ1u1BdYwhm5WmX+LANLwn/RaDILgoEs26Wcsu78ZnvIkfC8
 IH56cRf90OCfh+isyUsBY45uuwa5DaNRzDGE4HAFXTSDARDt4bWY2SL+WUp3RxxQywZk
 rCIhKBV5YZjRYvhNNNFGVLBaOW3EiMUckYsyg5PzND1V3qQIzqtLwhtMBf/Pc9mLlyB5
 aNrQ==
X-Gm-Message-State: AOPr4FWIZtO9eNv2FE3oxshs33D9tMBPXmI8N0KNUwxnpEHpOuj5jhWLX2juUwVKlNlvy2yd+lN9gO9gRY09Jg==
MIME-Version: 1.0
X-Received: by 10.112.147.225 with SMTP id tn1mr6855001lbb.98.1461258524621;
 Thu, 21 Apr 2016 10:08:44 -0700 (PDT)
Received: by 10.112.236.33 with HTTP; Thu, 21 Apr 2016 10:08:44 -0700 (PDT)
In-Reply-To: <201604211643.u3LGhFpR057982@repo.freebsd.org>
References: <201604211643.u3LGhFpR057982@repo.freebsd.org>
Date: Thu, 21 Apr 2016 10:08:44 -0700
Message-ID: <CAGHfRMCj5zQUHddyoY8Vn2qxJyjV7sUHYDK+0Jg2SCCiFX6_Sw@mail.gmail.com>
Subject: Re: svn commit: r298420 - head/sys/geom
From: Ngie Cooper <yaneurabeya@gmail.com>
To: Alan Somers <asomers@freebsd.org>
Cc: "src-committers@freebsd.org" <src-committers@freebsd.org>, 
 "svn-src-all@freebsd.org" <svn-src-all@freebsd.org>, 
 "svn-src-head@freebsd.org" <svn-src-head@freebsd.org>
Content-Type: text/plain; charset=UTF-8
X-BeenThere: svn-src-head@freebsd.org
X-Mailman-Version: 2.1.21
Precedence: list
List-Id: SVN commit messages for the src tree for head/-current
 <svn-src-head.freebsd.org>
List-Unsubscribe: <https://lists.freebsd.org/mailman/options/svn-src-head>,
 <mailto:svn-src-head-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-head/>
List-Post: <mailto:svn-src-head@freebsd.org>
List-Help: <mailto:svn-src-head-request@freebsd.org?subject=help>
List-Subscribe: <https://lists.freebsd.org/mailman/listinfo/svn-src-head>,
 <mailto:svn-src-head-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Thu, 21 Apr 2016 17:08:47 -0000

On Thu, Apr 21, 2016 at 9:43 AM, Alan Somers <asomers@freebsd.org> wrote:
> Author: asomers
> Date: Thu Apr 21 16:43:15 2016
> New Revision: 298420
> URL: https://svnweb.freebsd.org/changeset/base/298420
>
> Log:
>   Notify userspace listeners when geom disk attributes have changed
>
>   sys/geom/geom_disk.c:
>         disk_attr_changed(): Generate a devctl event of type GEOM:<attr> for
>         every call.
>
>   MFC after:    4 weeks
>   Sponsored by: Spectra Logic Corp
>   Differential Revision:        https://reviews.freebsd.org/D5952
>
> Modified:
>   head/sys/geom/geom_disk.c
>
> Modified: head/sys/geom/geom_disk.c
> ==============================================================================
> --- head/sys/geom/geom_disk.c   Thu Apr 21 16:33:42 2016        (r298419)
> +++ head/sys/geom/geom_disk.c   Thu Apr 21 16:43:15 2016        (r298420)
> @@ -43,6 +43,7 @@ __FBSDID("$FreeBSD$");
>  #include <sys/kernel.h>
>  #include <sys/sysctl.h>
>  #include <sys/bio.h>
> +#include <sys/bus.h>
>  #include <sys/ctype.h>
>  #include <sys/fcntl.h>
>  #include <sys/malloc.h>
> @@ -839,11 +840,14 @@ disk_attr_changed(struct disk *dp, const
>  {
>         struct g_geom *gp;
>         struct g_provider *pp;
> +       char devnamebuf[128];

Why 128? Also, why not sbuf?

>         gp = dp->d_geom;
>         if (gp != NULL)
>                 LIST_FOREACH(pp, &gp->provider, provider)
>                         (void)g_attr_changed(pp, attr, flag);
> +       snprintf(devnamebuf, 128, "devname=%s%d", dp->d_name, dp->d_unit);

Why not sizeof(devnamebuf) ?

> +       devctl_notify("GEOM", "disk", attr, devnamebuf);
>  }
>
>  void
>