From owner-svn-src-all@freebsd.org Wed Nov 21 16:41:52 2018 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 60AE0113DEB0; Wed, 21 Nov 2018 16:41:52 +0000 (UTC) (envelope-from kevans@freebsd.org) Received: from smtp.freebsd.org (smtp.freebsd.org [IPv6:2610:1c1:1:606c::24b:4]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "smtp.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 02CEB69908; Wed, 21 Nov 2018 16:41:52 +0000 (UTC) (envelope-from kevans@freebsd.org) Received: from mail-lj1-f182.google.com (mail-lj1-f182.google.com [209.85.208.182]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G3" (verified OK)) (Authenticated sender: kevans) by smtp.freebsd.org (Postfix) with ESMTPSA id 9A48B24193; Wed, 21 Nov 2018 16:41:51 +0000 (UTC) (envelope-from kevans@freebsd.org) Received: by mail-lj1-f182.google.com with SMTP id v1-v6so5437702ljd.0; Wed, 21 Nov 2018 08:41:51 -0800 (PST) X-Gm-Message-State: AGRZ1gJsQLMymM6YogvMRrysUhNoQO0Pmco0WooJK/SPM15BOl0czNmS gMCDPFP4h0Ebc0T6JKG26dmnj5nECzpnyCHNKDI= X-Google-Smtp-Source: AFSGD/W6BbHwcNm7GWx8lWrKeZRp8K79E7y+A3YhBkkaZkDZR+uqLjUf2yhcfoHuSkKnVGQDxtr52qoo0L884Dud7Ig= X-Received: by 2002:a2e:a202:: with SMTP id h2-v6mr4505953ljm.72.1542818510077; Wed, 21 Nov 2018 08:41:50 -0800 (PST) MIME-Version: 1.0 References: <201811211122.wALBMiCt071058@repo.freebsd.org> <201811211618.wALGIt0N072613@pdx.rh.CN85.dnsmgr.net> In-Reply-To: <201811211618.wALGIt0N072613@pdx.rh.CN85.dnsmgr.net> From: Kyle Evans Date: Wed, 21 Nov 2018 10:41:37 -0600 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: svn commit: r340722 - head/lib/libbe To: "Rodney W. Grimes" Cc: 0mp@freebsd.org, svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers Content-Type: text/plain; charset="UTF-8" X-Rspamd-Queue-Id: 02CEB69908 X-Spamd-Result: default: False [0.37 / 15.00]; local_wl_from(0.00)[freebsd.org]; NEURAL_SPAM_MEDIUM(0.34)[0.342,0]; ASN(0.00)[asn:11403, ipnet:2610:1c1:1::/48, country:US]; NEURAL_SPAM_SHORT(0.06)[0.064,0]; NEURAL_HAM_LONG(-0.04)[-0.041,0] X-Rspamd-Server: mx1.freebsd.org X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 21 Nov 2018 16:41:52 -0000 On Wed, Nov 21, 2018 at 10:19 AM Rodney W. Grimes wrote: > > > Author: 0mp (ports committer) > > Date: Wed Nov 21 11:22:44 2018 > > New Revision: 340722 > > URL: https://svnweb.freebsd.org/changeset/base/340722 > > > > Log: > > libbe(3): Put each error value in separate line. > > > > As requested by a TODO in the source code. > > > > Reviewed by: bcr > > Approved by: krion (mentor, implicit), mat (mentor, implicit) > > Differential Revision: https://reviews.freebsd.org/D18063 > > Who with a src bit approved the commit to src? > I do want to clarify- bcr approved it in the review (explicitly with "... hereby approved!") -- are you mainly pointing out that he failed to annotate this properly in the commit, or is doc bit approval for a commit to a manpage in src insufficient? As an aside, happy to approve any changes to these manpages as the current bectl/libbe maintainer for anyone that wants to improve them. =) Thanks, Kyle Evans