From owner-svn-ports-head@freebsd.org  Wed Oct 30 20:12:16 2019
Return-Path: <owner-svn-ports-head@freebsd.org>
Delivered-To: svn-ports-head@mailman.nyi.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1])
 by mailman.nyi.freebsd.org (Postfix) with ESMTP id BAF1D15FF27;
 Wed, 30 Oct 2019 20:12:16 +0000 (UTC)
 (envelope-from zeising@freebsd.org)
Received: from mail.daemonic.se (mail.daemonic.se [176.58.89.161])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (Client did not present a certificate)
 by mx1.freebsd.org (Postfix) with ESMTPS id 473KPD4Sqbz4XBQ;
 Wed, 30 Oct 2019 20:12:16 +0000 (UTC)
 (envelope-from zeising@freebsd.org)
Received: from cid.daemonic.se (localhost [IPv6:::1])
 by mail.daemonic.se (Postfix) with ESMTP id 473KP52gLVz3lM0;
 Wed, 30 Oct 2019 20:12:09 +0000 (UTC)
X-Virus-Scanned: amavisd-new at daemonic.se
Received: from mail.daemonic.se ([IPv6:::1]) (using TLS with cipher
 ECDHE-RSA-AES128-GCM-SHA256)
 by cid.daemonic.se (mailscanner.daemonic.se [IPv6:::1]) (amavisd-new,
 port 10587)
 with ESMTPS id fRct32_S9KGG; Wed, 30 Oct 2019 20:12:00 +0000 (UTC)
Received: from vivi.daemonic.se (vivi.daemonic.se [IPv6:2001:470:dca9:2::4])
 by mail.daemonic.se (Postfix) with ESMTPSA id 473KNw4mjxz3c7Z;
 Wed, 30 Oct 2019 20:12:00 +0000 (UTC)
Subject: Re: svn commit: r516100 - in head: graphics/libosmesa
 graphics/libxatracker graphics/mesa-dri graphics/mesa-dri/files
 graphics/mesa-libs lang/clover
To: Jan Beich <jbeich@FreeBSD.org>
Cc: ports-committers@freebsd.org, svn-ports-all@freebsd.org,
 svn-ports-head@freebsd.org
References: <201910301907.x9UJ7W2N025166@repo.freebsd.org>
 <1ruu-5845-wny@FreeBSD.org>
From: Niclas Zeising <zeising@freebsd.org>
Message-ID: <c769c411-5f56-607b-dd1c-6046b9398e46@freebsd.org>
Date: Wed, 30 Oct 2019 21:11:53 +0100
User-Agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:68.0) Gecko/20100101
 Thunderbird/68.2.0
MIME-Version: 1.0
In-Reply-To: <1ruu-5845-wny@FreeBSD.org>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
X-Rspamd-Queue-Id: 473KPD4Sqbz4XBQ
X-Spamd-Bar: -----
Authentication-Results: mx1.freebsd.org;
	none
X-Spamd-Result: default: False [-5.99 / 15.00];
 NEURAL_HAM_MEDIUM(-0.99)[-0.992,0];
 NEURAL_HAM_LONG(-1.00)[-1.000,0]; REPLY(-4.00)[]
X-BeenThere: svn-ports-head@freebsd.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: SVN commit messages for the ports tree for head
 <svn-ports-head.freebsd.org>
List-Unsubscribe: <https://lists.freebsd.org/mailman/options/svn-ports-head>, 
 <mailto:svn-ports-head-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-ports-head/>
List-Post: <mailto:svn-ports-head@freebsd.org>
List-Help: <mailto:svn-ports-head-request@freebsd.org?subject=help>
List-Subscribe: <https://lists.freebsd.org/mailman/listinfo/svn-ports-head>,
 <mailto:svn-ports-head-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Wed, 30 Oct 2019 20:12:16 -0000

On 2019-10-30 20:46, Jan Beich wrote:
> Niclas Zeising <zeising@FreeBSD.org> writes:
> 
>> Modified:
>>    head/graphics/libosmesa/Makefile
>>    head/graphics/libxatracker/Makefile
>>    head/graphics/mesa-dri/Makefile
>>    head/graphics/mesa-dri/files/patch-configure
> 
> Did you forget to sync with files/configure.ac? In the past[1] the file
> was used whenever mesa-dri or related ports had to add USES=autoreconf.
> 
> [1] before https://svnweb.freebsd.org/changeset/ports/472508
> 

Currently, there is no patch for configure.ac, but several for 
configure, and as far as I can tell, no mesa port is using autoreconf. 
Adding a patch for configure.ac that's not used by any port feels 
unnecessary, especially since only patching for this issue would make it 
incomplete.  Having a file in files/ that's not actually used is just a 
recipe for it getting stale.
Regards
-- 
Niclas Zeising