From owner-svn-src-projects@freebsd.org Thu Feb 21 07:54:39 2019 Return-Path: Delivered-To: svn-src-projects@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id D2A9D14FB65B for ; Thu, 21 Feb 2019 07:54:38 +0000 (UTC) (envelope-from yaneurabeya@gmail.com) Received: from mail-pf1-x42a.google.com (mail-pf1-x42a.google.com [IPv6:2607:f8b0:4864:20::42a]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4E916948E9; Thu, 21 Feb 2019 07:54:38 +0000 (UTC) (envelope-from yaneurabeya@gmail.com) Received: by mail-pf1-x42a.google.com with SMTP id d25so5001811pfn.8; Wed, 20 Feb 2019 23:54:38 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:message-id:mime-version:subject:date:in-reply-to:cc:to :references; bh=9GoAiPG2LEQgoV4QNFJQzBQIMhm+6qUvLvl/unLdQfM=; b=MJUzNSmpgzxr2NUUcmsLUQ1xstW1aCPHKngxPZ+9kZPf/77Fu0ZPUIkEEXNn+/GXU2 kLoI8tx/tZkeNeACGlKEc2Df5+Wwv1+81f7zSTNZIQp8eFBn3Q+Byf5s5cjLlXKBkC5k xQay0dNHV/nzLYhqWxE0iCJDPYhd0WxmEuEX+eqaoySmZ4DnvWps000HmyLc9VufDfxz 9d6HkvO7MwnCQIypVBOm8ts8+EgQGFtORka70SKwASt7I8rG2gku30mee0wZBzt0IQyv X0jCUZmdKSyJ1bCS9VYU2mMvbJlNc+TPTkJTDpvaO5TUkr5oXl1Bc8MNYDBoArxa+OHp tm+Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:message-id:mime-version:subject:date :in-reply-to:cc:to:references; bh=9GoAiPG2LEQgoV4QNFJQzBQIMhm+6qUvLvl/unLdQfM=; b=E6NhyRxL8T60M0fmXf7/uuatacYY1Y20t9215d/5hYuG6FE5vw7+Md6idv6o3hzJ1d 2qFGGwBtPZOdH/E7RDp8/ZFWf1y5GeqP/dKGL5z7llSoHBF791GRww5mhpr6gaTzLTcX veMA39O2tTCAQ3nbryn+67GpjzmtWGRvsOeFlNEXOaUfqiQvoa1TI28m/sKq6Z6DtgNA +jYM/J39MT9cfdNAEmHk0wwJeiqB7zs8yI5ARqmkvmSRkppuqiTMlkYadenNe4s6yGii vnp/DymTbqFTtNkXPA5nxJRZRFrVZMouBclEcswLumWbZBhGUIr9X83GtDuxsVcz/bqU ExkQ== X-Gm-Message-State: AHQUAuZx2qQRn+sGP1UF6yg4rk0wsqpSPvUJuMoNoxJt0Zl7z3WT1IjR C5T2BkHnr97XesvJ2zgJbaC/K4sM X-Google-Smtp-Source: AHgI3IZYLWFNfFWxsnKgUSROM0JS6cIdSQqdrzoYc+TzKZ4k3ZB8yjLR5C81G9LBwyIuLESDsVLS5A== X-Received: by 2002:a62:59d0:: with SMTP id k77mr38937080pfj.211.1550735676842; Wed, 20 Feb 2019 23:54:36 -0800 (PST) Received: from [192.168.20.21] (c-73-19-52-228.hsd1.wa.comcast.net. [73.19.52.228]) by smtp.gmail.com with ESMTPSA id v9sm23747679pgs.3.2019.02.20.23.54.35 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 20 Feb 2019 23:54:36 -0800 (PST) From: "Enji Cooper (yaneurabeya)" Message-Id: Mime-Version: 1.0 (Mac OS X Mail 12.2 \(3445.102.3\)) Subject: Re: svn commit: r344420 - in projects/import-googletest-1.8.1: lib/googletest/gmock lib/googletest/gtest share/mk Date: Wed, 20 Feb 2019 23:54:34 -0800 In-Reply-To: <201902210623.x1L6NWY9018774@pdx.rh.CN85.dnsmgr.net> Cc: Enji Cooper , src-committers@freebsd.org, svn-src-projects@freebsd.org To: rgrimes@freebsd.org References: <201902210623.x1L6NWY9018774@pdx.rh.CN85.dnsmgr.net> X-Mailer: Apple Mail (2.3445.102.3) X-Rspamd-Queue-Id: 4E916948E9 X-Spamd-Bar: ------ Authentication-Results: mx1.freebsd.org X-Spamd-Result: default: False [-6.94 / 15.00]; NEURAL_HAM_MEDIUM(-1.00)[-1.000,0]; NEURAL_HAM_LONG(-1.00)[-1.000,0]; REPLY(-4.00)[]; NEURAL_HAM_SHORT(-0.94)[-0.937,0] Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Content-Filtered-By: Mailman/MimeDel 2.1.29 X-BeenThere: svn-src-projects@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "SVN commit messages for the src " projects" tree" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 21 Feb 2019 07:54:39 -0000 > On Feb 20, 2019, at 10:23 PM, Rodney W. Grimes = wrote: >=20 >> Author: ngie >> Date: Thu Feb 21 04:47:44 2019 >> New Revision: 344420 >> URL: https://svnweb.freebsd.org/changeset/base/344420 = >>=20 >> Log: >> Use gmock/gtest headers when PRIVATELIB is defined >>=20 >> The move to /usr/include/private prefixed paths seems to require a = bit more >> effort in order to compile programs. >>=20 >> Install the headers to /usr/include/private/g{mock,test}/... and = automatically >> include /usr/include/private in GTESTS_CXXFLAGS to make compilation = seamless. I >> will work on the more global problem later with @bdrewery. >=20 > Is this also hooked in to a (cd /usr/src/ && make includes) if gtest = is enabled? To clarify, are you asking if the headers are installed via =E2=80=9Cmake = includes=E2=80=9D? Yes, they were before and after this commit. The only thing that=E2=80=99s= changed is where they are installed (/usr/include/g{mock,test} -> = /usr/include/private/g{mock,test}). Cheers! -Enji=