From owner-freebsd-toolchain@FreeBSD.ORG Thu May 17 19:23:41 2012 Return-Path: Delivered-To: freebsd-toolchain@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id F081E1065670 for ; Thu, 17 May 2012 19:23:41 +0000 (UTC) (envelope-from pfg@freebsd.org) Received: from nm27-vm2.bullet.mail.ne1.yahoo.com (nm27-vm2.bullet.mail.ne1.yahoo.com [98.138.91.215]) by mx1.freebsd.org (Postfix) with SMTP id 744E58FC0A for ; Thu, 17 May 2012 19:23:41 +0000 (UTC) Received: from [98.138.90.48] by nm27.bullet.mail.ne1.yahoo.com with NNFMP; 17 May 2012 19:23:35 -0000 Received: from [98.138.84.47] by tm1.bullet.mail.ne1.yahoo.com with NNFMP; 17 May 2012 19:23:35 -0000 Received: from [127.0.0.1] by smtp115.mail.ne1.yahoo.com with NNFMP; 17 May 2012 19:23:35 -0000 X-Yahoo-Newman-Id: 599928.26148.bm@smtp115.mail.ne1.yahoo.com X-Yahoo-Newman-Property: ymail-3 X-YMail-OSG: Vhm8ZTEVM1klTadLKjcbXxAvzbtcV0iCtTFuoME_9AqYcqP iHcUBmF3BFByfD7FnP.cWD_d0y4WxmwplM5VR4KzgH53dAPgBQQSajBavkl2 Pk_ySUS_Jf19RpbTqc1Ya2FhIxkOb3sb632dWvvJIbnm5GiIDSsfPtVl.Jz8 p_tnn5g0imsB2lGcJl42Js_NmLRNE4IERU6ilrQetQDuU.GVxYF2V7miQDhE 4gi905.qcBcy1l3.I0FkYVL9_5E83kuKwJX1McuHun1bEzgd70qCR5LcCg5p lVu_tj8XLKrjp.Jy6h8sMZDwqYznJA1gBp5Y_Dz.unHBOHue0eMZGPqsbR7n uvVmUbn67OR.njI6g9tXshNa83wGLxLZzJ2tBiYKs7BofA4ZEWHIxPXX8YiV dUmFEuz835cOSewIfnhHi_UmjAznWzE5T6_7dXiNqyyHwsD4Vm2jmN5Z389x U3BKVP5e18B5_EiiVkmOFjbRIIivycax7scZOiNNY7l.Vv0TumUurzFTPhCb irzHTqQ-- X-Yahoo-SMTP: xcjD0guswBAZaPPIbxpWwLcp9Unf Received: from [192.168.10.103] (pfg@200.118.157.7 with plain) by smtp115.mail.ne1.yahoo.com with SMTP; 17 May 2012 12:23:35 -0700 PDT Message-ID: <4FB55034.2080404@FreeBSD.org> Date: Thu, 17 May 2012 14:23:32 -0500 From: Pedro Giffuni User-Agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:10.0.3) Gecko/20120328 Thunderbird/10.0.3 MIME-Version: 1.0 To: Dimitry Andric References: <4FB51CDF.3040306@FreeBSD.org> <4FB52AF9.1010306@andric.com> In-Reply-To: <4FB52AF9.1010306@andric.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: freebsd-current@FreeBSD.org, freebsd-toolchain@FreeBSD.org Subject: Re: GCC update for testing X-BeenThere: freebsd-toolchain@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Maintenance of FreeBSD's integrated toolchain List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 17 May 2012 19:23:42 -0000 Hi Dimitry; On 05/17/12 11:44, Dimitry Andric wrote: > On 2012-05-17 17:44, Pedro Giffuni wrote:> Hi; >> I took a bunch of patches that were merged into the GCC 4.1 branch >> (under GPLv2) and prepared a patch for merging them into our base >> gcc. These are supposed to be bug fixes only. >> >> You can get the patch here: >> http://people.freebsd.org/~pfg/patches/patch-contrib-gcc >> And, for those really interested, the log is here: >> http://people.freebsd.org/~pfg/patches/gcc41-pr-log >> >> It may be my imagination but the patch seems to be causing more >> warnings than usual and it breaks the kernel here: > ... >> ../../../cam/scsi/scsi_sa.c: In function 'samount': >> ../../../cam/scsi/scsi_sa.c:1887: warning: 'comp_supported' may be used >> uninitialized in this function >> ../../../cam/scsi/scsi_sa.c:1888: warning: 'write_protect' may be used >> uninitialized in this function > These warnings seem wrong, upon casual inspection of the code. In any > case, if you compile the same file with gcc 4.7, they don't appear. :) > > Any idea which particular gcc fix is responsible for them? > > As a workaround, we could set all those variable to some reasonable > value, but that feels like a cheap trick to me... > > But I'd rather just not import the fix that causes those warnings. I will have to dig deeper into the changes to see what causes this. In any case I do agree and the patch will not be committed. Ultimately I can just leave the list around and we bring them in only as needed. Pedro.