From owner-svn-src-head@freebsd.org Mon Dec 10 09:17:17 2018 Return-Path: Delivered-To: svn-src-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id B87C513177E0; Mon, 10 Dec 2018 09:17:17 +0000 (UTC) (envelope-from se@freebsd.org) Received: from mailout03.t-online.de (mailout03.t-online.de [194.25.134.81]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "mailout00.t-online.de", Issuer "TeleSec ServerPass DE-2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id C7B8C6F14A; Mon, 10 Dec 2018 09:17:16 +0000 (UTC) (envelope-from se@freebsd.org) Received: from fwd26.aul.t-online.de (fwd26.aul.t-online.de [172.20.26.131]) by mailout03.t-online.de (Postfix) with SMTP id 2FCB3427F354; Mon, 10 Dec 2018 10:17:09 +0100 (CET) Received: from Stefans-MBP-LAN.fritz.box (rPaYTvZGYhzcZGO3uuulOTU9PgBXwg6AztbZHLN68uBZVQkbOA6c1jHZHd7vlzxgFQ@[93.200.55.147]) by fwd26.t-online.de with (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384 encrypted) esmtp id 1gWHgW-3Ukf9U0; Mon, 10 Dec 2018 10:17:04 +0100 Subject: Re: svn commit: r341759 - in head: contrib/wpa contrib/wpa/hostapd contrib/wpa/hs20/client contrib/wpa/src/ap contrib/wpa/src/common contrib/wpa/src/crypto contrib/wpa/src/drivers contrib/wpa/src/eap_c... To: Warner Losh , Cy Schubert , "Rodney W. Grimes" , Oliver Pinter , Cy Schubert Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers References: <201812100619.wBA6JB0c064609@pdx.rh.CN85.dnsmgr.net> <201812100640.wBA6eaMA052004@slippy.cwsent.com> From: Stefan Esser Openpgp: preference=signencrypt Autocrypt: addr=se@freebsd.org; prefer-encrypt=mutual; keydata= xsBNBFVxiRIBCADOLNOZBsqlplHUQ3tG782FNtVT33rQli9EjNt2fhFERHIo4NxHlWBpHLnU b0s4L/eItx7au0i7Gegv01A9LUMwOnAc9EFAm4EW3Wmoa6MYrcP7xDClohg/Y69f7SNpEs3x YATBy+L6NzWZbJjZXD4vqPgZSDuMcLU7BEdJf0f+6h1BJPnGuwHpsSdnnMrZeIM8xQ8PPUVQ L0GZkVojHgNUngJH6e21qDrud0BkdiBcij0M3TCP4GQrJ/YMdurfc8mhueLpwGR2U1W8TYB7 4UY+NLw0McThOCLCxXflIeF/Y7jSB0zxzvb/H3LWkodUTkV57yX9IbUAGA5RKRg9zsUtABEB AAHNKVN0ZWZhbiBFw59lciAoWWFob28hKSA8c3QuZXNzZXJAeWFob28uZGU+wsCWBBMBCgBA AhsDBwsJCAcDAgEGFQgCCQoLBBYCAwECHgECF4AWIQSjceplnAvsyCtxUxNH67XvWv31RAUC WvLvqwUJCyUBEwAKCRBH67XvWv31REySCACc6vqcSFQCRyBRc2CV5ZBjbbnTy7VBoXbUS3/c 4Hn8I0YQ39q7//2z8vYsgLeM1mMXL4PUIU/0f0dBAFBLpxV7bntGzyCJls6SeGS/qcQKhqaI 6I7NcWg8OkIJIhUL6q238cS1ql9pU65fyHe0PP8JS08m81PDpX2/4wTE6h2jgYUy55eXRzoF MEjr1S8SSnidsBem27o7iWu9ltJsUtE86071iZlLzbuHv2nvucrjAV9cK9tHrxYT/YiY8QhT L48iWj2xIjLjg1ebmgIFZ2k881we/KTIoUugqOOR1gDSc4qwM8CA388cN3frjtl98CwhAT5T UV8tIDqri+/Z1AKwzsBNBFVxiRIBCACxI/aglzGVbnI6XHd0MTP05VK/fJub4hHdc+LQpz1M kVnCAhFbY9oecTB/togdKtfiloavjbFrb0nJhJnx57K+3SdSuu+znaQ4SlWiZOtXnkbpRWNU eMm+gtTDMSvloGAfr76RtFHskdDOLgXsHD70bKuMhlBxUCrSwGzHaD00q8iQPhJZ5itb3WPq z3B4IjiDAWTO2obD1wtAvSuHuUj/XJRsiKDKW3x13cfavkad81bZW4cpNwUv8XHLv/vaZPSA ly+hkY7NrDZydMMXVNQ7AJQufWuTJ0q7sImRcEZ5EIa98esJPey4O7C0vY405wjeyxpVZkpq ThDMurqtQFn1ABEBAAHCwHwEGAEKACYCGwwWIQSjceplnAvsyCtxUxNH67XvWv31RAUCWvLv qwUJCyUBGQAKCRBH67XvWv31RLnrB/9gzcRlpx71sDMosoZULWn7wysBJ/8AIEfIByRaHQe3 pn/KwE57pB+zFbbQqB7YzeZb7/UUgR4zU2ZbOcEfwDZcHUbj0B3fGRsS3t0uiLlAd8w0sBZb SxrqzjdpDjIbOZkxssqUmvrsN67UG1AFWH9aD24keBS7YjPBS8hLxPeYV+Xz6vUL8fRZje/Z JgiBMIwyj6g2lH/zkdnxBdC0iG1xxJOLTaghMMeQyCdH6ef8+VMyAlAJsMckbOTvx63tY8z7 DFcrnTJfbe1EziRilVsEaK8tTzJzhcTfos+f3eBYWEilxe5HzIhYKJeC7lmsSUcGwa6+9VRg a0ctmi9Z8OgX Message-ID: <2b0c3d91-54b6-37d9-e934-a87629b399fd@freebsd.org> Date: Mon, 10 Dec 2018 10:17:03 +0100 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.14; rv:60.0) Gecko/20100101 Thunderbird/60.3.3 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=windows-1252 Content-Language: en-US Content-Transfer-Encoding: 8bit X-ID: rPaYTvZGYhzcZGO3uuulOTU9PgBXwg6AztbZHLN68uBZVQkbOA6c1jHZHd7vlzxgFQ X-TOI-MSGID: b74ff86d-fa7c-405d-91a8-97bb96455f23 X-Rspamd-Queue-Id: C7B8C6F14A X-Spamd-Result: default: False [-2.91 / 15.00]; local_wl_from(0.00)[freebsd.org]; NEURAL_HAM_MEDIUM(-0.99)[-0.992,0]; NEURAL_HAM_LONG(-0.95)[-0.950,0]; NEURAL_HAM_SHORT(-0.97)[-0.971,0]; ASN(0.00)[asn:3320, ipnet:194.25.0.0/16, country:DE] X-Rspamd-Server: mx1.freebsd.org X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 10 Dec 2018 09:17:18 -0000 Am 10.12.18 um 07:47 schrieb Warner Losh: > > > On Sun, Dec 9, 2018, 11:40 PM Cy Schubert wrote: > > In message <201812100619.wBA6JB0c064609@pdx.rh.CN85.dnsmgr.net > >, > "Rodney W. Gri > mes" writes: > > > On Sun, Dec 9, 2018 at 2:03 PM Oliver Pinter > > > > > > > wrote: > > > > > > > > > > > > > > > On Sunday, December 9, 2018, Warner Losh > wrote: > > > > > > > >> On Sun, Dec 9, 2018 at 1:09 PM Rodney W. Grimes < > > > >> freebsd@pdx.rh.cn85.dnsmgr.net > > wrote: > > > >> > > > >> > > In message <201812090645.wB96jnso066329@repo.freebsd.org > >, Cy > > > >> Schubert > > > >> > > writes: > > > >> > > > Author: cy > > > >> > > > Date: Sun Dec  9 06:45:49 2018 > > > >> > > > New Revision: 341759 > > > >> > > > URL: https://svnweb.freebsd.org/changeset/base/341759 > > > >> > > > > > > >> > > > Log: > > > >> > > >   MFV r341618: > > > >> > > > > > > >> > > >   Update wpa 2.6 --> 2.7. > > > >> > > > > > >> > > Relnotes: yes > > > >> > > > > >> > As an FYI, or maybe a new procedure, doing a reply to > > > >> > a commit message adding relnotes: yes does very little > > > >> > to insure that this commit gets refered to in release > > > >> > notes. > > > >> > > > > >> > What about we add RELNOTES.missed to the tree > > > >> > next to UPDATING, and when someone forgets to tag > > > >> > the Relnotes:yes into a commit you just follow up > > > >> > with a commit to that file, stating the svn revision > > > >> > which was missing the note and then we have a nice > > > >> > documented and clean way to extract the missing > > > >> > release note items, rather than trying to cull it > > > >> > from a thread in a mail list archive. > > > >> > > > > >> > The file would get truncated to 0 at appropriate > > > >> > times on various branches. > > > >> > > > > >> > > > >> How about just RELNOTES. You put the revision that is relevant and > a qui > > ck > > > >> blurb. That way we don't have to look in two places. All release > notes g > > o > > > >> in here, no exceptions. You can retroactively tag them, or you can > commi > > t > > > >> this as part of commit. > > > > My one concern is that if we remove the Relnotes: yes line > > from the commits then we may end up totally ignoring the > > need to put entries in RELNOTES, which unlike UPDATING > > do not have consequences if ignored. > > > > > > > > > > > > > >> > > > > I don't really know SVN, but there wouldn't be a chicken egg probem > durin > > g > > > > commit time? I mean you would really know the SVN id. So you could > only a > > dd > > > > a specific revision in a different commit to RELEASE file. > > > > > > > > > > Generally, you can guess really well, and fix it in the case of a lost > race > > > easily. > > > > No reason to guess, if you add the RELNOTES change with the commit > > then it is the revision that added the RELNOTES entry, so a log view > > of RELNOTES would show you the revision.  If you do it after words > > or edit an existing entry in the RELNOTES file that is also fairly > > clear as that commit has no other files touched. > > > > > > > > You'd add the release notes text in full to the file, with a pointer > to the > > > revision(s) for the feature. > > > > If you modify RELNOTES with the commit adding the feature we > > could easily use a pointer of "this commit", the svn version number > > of that added entry is self referencing to the actual change, > > which I actually rather like the idea of. > > > > > > > > Warner > > > > > > > > > > >> Have a blurb at the top that tells people what > > > >> order to add them in, and you'd be set. We'd then retire "relnotes: > yes" > > > >> in > > > >> the commit message. This would also allow 'helpers' to format the > RELNOT > > ES > > > >> file as we go rather than having to play 2 years of catch-up at major > > > >> branch times. > > > > Yes.  You could actually "delete" an entry from RELNOTES once a > > proper entry in the actual release notes had been created, such > > that RELNOTES is really a list of pending items. > > > > > >> > > > >> Having it in the commit message just doesn't work, and this is one > of ma > > ny > > > >> reasons: Cy forgot. Other times I'll do something and it's only a month > > > >> later I realize it needs to be in the release notes after some > issue has > > > >> come up.... Other times I put relnotes: yes in only to realize > that's my > > > >> vanity talking, and nobody else cares. > > > > I agree, what we have now works poorly. > > Forgetting, yes, but also a hmmm moment. > > Initially my thinking was a file in doc/. Or maybe something like the > vuxml port where we fill in the blanks and make validate to make sure > all the i's are dotted and t's crossed. It's a little extra work for > committers but would help re@ immensely, and get the details in from > the get-go. > > My thought was a low friction,  proximate way to do a ticker of important > changes. Doc repo is too hard. Too much friction. A simple extra file puts it > all in one, easy to find and edit place... it can cause other things to > happen, further away. But it needs to be close by. IMHO it would be easiest to use and to remember to just perform a forced commit to any of the files affected by the change and to set RELNOTES in that commit. The commit message could further contain a SVN revision number of the relevant change (mandatory, if it has not been the previous commit to that file) and optionally an explanatory text for the RE. This could be automated by allowing the revision affected (or a few words of explanation) to be put on the RELNOTES line - assume there already is a script that scans the repository for such entries and that script could be enhanced to automatically retrieve the commit message from a referenced earlier commit, for example. Regards, STefan