From owner-cvs-all Sat Sep 14 12: 8:46 2002 Delivered-To: cvs-all@freebsd.org Received: from mx1.FreeBSD.org (mx1.FreeBSD.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 0AA8C37B400; Sat, 14 Sep 2002 12:08:42 -0700 (PDT) Received: from apollo.backplane.com (apollo.backplane.com [216.240.41.2]) by mx1.FreeBSD.org (Postfix) with ESMTP id 7C23543E6A; Sat, 14 Sep 2002 12:08:41 -0700 (PDT) (envelope-from dillon@apollo.backplane.com) Received: from apollo.backplane.com (localhost [127.0.0.1]) by apollo.backplane.com (8.12.5/8.12.4) with ESMTP id g8EJ8bPQ052973; Sat, 14 Sep 2002 12:08:38 -0700 (PDT) (envelope-from dillon@apollo.backplane.com) Received: (from dillon@localhost) by apollo.backplane.com (8.12.5/8.12.4/Submit) id g8EJ8bUd052972; Sat, 14 Sep 2002 12:08:37 -0700 (PDT) (envelope-from dillon) Date: Sat, 14 Sep 2002 12:08:37 -0700 (PDT) From: Matthew Dillon Message-Id: <200209141908.g8EJ8bUd052972@apollo.backplane.com> To: Poul-Henning Kamp Cc: Bruce Evans , cvs-committers@FreeBSD.ORG, cvs-all@FreeBSD.ORG Subject: Re: cvs commit: src/sys/kern vfs_bio.c src/sys/sys bio.h References: <10588.1032020135@critter.freebsd.dk> Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG :In message <20020914032217.V10972-100000@gamplex.bde.org>, Bruce Evans writes: : :>Isn't the "correct" locking just splbio() in RELENG_4 (if this function were :>merged, haha) and Giant in -current. bufwait() just uses splbio() :>unconditionally. Of course, Giant is not really correct. : :Forget -stable. In -current Giant would currently be a usable :default, except that it would likely perform worse than the timeout :currently used. Down the road Giant is almost guaranteed to be :wrong, and therefore I didn't want to employ at this time. : :-- :Poul-Henning Kamp | UNIX since Zilog Zeus 3.20 :phk@FreeBSD.ORG | TCP/IP since RFC 956 :FreeBSD committer | BSD since 4.3-tahoe :Never attribute to malice what can adequately be explained by incompetence. Well, the buffer is owned at the time of the BIO_DONE and you have a lock structure sitting right there, why not simply use the lock structure's interlock? Note I said 'interlock' here, not the main lock. -Matt Matthew Dillon To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message