Skip site navigation (1)Skip section navigation (2)
Date:      Fri, 27 Jul 2012 06:29:34 +0200
From:      Carlo Strub <cs@FreeBSD.org>
To:        sunpoet@FreeBSD.org,
Cc:        svn-ports-head@freebsd.org, svn-ports-all@freebsd.org, ports-committers@freebsd.org
Subject:   Re: svn commit: r301519 - in head: audio/rosegarden devel/alabastra devel/deheader devel/elfsh devel/fpc [...]  [ID#2012072709000131]
Message-ID:  <1343363374.29416.9188983992.47820.2@c-st.net>
In-Reply-To: <CAMHz58RsOW1hf81kFQtDNbqgPqV5_jcQ53hFVD%2BWHdhFYb2OhA@mail.gmail.com>
References:  <CAMHz58RsOW1hf81kFQtDNbqgPqV5_jcQ53hFVD%2BWHdhFYb2OhA@mail.gmail.com><201207251124.q6PBOBor052179@svn.freebsd.org>

next in thread | previous in thread | raw e-mail | index | archive | help
07/27/2012 04:55 - Sunpoet Po-Chuan Hsieh wrote:

> Hi Carlo,
>=20
> Thanks for your work to fix typos in COMMENT to make it better.
>=20
> On Wed, Jul 25, 2012 at 7:24 PM, Carlo Strub <cs@freebsd.org> wrote:
> > Modified: head/devel/p5-Config-Perl-V/Makefile
> > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D
> > -COMMENT=3D       Structured data retreival of perl -V output
> > +COMMENT=3D       Structured data retrieval of Perl -V output
>=20
> IMHO, "perl" here means the interpreter, not the language, therefore
> the original one is correct.
>=20
> > Modified: head/devel/p5-Eval-Context/Makefile
> > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D
> > -COMMENT=3D       Evalute perl code in context wraper
> > +COMMENT=3D       Evalute perl code in context wrapper
>=20
> Should this be "Evaluate"?
>=20
> BTW, since this commit not only modified ports maintained by perl@ and
> ports@, but also ports maintained by various maintainers. Did you get
> any approval from portmgr@ before this commit?
>=20
> Regards,
> sunpoet
>=20



Hi sunpoet,
Thanks for these important hints. I'll fix them. I did not get approval fro=
m portmgr@ as I thought my changes were minor. But you are right. I will no=
w ask portmgr@ first before continuing.

Best,
Carlo



--
Carlo Strub
Ports committer
--=



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?1343363374.29416.9188983992.47820.2>