From owner-cvs-all@FreeBSD.ORG Fri Jun 4 11:37:37 2004 Return-Path: Delivered-To: cvs-all@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 777EA16A4D0 for ; Fri, 4 Jun 2004 11:37:37 -0700 (PDT) Received: from mail4.speakeasy.net (mail4.speakeasy.net [216.254.0.204]) by mx1.FreeBSD.org (Postfix) with ESMTP id 58EB843D2F for ; Fri, 4 Jun 2004 11:37:37 -0700 (PDT) (envelope-from jhb@FreeBSD.org) Received: (qmail 18025 invoked from network); 4 Jun 2004 18:36:54 -0000 Received: from dsl027-160-063.atl1.dsl.speakeasy.net (HELO server.baldwin.cx) ([216.27.160.63]) (envelope-sender ) encrypted SMTP for ; 4 Jun 2004 18:36:54 -0000 Received: from 10.50.41.233 (gw1.twc.weather.com [216.133.140.1]) by server.baldwin.cx (8.12.11/8.12.11) with ESMTP id i54IamFI082863; Fri, 4 Jun 2004 14:36:48 -0400 (EDT) (envelope-from jhb@FreeBSD.org) From: John Baldwin To: Nate Lawson Date: Fri, 4 Jun 2004 14:37:34 -0400 User-Agent: KMail/1.6 References: <14534.1086328303@critter.freebsd.dk> <20040604101725.X50992@root.org> In-Reply-To: <20040604101725.X50992@root.org> MIME-Version: 1.0 Content-Disposition: inline Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Message-Id: <200406041437.34052.jhb@FreeBSD.org> X-Spam-Checker-Version: SpamAssassin 2.63 (2004-01-11) on server.baldwin.cx cc: cvs-src@FreeBSD.org cc: Poul-Henning Kamp cc: src-committers@FreeBSD.org cc: cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/i386/include/pc bios.h src/sys/i386/i386 bios.c X-BeenThere: cvs-all@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the entire tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 04 Jun 2004 18:37:37 -0000 On Friday 04 June 2004 01:18 pm, Nate Lawson wrote: > On Fri, 4 Jun 2004, Poul-Henning Kamp wrote: > > In message <20040603160405.E45592@root.org>, Nate Lawson writes: > > >Many BIOS strings have alignment requirements. That might be useful to > > >add. > > > > Once we need it we'll know what to add. Adding it now without any code > > which needs it would violate the third X11 principle: > > > > 3.The only thing worse than generalizing from one example > > is generalizing from no examples at all. > > sys/i386/libi386/biosacpi.c > > And all ACPI tables must be 16-byte aligned. As is the MP Table, $PIR, _32_, and $PnP. Note that bios_sigsearch() takes an alignment (called paragraph length or some such). -- John Baldwin <>< http://www.FreeBSD.org/~jhb/ "Power Users Use the Power to Serve" = http://www.FreeBSD.org